All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Takahiro Kuwano <takahiro.kuwano@infineon.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
Date: Tue, 02 Jun 2026 11:58:17 +0200	[thread overview]
Message-ID: <87zf1dmfgm.fsf@bootlin.com> (raw)
In-Reply-To: <20260601125438.3481722-3-mwalle@kernel.org> (Michael Walle's message of "Mon, 1 Jun 2026 14:52:44 +0200")

On 01/06/2026 at 14:52:44 +02, Michael Walle <mwalle@kernel.org> wrote:

> This was introduced in commit 548ed6847f530 ("mtd: spi-nor: Add the
> SNOR_F_4B_OPCODES flag"). It looks like it was the rollback mechanism if
> parsing the SFDP failed, but was setting that flag first. Nowadays, that
> flag can only be set if spi_nor_parse_4bait() was successful. IOW, the
> flags won't be left in an undefined state if parsing SFDP fails.
>
> Remove the unneeded code to be able to rework spi_nor_init_params().
>
> Signed-off-by: Michael Walle <mwalle@kernel.org>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Takahiro Kuwano <takahiro.kuwano@infineon.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
Date: Tue, 02 Jun 2026 11:58:17 +0200	[thread overview]
Message-ID: <87zf1dmfgm.fsf@bootlin.com> (raw)
In-Reply-To: <20260601125438.3481722-3-mwalle@kernel.org> (Michael Walle's message of "Mon, 1 Jun 2026 14:52:44 +0200")

On 01/06/2026 at 14:52:44 +02, Michael Walle <mwalle@kernel.org> wrote:

> This was introduced in commit 548ed6847f530 ("mtd: spi-nor: Add the
> SNOR_F_4B_OPCODES flag"). It looks like it was the rollback mechanism if
> parsing the SFDP failed, but was setting that flag first. Nowadays, that
> flag can only be set if spi_nor_parse_4bait() was successful. IOW, the
> flags won't be left in an undefined state if parsing SFDP fails.
>
> Remove the unneeded code to be able to rework spi_nor_init_params().
>
> Signed-off-by: Michael Walle <mwalle@kernel.org>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

  reply	other threads:[~2026-06-02  9:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 12:52 [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization Michael Walle
2026-06-01 12:52 ` Michael Walle
2026-06-01 12:52 ` [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-02  9:57   ` Miquel Raynal
2026-06-02  9:57     ` Miquel Raynal
2026-06-02 11:01     ` Michael Walle
2026-06-02 11:01       ` Michael Walle
2026-06-05  8:05   ` Takahiro.Kuwano
2026-06-05  8:05     ` Takahiro.Kuwano
2026-06-05 13:05   ` Tudor Ambarus
2026-06-05 13:05     ` Tudor Ambarus
2026-06-01 12:52 ` [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-02  9:58   ` Miquel Raynal [this message]
2026-06-02  9:58     ` Miquel Raynal
2026-06-05  8:15   ` Takahiro.Kuwano
2026-06-05  8:15     ` Takahiro.Kuwano
2026-06-05 13:05   ` Tudor Ambarus
2026-06-05 13:05     ` Tudor Ambarus
2026-06-01 12:52 ` [RFC PATCH 3/3] mtd: spi-nor: rework flash parameter initialization Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-05 13:17   ` Tudor Ambarus
2026-06-05 13:17     ` Tudor Ambarus
2026-06-02 10:03 ` [RFC PATCH 0/3] mtd: spi-nor: Rework " Miquel Raynal
2026-06-02 10:03   ` Miquel Raynal
2026-06-03  0:13   ` Takahiro.Kuwano
2026-06-03  0:13     ` Takahiro.Kuwano
2026-06-05  8:50     ` Takahiro.Kuwano
2026-06-05  8:50       ` Takahiro.Kuwano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf1dmfgm.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=takahiro.kuwano@infineon.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.