All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
Date: Tue, 02 Jun 2026 13:01:43 +0200	[thread overview]
Message-ID: <DIYIGDO5RR8X.BYFE5UUAEAN6@kernel.org> (raw)
In-Reply-To: <875x41nu2c.fsf@bootlin.com>

On Tue Jun 2, 2026 at 11:57 AM CEST, Miquel Raynal wrote:
> Hi Michael,
>
>> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
>> index 65227d989de1..092450375d4e 100644
>> --- a/drivers/mtd/spi-nor/spansion.c
>> +++ b/drivers/mtd/spi-nor/spansion.c
>> @@ -868,7 +868,7 @@ static const struct flash_info spansion_nor_parts[] = {
>>  		.name = "s25fl256s0",
>>  		.size = SZ_32M,
>>  		.sector_size = SZ_256K,
>> -		.no_sfdp_flags = SPI_NOR_SKIP_SFDP | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>> +		.no_sfdp_flags = SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>>  		.mfr_flags = USE_CLSR,
>>  	}, {
>>  		.id = SNOR_ID(0x01, 0x02, 0x19, 0x4d, 0x00, 0x81),
>
> Fine by me. I believe the expected behaviour should just be an empty
> feedback, leading to the SFDP to be invalid and thus SFDP parsing
> skipped, right?

Right. Probably it will read all ones or all zeros and the parsing
will fail and skipped.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
Date: Tue, 02 Jun 2026 13:01:43 +0200	[thread overview]
Message-ID: <DIYIGDO5RR8X.BYFE5UUAEAN6@kernel.org> (raw)
In-Reply-To: <875x41nu2c.fsf@bootlin.com>

On Tue Jun 2, 2026 at 11:57 AM CEST, Miquel Raynal wrote:
> Hi Michael,
>
>> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
>> index 65227d989de1..092450375d4e 100644
>> --- a/drivers/mtd/spi-nor/spansion.c
>> +++ b/drivers/mtd/spi-nor/spansion.c
>> @@ -868,7 +868,7 @@ static const struct flash_info spansion_nor_parts[] = {
>>  		.name = "s25fl256s0",
>>  		.size = SZ_32M,
>>  		.sector_size = SZ_256K,
>> -		.no_sfdp_flags = SPI_NOR_SKIP_SFDP | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>> +		.no_sfdp_flags = SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>>  		.mfr_flags = USE_CLSR,
>>  	}, {
>>  		.id = SNOR_ID(0x01, 0x02, 0x19, 0x4d, 0x00, 0x81),
>
> Fine by me. I believe the expected behaviour should just be an empty
> feedback, leading to the SFDP to be invalid and thus SFDP parsing
> skipped, right?

Right. Probably it will read all ones or all zeros and the parsing
will fail and skipped.

-michael

  reply	other threads:[~2026-06-02 11:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 12:52 [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization Michael Walle
2026-06-01 12:52 ` Michael Walle
2026-06-01 12:52 ` [RFC PATCH 1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-02  9:57   ` Miquel Raynal
2026-06-02  9:57     ` Miquel Raynal
2026-06-02 11:01     ` Michael Walle [this message]
2026-06-02 11:01       ` Michael Walle
2026-06-05  8:05   ` Takahiro.Kuwano
2026-06-05  8:05     ` Takahiro.Kuwano
2026-06-05 13:05   ` Tudor Ambarus
2026-06-05 13:05     ` Tudor Ambarus
2026-06-01 12:52 ` [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-02  9:58   ` Miquel Raynal
2026-06-02  9:58     ` Miquel Raynal
2026-06-05  8:15   ` Takahiro.Kuwano
2026-06-05  8:15     ` Takahiro.Kuwano
2026-06-05 13:05   ` Tudor Ambarus
2026-06-05 13:05     ` Tudor Ambarus
2026-06-01 12:52 ` [RFC PATCH 3/3] mtd: spi-nor: rework flash parameter initialization Michael Walle
2026-06-01 12:52   ` Michael Walle
2026-06-05 13:17   ` Tudor Ambarus
2026-06-05 13:17     ` Tudor Ambarus
2026-06-02 10:03 ` [RFC PATCH 0/3] mtd: spi-nor: Rework " Miquel Raynal
2026-06-02 10:03   ` Miquel Raynal
2026-06-03  0:13   ` Takahiro.Kuwano
2026-06-03  0:13     ` Takahiro.Kuwano
2026-06-05  8:50     ` Takahiro.Kuwano
2026-06-05  8:50       ` Takahiro.Kuwano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIYIGDO5RR8X.BYFE5UUAEAN6@kernel.org \
    --to=mwalle@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=takahiro.kuwano@infineon.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.