From: Jani Nikula <jani.nikula@linux.intel.com>
To: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
Date: Mon, 11 Sep 2017 12:02:35 +0000 [thread overview]
Message-ID: <87zia130kk.fsf@nikula.org> (raw)
In-Reply-To: <20170910085642.13673-1-christophe.jaillet@wanadoo.fr>
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
Date: Mon, 11 Sep 2017 15:02:35 +0300 [thread overview]
Message-ID: <87zia130kk.fsf@nikula.org> (raw)
In-Reply-To: <20170910085642.13673-1-christophe.jaillet@wanadoo.fr>
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
Date: Mon, 11 Sep 2017 15:02:35 +0300 [thread overview]
Message-ID: <87zia130kk.fsf@nikula.org> (raw)
In-Reply-To: <20170910085642.13673-1-christophe.jaillet@wanadoo.fr>
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-09-11 12:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 8:56 [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()' Christophe JAILLET
2017-09-10 8:56 ` Christophe JAILLET
2017-09-10 9:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-10 10:17 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-11 12:02 ` Jani Nikula [this message]
2017-09-11 12:02 ` [PATCH] " Jani Nikula
2017-09-11 12:02 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zia130kk.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.