* [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
@ 2017-09-10 8:56 ` Christophe JAILLET
0 siblings, 0 replies; 7+ messages in thread
From: Christophe JAILLET @ 2017-09-10 8:56 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors,
Christophe JAILLET
We should go through the error handling path to decrease the
'framebuffer_references' as done everywhere else in this function.
Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7cd392f2cd94..478fa449003f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
DRM_DEBUG_KMS("bad plane %d handle\n", i);
- return -EINVAL;
+ goto err;
}
stride_alignment = intel_fb_stride_alignment(fb, i);
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
@ 2017-09-10 8:56 ` Christophe JAILLET
0 siblings, 0 replies; 7+ messages in thread
From: Christophe JAILLET @ 2017-09-10 8:56 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors,
Christophe JAILLET
We should go through the error handling path to decrease the
'framebuffer_references' as done everywhere else in this function.
Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7cd392f2cd94..478fa449003f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
DRM_DEBUG_KMS("bad plane %d handle\n", i);
- return -EINVAL;
+ goto err;
}
stride_alignment = intel_fb_stride_alignment(fb, i);
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Fix an error handling in 'intel_framebuffer_init()'
2017-09-10 8:56 ` Christophe JAILLET
(?)
@ 2017-09-10 9:20 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-09-10 9:20 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix an error handling in 'intel_framebuffer_init()'
URL : https://patchwork.freedesktop.org/series/30083/
State : success
== Summary ==
Series 30083v1 drm/i915: Fix an error handling in 'intel_framebuffer_init()'
https://patchwork.freedesktop.org/api/1.0/series/30083/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:446s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:454s
fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:377s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:543s
fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:272s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:509s
fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:508s
fi-cfl-s total:289 pass:250 dwarn:4 dfail:0 fail:0 skip:35 time:447s
fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:452s
fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:597s
fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:434s
fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:408s
fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:438s
fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:484s
fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:474s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:493s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:583s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:589s
fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:561s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:460s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:528s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:505s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:457s
fi-skl-x1585l total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:473s
fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:572s
fi-snb-2600 total:289 pass:248 dwarn:0 dfail:0 fail:2 skip:39 time:429s
1584dc5f5d29e4b13ed9f26f86c1a0b54c2db7ef drm-tip: 2017y-09m-09d-09h-25m-58s UTC integration manifest
8f29fe526328 drm/i915: Fix an error handling in 'intel_framebuffer_init()'
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5628/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: Fix an error handling in 'intel_framebuffer_init()'
2017-09-10 8:56 ` Christophe JAILLET
(?)
(?)
@ 2017-09-10 10:17 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-09-10 10:17 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix an error handling in 'intel_framebuffer_init()'
URL : https://patchwork.freedesktop.org/series/30083/
State : failure
== Summary ==
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-varying-size:
pass -> FAIL (shard-hsw)
shard-hsw total:2302 pass:1236 dwarn:0 dfail:0 fail:14 skip:1052 time:9420s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5628/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
2017-09-10 8:56 ` Christophe JAILLET
(?)
@ 2017-09-11 12:02 ` Jani Nikula
-1 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2017-09-11 12:02 UTC (permalink / raw)
To: joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors,
Christophe JAILLET
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
@ 2017-09-11 12:02 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2017-09-11 12:02 UTC (permalink / raw)
To: Christophe JAILLET, joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors,
Christophe JAILLET
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()'
@ 2017-09-11 12:02 ` Jani Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2017-09-11 12:02 UTC (permalink / raw)
To: joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, kernel-janitors,
Christophe JAILLET
On Sun, 10 Sep 2017, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> We should go through the error handling path to decrease the
> 'framebuffer_references' as done everywhere else in this function.
>
> Fixes: 2e2adb05736c ("drm/i915: Add render decompression support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Pushed to drm-intel-next-queued, thanks for the patch.
For future reference, the intel-gfx list will suffice.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..478fa449003f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14077,7 +14077,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>
> if (mode_cmd->handles[i] != mode_cmd->handles[0]) {
> DRM_DEBUG_KMS("bad plane %d handle\n", i);
> - return -EINVAL;
> + goto err;
> }
>
> stride_alignment = intel_fb_stride_alignment(fb, i);
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-11 12:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-10 8:56 [PATCH] drm/i915: Fix an error handling in 'intel_framebuffer_init()' Christophe JAILLET
2017-09-10 8:56 ` Christophe JAILLET
2017-09-10 9:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-10 10:17 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-09-11 12:02 ` [PATCH] " Jani Nikula
2017-09-11 12:02 ` Jani Nikula
2017-09-11 12:02 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.