From: Kalle Valo <kvalo@qca.qualcomm.com>
To: akolli@qti.qualcomm.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0
Date: Mon, 19 Oct 2015 17:40:40 +0300 [thread overview]
Message-ID: <87zizegbvb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Mon, 28 Sep 2015 18:31:18 +0530")
<akolli@qti.qualcomm.com> writes:
> From: Anilkumar Kolli <akolli@qti.qualcomm.com>
>
> This patch disables PCI PS for QCA988X and QCA99X0, Since PCI PS is
> validated for QCA6174, let it be enabled only for QCA6174. It would be
> better to execute PCI PS related functions only for the supported devices.
>
> PCI time out issue is observed with QCA99X0 on x86 platform, We will
> disable PCI PS for QCA988X and QCA99X0 until PCI PS is properly implemented.
>
> Taking and releasing ps_lock is causing higher CPU consumption. Michal Kazior
> suggested ps_lock overhead to be reworked so that ath10k_pci_wake/sleep
> functions are called less often, i.e. move the powersave logic up (only during
> irq handling, tx path, submitting fw commands).
>
> Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
Applied, thanks.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <akolli@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0
Date: Mon, 19 Oct 2015 17:40:40 +0300 [thread overview]
Message-ID: <87zizegbvb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1443445278-11051-1-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Mon, 28 Sep 2015 18:31:18 +0530")
<akolli@qti.qualcomm.com> writes:
> From: Anilkumar Kolli <akolli@qti.qualcomm.com>
>
> This patch disables PCI PS for QCA988X and QCA99X0, Since PCI PS is
> validated for QCA6174, let it be enabled only for QCA6174. It would be
> better to execute PCI PS related functions only for the supported devices.
>
> PCI time out issue is observed with QCA99X0 on x86 platform, We will
> disable PCI PS for QCA988X and QCA99X0 until PCI PS is properly implemented.
>
> Taking and releasing ps_lock is causing higher CPU consumption. Michal Kazior
> suggested ps_lock overhead to be reworked so that ath10k_pci_wake/sleep
> functions are called less often, i.e. move the powersave logic up (only during
> irq handling, tx path, submitting fw commands).
>
> Signed-off-by: Anilkumar Kolli <akolli@qti.qualcomm.com>
Applied, thanks.
--
Kalle Valo
next prev parent reply other threads:[~2015-10-19 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 13:01 [PATCH] ath10k: Disable PCI PS for QCA988X and QCA99X0 akolli
2015-09-28 13:01 ` akolli
2015-10-19 14:40 ` Kalle Valo [this message]
2015-10-19 14:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zizegbvb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=akolli@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.