All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: David Airlie <airlied@linux.ie>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device()
Date: Thu, 01 Oct 2015 11:26:40 +0300	[thread overview]
Message-ID: <87zj03ata7.fsf@intel.com> (raw)
In-Reply-To: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk>

On Wed, 30 Sep 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/vga/vgaarb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
> index a0b433456107..3166e4bc4eb6 100644
> --- a/drivers/gpu/vga/vgaarb.c
> +++ b/drivers/gpu/vga/vgaarb.c
> @@ -531,7 +531,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev)
>  		return false;
>  
>  	/* Allocate structure */
> -	vgadev = kmalloc(sizeof(struct vga_device), GFP_KERNEL);
> +	vgadev = kzalloc(sizeof(struct vga_device), GFP_KERNEL);
>  	if (vgadev == NULL) {
>  		pr_err("failed to allocate pci device\n");
>  		/*
> @@ -541,8 +541,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev)
>  		return false;
>  	}
>  
> -	memset(vgadev, 0, sizeof(*vgadev));
> -
>  	/* Take lock & check for duplicates */
>  	spin_lock_irqsave(&vga_lock, flags);
>  	if (vgadev_find(pdev) != NULL) {
> -- 
> 2.1.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	David Airlie <airlied@linux.ie>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device()
Date: Thu, 01 Oct 2015 11:26:40 +0300	[thread overview]
Message-ID: <87zj03ata7.fsf@intel.com> (raw)
In-Reply-To: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk>

On Wed, 30 Sep 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/vga/vgaarb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
> index a0b433456107..3166e4bc4eb6 100644
> --- a/drivers/gpu/vga/vgaarb.c
> +++ b/drivers/gpu/vga/vgaarb.c
> @@ -531,7 +531,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev)
>  		return false;
>  
>  	/* Allocate structure */
> -	vgadev = kmalloc(sizeof(struct vga_device), GFP_KERNEL);
> +	vgadev = kzalloc(sizeof(struct vga_device), GFP_KERNEL);
>  	if (vgadev == NULL) {
>  		pr_err("failed to allocate pci device\n");
>  		/*
> @@ -541,8 +541,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev)
>  		return false;
>  	}
>  
> -	memset(vgadev, 0, sizeof(*vgadev));
> -
>  	/* Take lock & check for duplicates */
>  	spin_lock_irqsave(&vga_lock, flags);
>  	if (vgadev_find(pdev) != NULL) {
> -- 
> 2.1.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2015-10-01  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 19:57 [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device() Rasmus Villemoes
2015-10-01  8:26 ` Jani Nikula [this message]
2015-10-01  8:26   ` Jani Nikula
2015-10-01  9:25   ` Daniel Vetter
2015-10-01  9:25     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj03ata7.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.