All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@sisk.pl, linux-pm@vger.kernel.org, patches@linaro.org,
	linaro-kernel@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
	rnayak@ti.com, swarren@wwwdotorg.org,
	linux-tegra@vger.kernel.org, horms+renesas@verge.net.au,
	santosh.shilimkar@ti.com, arnd@arndb.de, lenb@kernel.org,
	nsekhar@ti.com, josephl@nvidia.com, deepthi@linux.vnet.ibm.com
Subject: Re: [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping
Date: Wed, 03 Apr 2013 10:47:23 -0700	[thread overview]
Message-ID: <87zjxfzetw.fsf@linaro.org> (raw)
In-Reply-To: <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> (Daniel Lezcano's message of "Wed, 3 Apr 2013 14:15:21 +0200")

Daniel Lezcano <daniel.lezcano@linaro.org> writes:

> The TIME_VALID flag is specified for the different states but
> the time residency computation is not done, no tk flag, no time
> computation in the idle function.
>
> Set the en_core_tk_irqen flag to activate it.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Acked-by: Kevin Hilman <khilman@linaro.org>

Also, is this a regression fix that also needs to hit v3.9?

Kevin

> ---
>  arch/arm/mach-omap2/cpuidle34xx.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
> index 80392fc..4f67a5b 100644
> --- a/arch/arm/mach-omap2/cpuidle34xx.c
> +++ b/arch/arm/mach-omap2/cpuidle34xx.c
> @@ -274,8 +274,9 @@ static int omap3_enter_idle_bm(struct cpuidle_device *dev,
>  static DEFINE_PER_CPU(struct cpuidle_device, omap3_idle_dev);
>  
>  static struct cpuidle_driver omap3_idle_driver = {
> -	.name =		"omap3_idle",
> -	.owner =	THIS_MODULE,
> +	.name             = "omap3_idle",
> +	.owner            = THIS_MODULE,
> +	.en_core_tk_irqen = 1,
>  	.states = {
>  		{
>  			.enter		  = omap3_enter_idle_bm,

WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping
Date: Wed, 03 Apr 2013 10:47:23 -0700	[thread overview]
Message-ID: <87zjxfzetw.fsf@linaro.org> (raw)
In-Reply-To: <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> (Daniel Lezcano's message of "Wed, 3 Apr 2013 14:15:21 +0200")

Daniel Lezcano <daniel.lezcano@linaro.org> writes:

> The TIME_VALID flag is specified for the different states but
> the time residency computation is not done, no tk flag, no time
> computation in the idle function.
>
> Set the en_core_tk_irqen flag to activate it.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Acked-by: Kevin Hilman <khilman@linaro.org>

Also, is this a regression fix that also needs to hit v3.9?

Kevin

> ---
>  arch/arm/mach-omap2/cpuidle34xx.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
> index 80392fc..4f67a5b 100644
> --- a/arch/arm/mach-omap2/cpuidle34xx.c
> +++ b/arch/arm/mach-omap2/cpuidle34xx.c
> @@ -274,8 +274,9 @@ static int omap3_enter_idle_bm(struct cpuidle_device *dev,
>  static DEFINE_PER_CPU(struct cpuidle_device, omap3_idle_dev);
>  
>  static struct cpuidle_driver omap3_idle_driver = {
> -	.name =		"omap3_idle",
> -	.owner =	THIS_MODULE,
> +	.name             = "omap3_idle",
> +	.owner            = THIS_MODULE,
> +	.en_core_tk_irqen = 1,
>  	.states = {
>  		{
>  			.enter		  = omap3_enter_idle_bm,

  reply	other threads:[~2013-04-03 17:47 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 12:15 [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-03 12:15 ` Daniel Lezcano
     [not found] ` <1364991322-20585-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 12:15   ` [PATCH 2/9] ARM: shmobile: pm: fix init sections Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-03 12:15   ` [PATCH 3/9] ARM: shmobile: cpuidle: remove useless WFI function Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-03 12:15   ` [PATCH 6/9] ARM: davinci: cpuidle: fix wrong enter function Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-04  7:16     ` Sekhar Nori
2013-04-04  7:16       ` Sekhar Nori
2013-04-03 12:15   ` [PATCH 9/9] POWERPC: pseries: cpuidle: use time keeping flag Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
     [not found]     ` <1364991322-20585-9-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 14:25       ` Daniel Lezcano
2013-04-03 14:25         ` Daniel Lezcano
2013-04-04 11:01         ` Deepthi Dharwar
2013-04-04 11:01           ` Deepthi Dharwar
2013-04-04 22:30   ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Rafael J. Wysocki
2013-04-04 22:30     ` Rafael J. Wysocki
2013-04-03 12:15 ` [PATCH 4/9] ARM: tegra2: cpuidle: change driver initialization Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 12:15 ` [PATCH 5/9] ARM: tegra: cpuidle: remove useless initialization Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 12:15 ` [PATCH 7/9] intel: cpuidle: remove stop/start critical timings Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
     [not found]   ` <1364991322-20585-7-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-04 22:31     ` Rafael J. Wysocki
2013-04-04 22:31       ` Rafael J. Wysocki
     [not found]       ` <3375360.P4DAA9Jd5Y-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-04-07 20:52         ` Daniel Lezcano
2013-04-07 20:52           ` Daniel Lezcano
     [not found]           ` <5161DC9C.3020703-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-08 17:40             ` Daniel Lezcano
2013-04-08 17:40               ` Daniel Lezcano
     [not found]               ` <51630115.6040205-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-08 19:27                 ` Rafael J. Wysocki
2013-04-08 19:27                   ` Rafael J. Wysocki
2013-04-08 19:27                   ` Daniel Lezcano
2013-04-08 19:27                     ` Daniel Lezcano
2013-04-19 22:02     ` Len Brown
2013-04-19 22:02       ` Len Brown
2013-04-03 12:15 ` [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 17:47   ` Kevin Hilman [this message]
2013-04-03 17:47     ` Kevin Hilman
     [not found]     ` <87zjxfzetw.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 20:49       ` Daniel Lezcano
2013-04-03 20:49         ` Daniel Lezcano
     [not found]         ` <515C95BF.6030103-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 21:43           ` Kevin Hilman
2013-04-03 21:43             ` Kevin Hilman
2013-04-03 12:23 ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-03 12:23   ` Daniel Lezcano
2013-04-08 20:50   ` Rafael J. Wysocki
2013-04-08 20:50     ` Rafael J. Wysocki
2013-04-08 20:53     ` Daniel Lezcano
2013-04-08 20:53       ` Daniel Lezcano
2013-04-18 14:13   ` Russell King - ARM Linux
2013-04-18 14:13     ` Russell King - ARM Linux
2013-04-18 14:31     ` Daniel Lezcano
2013-04-18 14:31       ` Daniel Lezcano
2013-04-18 15:42       ` Russell King - ARM Linux
2013-04-18 15:42         ` Russell King - ARM Linux
     [not found]         ` <20130418154236.GY14496-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-04-18 15:47           ` Daniel Lezcano
2013-04-18 15:47             ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjxfzetw.fsf@linaro.org \
    --to=khilman@linaro.org \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=deepthi@linux.vnet.ibm.com \
    --cc=horms+renesas@verge.net.au \
    --cc=josephl@nvidia.com \
    --cc=lenb@kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.