All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S . Tsirkin" <mst@redhat.com>
Cc: "Sjur Brændeland" <sjurbren@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	"Amit Shah" <amit.shah@redhat.com>,
	"Sjur Brændeland" <sjur.brandeland@stericsson.com>
Subject: Re: [RFCv2 1/2] virtio_console: Add support for DMA memory allocation
Date: Mon, 10 Sep 2012 17:23:52 +0930	[thread overview]
Message-ID: <87zk4ye2jz.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>

sjur.brandeland@stericsson.com writes:

> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>
> Add feature VIRTIO_CONSOLE_F_DMA_MEM. If the architecture has
> DMA support and this feature bit is set, the virtio data buffers
> will be allocated from DMA memory. If the device requests
> the feature VIRTIO_CONSOLE_F_DMA_MEM, but the architecture
> don't support DMA the driver's probe function will fail.
>
> This is needed for using virtio_console from the remoteproc
> framework.

Sorry for the back and forth, I've been pondering MST's points.

If we make a new dma-multiport device (eg. ID 11), how ugly is the code?

It would be a virtio console with DMA buffers and no console, just the
multiport stuff.  This would have no impact on the current spec for
virtio console.

Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: sjur.brandeland@stericsson.com, "Michael S . Tsirkin" <mst@redhat.com>
Cc: "Sjur Brændeland" <sjurbren@gmail.com>,
	"Sjur Brændeland" <sjur.brandeland@stericsson.com>,
	"Amit Shah" <amit.shah@redhat.com>,
	"Ohad Ben-Cohen" <ohad@wizery.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFCv2 1/2] virtio_console: Add support for DMA memory allocation
Date: Mon, 10 Sep 2012 17:23:52 +0930	[thread overview]
Message-ID: <87zk4ye2jz.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1347001066-13521-1-git-send-email-sjur.brandeland@stericsson.com>

sjur.brandeland@stericsson.com writes:

> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>
> Add feature VIRTIO_CONSOLE_F_DMA_MEM. If the architecture has
> DMA support and this feature bit is set, the virtio data buffers
> will be allocated from DMA memory. If the device requests
> the feature VIRTIO_CONSOLE_F_DMA_MEM, but the architecture
> don't support DMA the driver's probe function will fail.
>
> This is needed for using virtio_console from the remoteproc
> framework.

Sorry for the back and forth, I've been pondering MST's points.

If we make a new dma-multiport device (eg. ID 11), how ugly is the code?

It would be a virtio console with DMA buffers and no console, just the
multiport stuff.  This would have no impact on the current spec for
virtio console.

Thanks,
Rusty.

  parent reply	other threads:[~2012-09-10  7:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07  6:57 [RFCv2 1/2] virtio_console: Add support for DMA memory allocation sjur.brandeland
2012-09-07  6:57 ` sjur.brandeland
2012-09-07  6:57 ` [PATCHv2] virtio: Don't access device data after unregistration sjur.brandeland
2012-09-07  6:57   ` sjur.brandeland
2012-09-07  6:57 ` [RFCv2 2/2] virtio_console: Add feature to disable console port sjur.brandeland
2012-09-07  6:57   ` sjur.brandeland
2012-09-10  7:53 ` Rusty Russell [this message]
2012-09-10  7:53   ` [RFCv2 1/2] virtio_console: Add support for DMA memory allocation Rusty Russell
2012-09-10 15:18   ` [RFCv3] virtio_console: Add support for virtio remoteproc serial sjur.brandeland
2012-09-10 15:18     ` sjur.brandeland
2012-09-12  6:00     ` Rusty Russell
2012-09-12  6:00       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk4ye2jz.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=amit.shah@redhat.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sjur.brandeland@stericsson.com \
    --cc=sjurbren@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.