From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] of: add functions to count number of elements in a property
Date: Wed, 05 Feb 2014 13:45:36 +0100 [thread overview]
Message-ID: <8812602.o5pus1vSFK@phil> (raw)
In-Reply-To: <20140205120652.9B1A7C40A89@trevor.secretlab.ca>
Am Mittwoch, 5. Februar 2014, 12:06:52 schrieb Grant Likely:
> On Tue, 04 Feb 2014 19:48:17 +0100, Heiko St??bner <heiko@sntech.de> wrote:
> > Hi Grant,
> >
> > On Tuesday, 4. February 2014 17:30:34 Grant Likely wrote:
> > > On Sat, 18 Jan 2014 09:07:30 -0600, Rob Herring <robherring2@gmail.com>
> >
> > wrote:
> > > > On Sat, Jan 18, 2014 at 6:02 AM, Heiko St????bner <heiko@sntech.de>
wrote:
> > > > > The need to know the number of array elements in a property is
> > > > > a common pattern. To prevent duplication of open-coded
> > > > > implementations
> > > > > add a helper static function that also centralises strict sanity
> > > > > checking and DTB format details, as well as a set of wrapper
> > > > > functions
> > > > > for u8, u16, u32 and u64.
> > > > >
> > > > > Suggested-by: Mark Rutland <mark.rutland@arm.com>
> > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > >
> > > > Looks good. Do you plan to convert some users to use this?
> > >
> > > I'll take that as an acked-by. Merged, thanks.
> >
> > before you taking this patch, I was planning on simply sending this as
> > part of my rockchip-smp series - as I'm currently the only user of it :-)
> > .
> >
> > This going through your tree is most likely the better way, but now I need
> > it to somehow make its way into arm-soc too ... I guess some sort of
> > stable branch arm-soc could pull?
>
> Nah, I'll drop it from my tree. Add my acked-by and merge it via
> arm-soc.
As I said on IRC, now it seems like you can keep this patch in your tree :-)
If we're really going with reserved-memory like you suggested in the rockchip-
smp series it removes the need to count u32-elements in a property for me, as
the reserved blocks move into individual subnodes.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
Subject: Re: [PATCH v4] of: add functions to count number of elements in a property
Date: Wed, 05 Feb 2014 13:45:36 +0100 [thread overview]
Message-ID: <8812602.o5pus1vSFK@phil> (raw)
In-Reply-To: <20140205120652.9B1A7C40A89-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
Am Mittwoch, 5. Februar 2014, 12:06:52 schrieb Grant Likely:
> On Tue, 04 Feb 2014 19:48:17 +0100, Heiko Stübner <heiko@sntech.de> wrote:
> > Hi Grant,
> >
> > On Tuesday, 4. February 2014 17:30:34 Grant Likely wrote:
> > > On Sat, 18 Jan 2014 09:07:30 -0600, Rob Herring <robherring2@gmail.com>
> >
> > wrote:
> > > > On Sat, Jan 18, 2014 at 6:02 AM, Heiko Stübner <heiko@sntech.de>
wrote:
> > > > > The need to know the number of array elements in a property is
> > > > > a common pattern. To prevent duplication of open-coded
> > > > > implementations
> > > > > add a helper static function that also centralises strict sanity
> > > > > checking and DTB format details, as well as a set of wrapper
> > > > > functions
> > > > > for u8, u16, u32 and u64.
> > > > >
> > > > > Suggested-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> > > > > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > > > > ---
> > > >
> > > > Looks good. Do you plan to convert some users to use this?
> > >
> > > I'll take that as an acked-by. Merged, thanks.
> >
> > before you taking this patch, I was planning on simply sending this as
> > part of my rockchip-smp series - as I'm currently the only user of it :-)
> > .
> >
> > This going through your tree is most likely the better way, but now I need
> > it to somehow make its way into arm-soc too ... I guess some sort of
> > stable branch arm-soc could pull?
>
> Nah, I'll drop it from my tree. Add my acked-by and merge it via
> arm-soc.
As I said on IRC, now it seems like you can keep this patch in your tree :-)
If we're really going with reserved-memory like you suggested in the rockchip-
smp series it removes the need to count u32-elements in a property for me, as
the reserved blocks move into individual subnodes.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Grant Likely <grant.likely@linaro.org>
Cc: arm@kernel.org, Rob Herring <robherring2@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>
Subject: Re: [PATCH v4] of: add functions to count number of elements in a property
Date: Wed, 05 Feb 2014 13:45:36 +0100 [thread overview]
Message-ID: <8812602.o5pus1vSFK@phil> (raw)
In-Reply-To: <20140205120652.9B1A7C40A89@trevor.secretlab.ca>
Am Mittwoch, 5. Februar 2014, 12:06:52 schrieb Grant Likely:
> On Tue, 04 Feb 2014 19:48:17 +0100, Heiko Stübner <heiko@sntech.de> wrote:
> > Hi Grant,
> >
> > On Tuesday, 4. February 2014 17:30:34 Grant Likely wrote:
> > > On Sat, 18 Jan 2014 09:07:30 -0600, Rob Herring <robherring2@gmail.com>
> >
> > wrote:
> > > > On Sat, Jan 18, 2014 at 6:02 AM, Heiko Stübner <heiko@sntech.de>
wrote:
> > > > > The need to know the number of array elements in a property is
> > > > > a common pattern. To prevent duplication of open-coded
> > > > > implementations
> > > > > add a helper static function that also centralises strict sanity
> > > > > checking and DTB format details, as well as a set of wrapper
> > > > > functions
> > > > > for u8, u16, u32 and u64.
> > > > >
> > > > > Suggested-by: Mark Rutland <mark.rutland@arm.com>
> > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > >
> > > > Looks good. Do you plan to convert some users to use this?
> > >
> > > I'll take that as an acked-by. Merged, thanks.
> >
> > before you taking this patch, I was planning on simply sending this as
> > part of my rockchip-smp series - as I'm currently the only user of it :-)
> > .
> >
> > This going through your tree is most likely the better way, but now I need
> > it to somehow make its way into arm-soc too ... I guess some sort of
> > stable branch arm-soc could pull?
>
> Nah, I'll drop it from my tree. Add my acked-by and merge it via
> arm-soc.
As I said on IRC, now it seems like you can keep this patch in your tree :-)
If we're really going with reserved-memory like you suggested in the rockchip-
smp series it removes the need to count u32-elements in a property for me, as
the reserved blocks move into individual subnodes.
Heiko
next prev parent reply other threads:[~2014-02-05 12:45 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 21:40 [PATCH v6 0/6] ARM: rockchip: add smp functionality Heiko Stübner
2014-01-15 21:40 ` Heiko Stübner
2014-01-15 21:40 ` Heiko Stübner
2014-01-15 21:40 ` [PATCH v6 1/6] dt-bindings: sram: describe option to reserve parts of the memory Heiko Stübner
2014-01-15 21:40 ` Heiko Stübner
2014-01-16 14:36 ` Rob Herring
2014-01-16 14:36 ` Rob Herring
2014-01-16 14:36 ` Rob Herring
2014-01-15 21:41 ` [PATCH v6 2/6] misc: sram: implement mmio-sram-reserved option Heiko Stübner
2014-01-15 21:41 ` Heiko Stübner
2014-01-16 12:45 ` Mark Rutland
2014-01-16 12:45 ` Mark Rutland
2014-01-16 18:04 ` [PATCH] of: add function to count number of u32 elements in a property Heiko Stübner
2014-01-16 18:04 ` Heiko Stübner
2014-01-17 14:29 ` Rob Herring
2014-01-17 14:29 ` Rob Herring
2014-01-17 14:29 ` Rob Herring
2014-01-17 14:44 ` Mark Rutland
2014-01-17 14:44 ` Mark Rutland
2014-01-17 14:44 ` Mark Rutland
2014-01-17 15:44 ` [PATCH v2] of: add functions to count number of " Heiko Stübner
2014-01-17 15:44 ` Heiko Stübner
2014-01-17 15:44 ` Heiko Stübner
[not found] ` < CAL_JsqJ_St=OegpexzrTGXwmOYCz4YeWk_1S+R_q6NajmmPqSA@mail.gmail.com>
[not found] ` < 5115255.DrcMbtXc1P@phil>
[not found] ` < CAL_JsqJord1OOjwcKk1jqF5o+XO3uw+Lc4ATtQacgwZWAoQq1g@mail.gmail.com>
2014-01-17 16:53 ` Mark Rutland
2014-01-17 16:53 ` Mark Rutland
2014-01-17 16:53 ` Mark Rutland
2014-01-17 17:27 ` [PATCH v3] " Heiko Stübner
2014-01-17 17:27 ` Heiko Stübner
2014-01-17 17:27 ` Heiko Stübner
2014-01-17 17:42 ` [PATCH v2] " Rob Herring
2014-01-17 17:42 ` Rob Herring
2014-01-17 17:42 ` Rob Herring
2014-01-18 12:02 ` [PATCH v4] " Heiko Stübner
2014-01-18 12:02 ` Heiko Stübner
2014-01-18 12:02 ` Heiko Stübner
2014-01-18 15:07 ` Rob Herring
2014-01-18 15:07 ` Rob Herring
2014-01-18 15:07 ` Rob Herring
2014-01-18 15:28 ` Heiko Stübner
2014-01-18 15:28 ` Heiko Stübner
2014-01-18 15:28 ` Heiko Stübner
2014-02-04 17:30 ` Grant Likely
2014-02-04 17:30 ` Grant Likely
2014-02-04 18:48 ` Heiko Stübner
2014-02-04 18:48 ` Heiko Stübner
2014-02-04 18:48 ` Heiko Stübner
2014-02-05 12:06 ` Grant Likely
2014-02-05 12:06 ` Grant Likely
2014-02-05 12:45 ` Heiko Stübner [this message]
2014-02-05 12:45 ` Heiko Stübner
2014-02-05 12:45 ` Heiko Stübner
2014-02-05 13:47 ` Grant Likely
2014-02-05 13:47 ` Grant Likely
2014-01-15 21:42 ` [PATCH v6 3/6] ARM: rockchip: add snoop-control-unit Heiko Stübner
2014-01-15 21:42 ` Heiko Stübner
2014-01-15 21:42 ` [PATCH v6 4/6] ARM: rockchip: add sram dt nodes and documentation Heiko Stübner
2014-01-15 21:42 ` Heiko Stübner
2014-01-15 21:43 ` [PATCH v6 5/6] ARM: rockchip: add power-management-unit Heiko Stübner
2014-01-15 21:43 ` Heiko Stübner
2014-01-15 21:43 ` [PATCH v6 6/6] ARM: rockchip: add smp bringup code Heiko Stübner
2014-01-15 21:43 ` Heiko Stübner
2014-01-15 21:43 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8812602.o5pus1vSFK@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.