From: Arunpravin <arunpravin.paneerselvam@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>
Cc: "Daniel Vetter" <daniel@ffwll.ch>,
"Christian König" <christian.koenig@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
Date: Mon, 7 Mar 2022 20:24:05 +0530 [thread overview]
Message-ID: <883bee2e-bca0-e0d1-613d-d744574ffde8@amd.com> (raw)
In-Reply-To: <20220307125458.GA16710@kili>
Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
On 07/03/22 6:24 pm, Dan Carpenter wrote:
> Set the error code to -ENOMEM if drm_random_order() fails.
>
> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
> index fa997f89522b..6eba590afa9b 100644
> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
> }
>
> order = drm_random_order(mm.max_order + 1, &prng);
> - if (!order)
> + if (!order) {
> + err = -ENOMEM;
> goto out_fini;
> + }
>
> for (i = 0; i <= mm.max_order; ++i) {
> struct drm_buddy_block *block;
>
WARNING: multiple messages have this Message-ID (diff)
From: Arunpravin <arunpravin.paneerselvam@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
Date: Mon, 7 Mar 2022 20:24:05 +0530 [thread overview]
Message-ID: <883bee2e-bca0-e0d1-613d-d744574ffde8@amd.com> (raw)
In-Reply-To: <20220307125458.GA16710@kili>
Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
On 07/03/22 6:24 pm, Dan Carpenter wrote:
> Set the error code to -ENOMEM if drm_random_order() fails.
>
> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
> index fa997f89522b..6eba590afa9b 100644
> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
> }
>
> order = drm_random_order(mm.max_order + 1, &prng);
> - if (!order)
> + if (!order) {
> + err = -ENOMEM;
> goto out_fini;
> + }
>
> for (i = 0; i <= mm.max_order; ++i) {
> struct drm_buddy_block *block;
>
next prev parent reply other threads:[~2022-03-07 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:54 [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke() Dan Carpenter
2022-03-07 12:54 ` Dan Carpenter
2022-03-07 14:54 ` Arunpravin [this message]
2022-03-07 14:54 ` Arunpravin
2022-03-07 16:14 ` Christian König
2022-03-07 16:14 ` Christian König
2022-03-07 16:44 ` Dan Carpenter
2022-03-07 16:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883bee2e-bca0-e0d1-613d-d744574ffde8@amd.com \
--to=arunpravin.paneerselvam@amd.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.