* [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
@ 2022-03-07 12:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-07 12:54 UTC (permalink / raw)
To: David Airlie, Arunpravin
Cc: Daniel Vetter, Christian König, Matthew Auld, dri-devel,
kernel-janitors
Set the error code to -ENOMEM if drm_random_order() fails.
Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
index fa997f89522b..6eba590afa9b 100644
--- a/drivers/gpu/drm/selftests/test-drm_buddy.c
+++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
@@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
}
order = drm_random_order(mm.max_order + 1, &prng);
- if (!order)
+ if (!order) {
+ err = -ENOMEM;
goto out_fini;
+ }
for (i = 0; i <= mm.max_order; ++i) {
struct drm_buddy_block *block;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
@ 2022-03-07 12:54 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-07 12:54 UTC (permalink / raw)
To: David Airlie, Arunpravin
Cc: dri-devel, kernel-janitors, Christian König, Matthew Auld
Set the error code to -ENOMEM if drm_random_order() fails.
Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
index fa997f89522b..6eba590afa9b 100644
--- a/drivers/gpu/drm/selftests/test-drm_buddy.c
+++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
@@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
}
order = drm_random_order(mm.max_order + 1, &prng);
- if (!order)
+ if (!order) {
+ err = -ENOMEM;
goto out_fini;
+ }
for (i = 0; i <= mm.max_order; ++i) {
struct drm_buddy_block *block;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
2022-03-07 12:54 ` Dan Carpenter
@ 2022-03-07 14:54 ` Arunpravin
-1 siblings, 0 replies; 8+ messages in thread
From: Arunpravin @ 2022-03-07 14:54 UTC (permalink / raw)
To: Dan Carpenter, David Airlie
Cc: Daniel Vetter, Christian König, Matthew Auld, dri-devel,
kernel-janitors
Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
On 07/03/22 6:24 pm, Dan Carpenter wrote:
> Set the error code to -ENOMEM if drm_random_order() fails.
>
> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
> index fa997f89522b..6eba590afa9b 100644
> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
> }
>
> order = drm_random_order(mm.max_order + 1, &prng);
> - if (!order)
> + if (!order) {
> + err = -ENOMEM;
> goto out_fini;
> + }
>
> for (i = 0; i <= mm.max_order; ++i) {
> struct drm_buddy_block *block;
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
@ 2022-03-07 14:54 ` Arunpravin
0 siblings, 0 replies; 8+ messages in thread
From: Arunpravin @ 2022-03-07 14:54 UTC (permalink / raw)
To: Dan Carpenter, David Airlie
Cc: dri-devel, kernel-janitors, Christian König, Matthew Auld
Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
On 07/03/22 6:24 pm, Dan Carpenter wrote:
> Set the error code to -ENOMEM if drm_random_order() fails.
>
> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
> index fa997f89522b..6eba590afa9b 100644
> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
> }
>
> order = drm_random_order(mm.max_order + 1, &prng);
> - if (!order)
> + if (!order) {
> + err = -ENOMEM;
> goto out_fini;
> + }
>
> for (i = 0; i <= mm.max_order; ++i) {
> struct drm_buddy_block *block;
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
2022-03-07 14:54 ` Arunpravin
@ 2022-03-07 16:14 ` Christian König
-1 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2022-03-07 16:14 UTC (permalink / raw)
To: Arunpravin, Dan Carpenter, David Airlie
Cc: Daniel Vetter, Matthew Auld, dri-devel, kernel-janitors
Pushed to drm-misc-next. Just one nit below.
Am 07.03.22 um 15:54 schrieb Arunpravin:
> Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
Some people are picky about using the full name here.
And you I think we should volunteer you for maintaining that stuff :)
So you might want to get commit rights for drm-misc-next as well.
Christian.
>
> On 07/03/22 6:24 pm, Dan Carpenter wrote:
>> Set the error code to -ENOMEM if drm_random_order() fails.
>>
>> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> index fa997f89522b..6eba590afa9b 100644
>> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
>> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
>> }
>>
>> order = drm_random_order(mm.max_order + 1, &prng);
>> - if (!order)
>> + if (!order) {
>> + err = -ENOMEM;
>> goto out_fini;
>> + }
>>
>> for (i = 0; i <= mm.max_order; ++i) {
>> struct drm_buddy_block *block;
>>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
@ 2022-03-07 16:14 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2022-03-07 16:14 UTC (permalink / raw)
To: Arunpravin, Dan Carpenter, David Airlie
Cc: dri-devel, kernel-janitors, Matthew Auld
Pushed to drm-misc-next. Just one nit below.
Am 07.03.22 um 15:54 schrieb Arunpravin:
> Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
Some people are picky about using the full name here.
And you I think we should volunteer you for maintaining that stuff :)
So you might want to get commit rights for drm-misc-next as well.
Christian.
>
> On 07/03/22 6:24 pm, Dan Carpenter wrote:
>> Set the error code to -ENOMEM if drm_random_order() fails.
>>
>> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> index fa997f89522b..6eba590afa9b 100644
>> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
>> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
>> }
>>
>> order = drm_random_order(mm.max_order + 1, &prng);
>> - if (!order)
>> + if (!order) {
>> + err = -ENOMEM;
>> goto out_fini;
>> + }
>>
>> for (i = 0; i <= mm.max_order; ++i) {
>> struct drm_buddy_block *block;
>>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
2022-03-07 16:14 ` Christian König
@ 2022-03-07 16:44 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-07 16:44 UTC (permalink / raw)
To: Christian König
Cc: Arunpravin, David Airlie, Daniel Vetter, Matthew Auld, dri-devel,
kernel-janitors
On Mon, Mar 07, 2022 at 05:14:59PM +0100, Christian König wrote:
> Pushed to drm-misc-next. Just one nit below.
>
> Am 07.03.22 um 15:54 schrieb Arunpravin:
> > Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
>
> Some people are picky about using the full name here.
>
Signed-off-by is like signing a legal document to say that you have not
stolen anyone else's copyrighted works (SCO lawsuit). So it should be
whatever name you use to sign legal documents.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
@ 2022-03-07 16:44 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2022-03-07 16:44 UTC (permalink / raw)
To: Christian König
Cc: Arunpravin, David Airlie, kernel-janitors, dri-devel,
Matthew Auld
On Mon, Mar 07, 2022 at 05:14:59PM +0100, Christian König wrote:
> Pushed to drm-misc-next. Just one nit below.
>
> Am 07.03.22 um 15:54 schrieb Arunpravin:
> > Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com>
>
> Some people are picky about using the full name here.
>
Signed-off-by is like signing a legal document to say that you have not
stolen anyone else's copyrighted works (SCO lawsuit). So it should be
whatever name you use to sign legal documents.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-07 16:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07 12:54 [PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke() Dan Carpenter
2022-03-07 12:54 ` Dan Carpenter
2022-03-07 14:54 ` Arunpravin
2022-03-07 14:54 ` Arunpravin
2022-03-07 16:14 ` Christian König
2022-03-07 16:14 ` Christian König
2022-03-07 16:44 ` Dan Carpenter
2022-03-07 16:44 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.