From: Wang, Haiyue <haiyue.wang@linux.intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings
Date: Sat, 27 Jul 2019 01:30:24 +0800 [thread overview]
Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> (raw)
In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au>
? 2019-07-26 13:39, Andrew Jeffery ??:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
>
> Cc: Haiyue Wang<haiyue.wang@linux.intel.com>
> Cc: Corey Minyard<minyard@acm.org>
> Cc: Arnd Bergmann<arnd@arndb.de>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> Cc:openipmi-developer at lists.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew@aj.id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
> 1 file changed, 127 insertions(+), 29 deletions(-)
Looks good, thanks for the hard work, the code is more clean! :)
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Haiyue" <haiyue.wang@linux.intel.com>
To: Andrew Jeffery <andrew@aj.id.au>, linux-aspeed@lists.ozlabs.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Corey Minyard <minyard@acm.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org, joel@jms.id.au,
openipmi-developer@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings
Date: Sat, 27 Jul 2019 01:30:24 +0800 [thread overview]
Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> (raw)
In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au>
在 2019-07-26 13:39, Andrew Jeffery 写道:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
>
> Cc: Haiyue Wang<haiyue.wang@linux.intel.com>
> Cc: Corey Minyard<minyard@acm.org>
> Cc: Arnd Bergmann<arnd@arndb.de>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> Cc:openipmi-developer@lists.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew@aj.id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
> 1 file changed, 127 insertions(+), 29 deletions(-)
Looks good, thanks for the hard work, the code is more clean! :)
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Haiyue" <haiyue.wang@linux.intel.com>
To: Andrew Jeffery <andrew@aj.id.au>, linux-aspeed@lists.ozlabs.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Corey Minyard <minyard@acm.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openipmi-developer@lists.sourceforge.net
Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings
Date: Sat, 27 Jul 2019 01:30:24 +0800 [thread overview]
Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> (raw)
In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au>
在 2019-07-26 13:39, Andrew Jeffery 写道:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
>
> Cc: Haiyue Wang<haiyue.wang@linux.intel.com>
> Cc: Corey Minyard<minyard@acm.org>
> Cc: Arnd Bergmann<arnd@arndb.de>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> Cc:openipmi-developer@lists.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew@aj.id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
> 1 file changed, 127 insertions(+), 29 deletions(-)
Looks good, thanks for the hard work, the code is more clean! :)
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
next prev parent reply other threads:[~2019-07-26 17:30 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 5:39 [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [PATCH 01/17] ARM: dts: aspeed-g5: Move EDAC node to APB Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-29 17:26 ` Stefan Schaeckeler
2019-07-29 17:26 ` Stefan Schaeckeler (sschaeck)
2019-07-29 17:26 ` Stefan Schaeckeler (sschaeck)
2019-07-29 17:26 ` Stefan Schaeckeler (sschaeck)
2019-07-26 5:39 ` [PATCH 02/17] ARM: dts: aspeed-g5: Use recommended generic node name for SDMC Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-29 17:29 ` Stefan Schaeckeler
2019-07-29 17:29 ` Stefan Schaeckeler (sschaeck)
2019-07-29 17:29 ` Stefan Schaeckeler (sschaeck)
2019-07-29 17:29 ` Stefan Schaeckeler (sschaeck)
2019-07-26 5:39 ` [PATCH 03/17] ARM: dts: aspeed-g5: Fix aspeed, external-nodes description Andrew Jeffery
2019-07-26 5:39 ` [PATCH 03/17] ARM: dts: aspeed-g5: Fix aspeed,external-nodes description Andrew Jeffery
2019-07-26 5:39 ` [PATCH 03/17] ARM: dts: aspeed-g5: Fix aspeed, external-nodes description Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [PATCH 04/17] ARM: dts: vesnin: Add unit address for memory node Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 7:56 ` Alexander A. Filippov
2019-07-26 7:56 ` Alexander A. Filippov
2019-07-26 7:56 ` Alexander A. Filippov
2019-07-26 7:56 ` Alexander A. Filippov
2019-07-26 5:39 ` [PATCH 05/17] ARM: dts: fp5280g2: Cleanup gpio-keys-polled properties Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [PATCH 06/17] ARM: dts: swift: " Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 17:53 ` Adriana Kobylak
2019-07-26 17:53 ` Adriana Kobylak
2019-07-26 5:39 ` [PATCH 07/17] ARM: dts: witherspoon: " Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [PATCH 08/17] ARM: dts: aspeed: Cleanup lpc-ctrl and snoop regs Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [PATCH 09/17] ARM: dts: ibm-power9-dual: Add a unit address for OCC nodes Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 10/17] dt-bindings: pinctrl: aspeed: Add reg property as a hint Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 11/17] dt-bindings: misc: Document reg for aspeed, p2a-ctrl nodes Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 11/17] dt-bindings: misc: Document reg for aspeed,p2a-ctrl nodes Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 11/17] dt-bindings: misc: Document reg for aspeed, p2a-ctrl nodes Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 12/17] ARM: dts: aspeed: Add reg hints to syscon children Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 13/17] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 14/17] ipmi: kcs: Finish configuring ASPEED KCS device before enable Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 17:04 ` Wang, Haiyue
2019-07-26 17:04 ` Wang, Haiyue
2019-07-26 17:04 ` Wang, Haiyue
2019-07-26 17:24 ` Wang, Haiyue
2019-07-26 17:24 ` Wang, Haiyue
2019-07-26 17:24 ` Wang, Haiyue
2019-07-26 5:39 ` [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 17:30 ` Wang, Haiyue [this message]
2019-07-26 17:30 ` Wang, Haiyue
2019-07-26 17:30 ` Wang, Haiyue
2019-07-26 5:39 ` [RFC PATCH 16/17] ARM: dts: aspeed-g5: Change KCS nodes to v2 binding Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` [RFC PATCH 17/17] ARM: dts: aspeed-g5: Sort LPC child nodes by unit address Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-26 5:39 ` Andrew Jeffery
2019-07-29 21:55 ` [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings Linus Walleij
2019-07-29 21:55 ` Linus Walleij
2019-07-29 21:55 ` Linus Walleij
2019-07-29 21:55 ` Linus Walleij
2019-07-30 0:49 ` Andrew Jeffery
2019-07-30 0:49 ` Andrew Jeffery
2019-07-30 0:49 ` Andrew Jeffery
2019-07-30 0:49 ` Andrew Jeffery
2019-07-30 0:53 ` Rob Herring
2019-07-30 0:53 ` Rob Herring
2019-07-30 0:53 ` Rob Herring
2019-07-30 0:53 ` Rob Herring
2019-07-30 1:09 ` Andrew Jeffery
2019-07-30 1:09 ` Andrew Jeffery
2019-07-30 1:09 ` Andrew Jeffery
2019-07-30 1:09 ` Andrew Jeffery
2019-08-02 5:51 ` Joel Stanley
2019-08-02 5:51 ` Joel Stanley
2019-08-02 5:51 ` Joel Stanley
2019-08-02 5:51 ` Joel Stanley
2019-08-05 0:48 ` Andrew Jeffery
2019-08-05 0:48 ` Andrew Jeffery
2019-08-05 0:48 ` Andrew Jeffery
2019-08-05 0:48 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com \
--to=haiyue.wang@linux.intel.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.