All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <mwalle@kernel.org>
To: Jaime Liao <jaimeliao.tw@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	tudor.ambarus@linaro.org, pratyush@kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	broonie@kernel.org, leoyu@mxic.com.tw, jaimeliao@mxic.com.tw
Subject: Re: [PATCH v8 9/9] mtd: spi-nor: add support for Macronix Octal flash MX66 series
Date: Thu, 01 Feb 2024 16:52:21 +0100	[thread overview]
Message-ID: <8b80cf233ea0065adf9841408e59f6a2@kernel.org> (raw)
In-Reply-To: <20240201094353.33281-10-jaimeliao.tw@gmail.com>

Hi,

> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -262,6 +262,13 @@ static const struct flash_info 
> macronix_nor_parts[] = {
>  		.id = SNOR_ID(0xc2, 0x80, 0x3a),
>  	}, {
>  		.id = SNOR_ID(0xc2, 0x85, 0x3a),
> +	}, {
> +		.id = SNOR_ID(0xc2, 0x80, 0x3b),
> +	}, {
> +		.id = SNOR_ID(0xc2, 0x85, 0x3b),

These and all of patch 8/9 is not needed because you add the whole
manufacturer in the next line.

> +	}, {
> +		/* Need the manufacturer fixups. Keep this last */
> +		.id = SNOR_ID(0xc2),
>  	}
>  };

Replace patch 8/9 and 9/9 with just the following:

+	/* Need the manufacturer fixups. Keep this last */
+	{ .id = SNOR_ID(0xc2) }


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <mwalle@kernel.org>
To: Jaime Liao <jaimeliao.tw@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
	tudor.ambarus@linaro.org, pratyush@kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	broonie@kernel.org, leoyu@mxic.com.tw, jaimeliao@mxic.com.tw
Subject: Re: [PATCH v8 9/9] mtd: spi-nor: add support for Macronix Octal flash MX66 series
Date: Thu, 01 Feb 2024 16:52:21 +0100	[thread overview]
Message-ID: <8b80cf233ea0065adf9841408e59f6a2@kernel.org> (raw)
In-Reply-To: <20240201094353.33281-10-jaimeliao.tw@gmail.com>

Hi,

> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -262,6 +262,13 @@ static const struct flash_info 
> macronix_nor_parts[] = {
>  		.id = SNOR_ID(0xc2, 0x80, 0x3a),
>  	}, {
>  		.id = SNOR_ID(0xc2, 0x85, 0x3a),
> +	}, {
> +		.id = SNOR_ID(0xc2, 0x80, 0x3b),
> +	}, {
> +		.id = SNOR_ID(0xc2, 0x85, 0x3b),

These and all of patch 8/9 is not needed because you add the whole
manufacturer in the next line.

> +	}, {
> +		/* Need the manufacturer fixups. Keep this last */
> +		.id = SNOR_ID(0xc2),
>  	}
>  };

Replace patch 8/9 and 9/9 with just the following:

+	/* Need the manufacturer fixups. Keep this last */
+	{ .id = SNOR_ID(0xc2) }


  reply	other threads:[~2024-02-01 15:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  9:43 [PATCH v8 0/9] Add octal DTR support for Macronix flash Jaime Liao
2024-02-01  9:43 ` Jaime Liao
2024-02-01  9:43 ` [PATCH v8 1/9] mtd: spi-nor: add Octal " Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01  9:43 ` [PATCH v8 2/9] spi: spi-mem: Allow specifying the byte order in Octal DTR mode Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01 12:04   ` Mark Brown
2024-02-01 12:04     ` Mark Brown
2024-02-01 15:18   ` Michael Walle
2024-02-01 15:18     ` Michael Walle
2024-02-01  9:43 ` [PATCH v8 3/9] mtd: spi-nor: core: " Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01 15:28   ` Michael Walle
2024-02-01 15:28     ` Michael Walle
2024-02-01  9:43 ` [PATCH v8 4/9] mtd: spi-nor: sfdp: Get the 8D-8D-8D byte order from BFPT Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01  9:43 ` [PATCH v8 5/9] spi: mxic: Add support for swapping byte Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01 12:05   ` Mark Brown
2024-02-01 12:05     ` Mark Brown
2024-02-01 15:39   ` Michael Walle
2024-02-01 15:39     ` Michael Walle
2024-02-01  9:43 ` [PATCH v8 6/9] mtd: spi-nor: add support for Macronix Octal flash MX25 series with RWW feature Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01 15:48   ` Michael Walle
2024-02-01 15:48     ` Michael Walle
2024-02-01  9:43 ` [PATCH v8 7/9] mtd: spi-nor: add support for Macronix Octal flash MX66 " Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01  9:43 ` [PATCH v8 8/9] mtd: spi-nor: add support for Macronix Octal flash MX25 series Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01  9:43 ` [PATCH v8 9/9] mtd: spi-nor: add support for Macronix Octal flash MX66 series Jaime Liao
2024-02-01  9:43   ` Jaime Liao
2024-02-01 15:52   ` Michael Walle [this message]
2024-02-01 15:52     ` Michael Walle
2024-02-22  9:32 ` [PATCH v8 0/9] Add octal DTR support for Macronix flash Tudor Ambarus
2024-02-22  9:32   ` Tudor Ambarus
2024-02-22  9:55   ` liao jaime
2024-02-22  9:55     ` liao jaime
2024-02-26  2:02     ` Alvin Zhou
2024-02-26  2:02       ` Alvin Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b80cf233ea0065adf9841408e59f6a2@kernel.org \
    --to=mwalle@kernel.org \
    --cc=broonie@kernel.org \
    --cc=jaimeliao.tw@gmail.com \
    --cc=jaimeliao@mxic.com.tw \
    --cc=leoyu@mxic.com.tw \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.