All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.
@ 2023-12-01 15:44 ` Nirmoy Das
  0 siblings, 0 replies; 15+ messages in thread
From: Nirmoy Das @ 2023-12-01 15:44 UTC (permalink / raw)
  To: intel-gfx; +Cc: Andrzej Hajda, Tvrtko Ursulin, dri-devel, Nirmoy Das

gen8_engine_reset_prepare() can fail when HW fails to set
RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal
error as driver will retry.

Let the caller of gen8_engine_reset_prepare() decide if a
failure in gen8_engine_reset_prepare is an error or not.

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index d5ed904f355d..e6fbc6202c80 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine)
 	ret = __intel_wait_for_register_fw(uncore, reg, mask, ack,
 					   700, 0, NULL);
 	if (ret)
-		gt_err(engine->gt,
-		       "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n",
-		       engine->name, request,
-		       intel_uncore_read_fw(uncore, reg));
+		GT_TRACE(engine->gt,
+			 "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n",
+			 engine->name, request,
+			 intel_uncore_read_fw(uncore, reg));
 
 	return ret;
 }
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-12-05 10:52 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-01 15:44 [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare Nirmoy Das
2023-12-01 15:44 ` Nirmoy Das
2023-12-02  2:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-12-03  5:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-12-04 19:52 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-12-04 19:52   ` Andi Shyti
2023-12-05  1:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork
2023-12-05  6:58 ` [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare Andrzej Hajda
2023-12-05  6:58   ` Andrzej Hajda
2023-12-05  8:34 ` [Intel-gfx] " Tvrtko Ursulin
2023-12-05  8:50   ` Nirmoy Das
2023-12-05 10:05     ` Tvrtko Ursulin
2023-12-05 10:44       ` Nirmoy Das
2023-12-05 10:52         ` Tvrtko Ursulin
2023-12-05  9:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Reduce log severity on reset prepare. (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.