From: David Brown <davidb@codeaurora.org>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Dima Zavin <dima@android.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Kenneth Heitke <kheitke@codeaurora.org>,
Pavel Machek <pavel@ucw.cz>,
tsoni@codeaurora.org, linux-arm-msm@vger.kernel.org,
ARM PORT <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver
Date: Tue, 22 Feb 2011 16:17:20 -0800 [thread overview]
Message-ID: <8ya62sbli3z.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1298419839.17118.5.camel@m0nster> (Daniel Walker's message of "Tue, 22 Feb 2011 16:10:39 -0800")
On Tue, Feb 22 2011, Daniel Walker wrote:
> On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote:
>
>> What is the problem leaving it under arch/arm/mach-msm?
>
> Because it's a driver.
There are a lot of other drivers currently under various arch
subsystems. I'm not sure if a driver that is specific to only one arch
has a strong reason to be elsewhere in the kernel. If there was a
possibility of there being other devices that used SSBI, it might make
sense to put it elsewhere. But, as far as I know, this device is only
found on MSM chips.
It seems kind of unusual to create an entirely new directory under
drivers to hold what will only ever be a single driver.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: add single-wire serial bus interface (SSBI) driver
Date: Tue, 22 Feb 2011 16:17:20 -0800 [thread overview]
Message-ID: <8ya62sbli3z.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1298419839.17118.5.camel@m0nster> (Daniel Walker's message of "Tue, 22 Feb 2011 16:10:39 -0800")
On Tue, Feb 22 2011, Daniel Walker wrote:
> On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote:
>
>> What is the problem leaving it under arch/arm/mach-msm?
>
> Because it's a driver.
There are a lot of other drivers currently under various arch
subsystems. I'm not sure if a driver that is specific to only one arch
has a strong reason to be elsewhere in the kernel. If there was a
possibility of there being other devices that used SSBI, it might make
sense to put it elsewhere. But, as far as I know, this device is only
found on MSM chips.
It seems kind of unusual to create an entirely new directory under
drivers to hold what will only ever be a single driver.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-02-23 0:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 0:34 [PATCH] msm: add single-wire serial bus interface (SSBI) driver Kenneth Heitke
2011-02-18 0:34 ` Kenneth Heitke
2011-02-18 0:34 ` Kenneth Heitke
2011-02-18 0:37 ` Daniel Walker
2011-02-18 0:37 ` Daniel Walker
2011-02-18 0:51 ` Bryan Huntsman
2011-02-18 0:51 ` Bryan Huntsman
2011-02-18 18:46 ` Daniel Walker
2011-02-18 18:46 ` Daniel Walker
2011-02-22 20:47 ` Dima Zavin
2011-02-22 20:47 ` Dima Zavin
2011-02-22 20:47 ` Dima Zavin
2011-02-23 0:10 ` Daniel Walker
2011-02-23 0:10 ` Daniel Walker
2011-02-23 0:17 ` David Brown [this message]
2011-02-23 0:17 ` David Brown
2011-02-23 0:39 ` Daniel Walker
2011-02-23 0:39 ` Daniel Walker
2011-02-23 2:37 ` Nicolas Pitre
2011-02-23 2:37 ` Nicolas Pitre
2011-02-23 3:05 ` David Brown
2011-02-23 3:05 ` David Brown
2011-02-23 3:21 ` Nicolas Pitre
2011-02-23 3:21 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ya62sbli3z.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dima@android.com \
--cc=dwalker@fifo99.com \
--cc=kheitke@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.