From: David Brown <davidb@codeaurora.org>
To: Carl Vanderlip <carlv@codeaurora.org>
Cc: Daniel Walker <dwalker@fifo99.com>,
Russell King <linux@arm.linux.org.uk>,
Bryan Huntsman <bryanh@codeaurora.org>,
Brian Swetland <swetland@google.com>,
Dima Zavin <dima@android.com>,
Rebecca Schultz Zavin <rebecca@android.com>,
Colin Cross <ccross@android.com>,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code.
Date: Wed, 23 Mar 2011 15:47:15 -0700 [thread overview]
Message-ID: <8yay6455ua4.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700")
On Wed, Mar 23 2011, Carl Vanderlip wrote:
> On 03/23/2011 06:11 AM, Daniel Walker wrote:
>> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote:
>>> index df9d74e..d6e75c3 100644
>>> --- a/arch/arm/mach-msm/Kconfig
>>> +++ b/arch/arm/mach-msm/Kconfig
>>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS
>>> config MSM_VIC
>>> bool
>>>
>>> +config MSM_MDP22
>>> + bool
>>> + depends on ARCH_MSM7X00A
>>> + default y
>>> +
>> You should remove the "default y" and this should be moved to a Kconfig
>> under video (shouldn't be added into mach-msm).
>>
>> Daniel
>>
> What about removing the 'depends on' and 'default y' and making it be
> selected by MSM7X00A?
But why should the feature be in the Kconfig for arch/arm/mach-msm when
the driver is under drivers/video/msm? If it does indeed need
configuration, why not put a Kconfig under drivers/video/msm?
The last patch does select this, so it shouldn't need to get a default.
Does the code work if both MDP22 and MDP31 are defined? Eventually, it
will be possible to enable multiple SOCs, so this driver will need to be
able to handle that determination at run-time.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: David Brown <davidb@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code.
Date: Wed, 23 Mar 2011 22:47:15 +0000 [thread overview]
Message-ID: <8yay6455ua4.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700")
On Wed, Mar 23 2011, Carl Vanderlip wrote:
> On 03/23/2011 06:11 AM, Daniel Walker wrote:
>> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote:
>>> index df9d74e..d6e75c3 100644
>>> --- a/arch/arm/mach-msm/Kconfig
>>> +++ b/arch/arm/mach-msm/Kconfig
>>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS
>>> config MSM_VIC
>>> bool
>>>
>>> +config MSM_MDP22
>>> + bool
>>> + depends on ARCH_MSM7X00A
>>> + default y
>>> +
>> You should remove the "default y" and this should be moved to a Kconfig
>> under video (shouldn't be added into mach-msm).
>>
>> Daniel
>>
> What about removing the 'depends on' and 'default y' and making it be
> selected by MSM7X00A?
But why should the feature be in the Kconfig for arch/arm/mach-msm when
the driver is under drivers/video/msm? If it does indeed need
configuration, why not put a Kconfig under drivers/video/msm?
The last patch does select this, so it shouldn't need to get a default.
Does the code work if both MDP22 and MDP31 are defined? Eventually, it
will be possible to enable multiple SOCs, so this driver will need to be
able to handle that determination at run-time.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code.
Date: Wed, 23 Mar 2011 15:47:15 -0700 [thread overview]
Message-ID: <8yay6455ua4.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <4D8A5B44.9050306@codeaurora.org> (Carl Vanderlip's message of "Wed, 23 Mar 2011 13:42:44 -0700")
On Wed, Mar 23 2011, Carl Vanderlip wrote:
> On 03/23/2011 06:11 AM, Daniel Walker wrote:
>> On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote:
>>> index df9d74e..d6e75c3 100644
>>> --- a/arch/arm/mach-msm/Kconfig
>>> +++ b/arch/arm/mach-msm/Kconfig
>>> @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS
>>> config MSM_VIC
>>> bool
>>>
>>> +config MSM_MDP22
>>> + bool
>>> + depends on ARCH_MSM7X00A
>>> + default y
>>> +
>> You should remove the "default y" and this should be moved to a Kconfig
>> under video (shouldn't be added into mach-msm).
>>
>> Daniel
>>
> What about removing the 'depends on' and 'default y' and making it be
> selected by MSM7X00A?
But why should the feature be in the Kconfig for arch/arm/mach-msm when
the driver is under drivers/video/msm? If it does indeed need
configuration, why not put a Kconfig under drivers/video/msm?
The last patch does select this, so it shouldn't need to get a default.
Does the code work if both MDP22 and MDP31 are defined? Eventually, it
will be possible to enable multiple SOCs, so this driver will need to be
able to handle that determination at run-time.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-23 22:46 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 21:47 [PATCH 00/20] video: msm: Adding Support for MDP3.1 Carl Vanderlip
2011-03-18 21:47 ` Carl Vanderlip
2011-03-18 21:47 ` Carl Vanderlip
2011-03-18 21:51 ` [PATCH 01/20] video: msm: Fix typo 'mpd'->'mdp' Carl Vanderlip
2011-03-18 21:51 ` Carl Vanderlip
2011-03-18 21:51 ` Carl Vanderlip
2011-03-21 4:24 ` Janorkar, Mayuresh
2011-03-21 4:36 ` Janorkar, Mayuresh
2011-03-21 4:24 ` Janorkar, Mayuresh
2011-03-22 0:08 ` Carl Vanderlip
2011-03-22 0:08 ` Carl Vanderlip
2011-03-22 0:08 ` Carl Vanderlip
2011-03-18 21:53 ` [PATCH 02/20] video: msm: add spinlock to mdp_info struct Carl Vanderlip
2011-03-18 21:53 ` Carl Vanderlip
2011-03-18 21:53 ` Carl Vanderlip
2011-03-18 21:53 ` [PATCH 03/20] video: msm: add locked_enable_mdp_irq function Carl Vanderlip
2011-03-18 21:53 ` Carl Vanderlip
2011-03-18 21:53 ` Carl Vanderlip
2011-03-18 21:54 ` [PATCH 04/20] video: msm: Move clk to mdp_info struct Carl Vanderlip
2011-03-18 21:54 ` Carl Vanderlip
2011-03-18 21:54 ` Carl Vanderlip
2011-03-18 21:54 ` [PATCH 05/20] video: msm: Setup framework for multiple output interfaces Carl Vanderlip
2011-03-18 21:54 ` Carl Vanderlip
2011-03-18 21:54 ` Carl Vanderlip
2011-03-18 21:55 ` [PATCH 06/20] video: msm: Simplify mdp_blit function Carl Vanderlip
2011-03-18 21:55 ` Carl Vanderlip
2011-03-18 21:55 ` Carl Vanderlip
2011-03-18 21:56 ` [PATCH 07/20] video: msm: Allow users to request a larger x and y virtual fb Carl Vanderlip
2011-03-18 21:56 ` Carl Vanderlip
2011-03-18 21:56 ` Carl Vanderlip
2011-03-21 4:40 ` Janorkar, Mayuresh
2011-03-21 4:52 ` [PATCH 07/20] video: msm: Allow users to request a larger x and Janorkar, Mayuresh
2011-03-21 4:40 ` [PATCH 07/20] video: msm: Allow users to request a larger x and y virtual fb Janorkar, Mayuresh
2011-03-21 16:41 ` Russell King - ARM Linux
2011-03-21 16:41 ` Russell King - ARM Linux
2011-03-21 16:41 ` [PATCH 07/20] video: msm: Allow users to request a larger x Russell King - ARM Linux
2011-03-22 0:21 ` [PATCH 07/20] video: msm: Allow users to request a larger x and y virtual fb Carl Vanderlip
2011-03-22 0:21 ` Carl Vanderlip
2011-03-22 0:21 ` Carl Vanderlip
2011-03-22 0:21 ` [PATCH 07/20] video: msm: Allow users to request a larger x Carl Vanderlip
2011-03-18 21:56 ` [PATCH 08/20] video: msm: Refactor mdp_regs Carl Vanderlip
2011-03-18 21:56 ` Carl Vanderlip
2011-03-18 21:56 ` Carl Vanderlip
2011-03-21 5:17 ` Janorkar, Mayuresh
2011-03-21 5:29 ` Janorkar, Mayuresh
2011-03-21 5:17 ` Janorkar, Mayuresh
2011-03-21 17:23 ` Bryan Huntsman
2011-03-21 17:23 ` Bryan Huntsman
2011-03-21 17:23 ` Bryan Huntsman
2011-03-21 17:28 ` Brian Swetland
2011-03-21 17:28 ` Brian Swetland
2011-03-21 17:28 ` Brian Swetland
2011-03-18 21:57 ` [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-20 9:22 ` Russell King - ARM Linux
2011-03-20 9:22 ` Russell King - ARM Linux
2011-03-20 9:22 ` Russell King - ARM Linux
2011-03-22 0:26 ` Carl Vanderlip
2011-03-22 0:26 ` Carl Vanderlip
2011-03-22 0:26 ` Carl Vanderlip
2011-03-21 5:15 ` Janorkar, Mayuresh
2011-03-21 5:27 ` Janorkar, Mayuresh
2011-03-21 5:15 ` Janorkar, Mayuresh
2011-03-23 13:11 ` Daniel Walker
2011-03-23 13:11 ` Daniel Walker
2011-03-23 13:11 ` Daniel Walker
2011-03-23 19:18 ` Dima Zavin
2011-03-23 19:18 ` Dima Zavin
2011-03-23 19:18 ` Dima Zavin
2011-03-23 20:42 ` Carl Vanderlip
2011-03-23 20:42 ` Carl Vanderlip
2011-03-23 22:47 ` David Brown [this message]
2011-03-23 22:47 ` David Brown
2011-03-23 22:47 ` David Brown
2011-03-18 21:57 ` [PATCH 10/20] video: msm: Separate more MDP " Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-18 21:57 ` [PATCH 11/20] video: msm: Add MDP FB DMA configuration Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-18 21:57 ` Carl Vanderlip
2011-03-21 5:18 ` Janorkar, Mayuresh
2011-03-21 5:30 ` Janorkar, Mayuresh
2011-03-21 5:18 ` Janorkar, Mayuresh
2011-03-18 21:58 ` [PATCH 12/20] video: msm: Add IRQ callback for MDP interface Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-18 21:58 ` [PATCH 13/20] video: msm: Debugging for send_blit Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-21 5:20 ` Janorkar, Mayuresh
2011-03-21 5:32 ` Janorkar, Mayuresh
2011-03-21 5:20 ` Janorkar, Mayuresh
2011-03-18 21:58 ` [PATCH 14/20] video: msm: Write IRQ mask to MDP registers Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-18 21:58 ` Carl Vanderlip
2011-03-18 21:59 ` [PATCH 15/20] video: msm: convert printk to pr_* Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-21 5:22 ` Janorkar, Mayuresh
2011-03-21 5:34 ` Janorkar, Mayuresh
2011-03-21 5:22 ` Janorkar, Mayuresh
2011-03-21 13:33 ` Sergei Shtylyov
2011-03-21 13:33 ` Sergei Shtylyov
2011-03-21 13:33 ` Sergei Shtylyov
2011-03-18 21:59 ` [PATCH 16/20] video: msm: Set the EBI1 clock to 128MHz when performing blits Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-20 1:31 ` zt.tmzt
2011-03-20 1:31 ` zt.tmzt at gmail.com
2011-03-21 20:31 ` Stephen Boyd
2011-03-21 20:31 ` Stephen Boyd
2011-03-21 20:31 ` [PATCH 16/20] video: msm: Set the EBI1 clock to 128MHz when performing Stephen Boyd
2011-03-18 21:59 ` [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-21 13:39 ` Sergei Shtylyov
2011-03-21 13:39 ` Sergei Shtylyov
2011-03-21 13:39 ` Sergei Shtylyov
2011-03-21 23:49 ` Carl Vanderlip
2011-03-21 23:49 ` Carl Vanderlip
2011-03-21 23:49 ` Carl Vanderlip
2011-03-21 23:49 ` [PATCH 17/20] video: msm: Prevent framebuffer glitch Carl Vanderlip
2011-03-18 21:59 ` [PATCH 18/20] video: msm: Prevent DMA lockups when switching bit depths Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-21 13:42 ` Sergei Shtylyov
2011-03-21 13:42 ` Sergei Shtylyov
2011-03-21 13:42 ` [PATCH 18/20] video: msm: Prevent DMA lockups when switching Sergei Shtylyov
2011-03-18 21:59 ` [PATCH 19/20] video: msm: Separate calculation of base and offset Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 21:59 ` Carl Vanderlip
2011-03-18 22:00 ` [PATCH 20/20] video: msm: Add support for MDP 3.1 (qsd8k) Carl Vanderlip
2011-03-18 22:00 ` Carl Vanderlip
2011-03-18 22:00 ` Carl Vanderlip
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yay6455ua4.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=carlv@codeaurora.org \
--cc=ccross@android.com \
--cc=dima@android.com \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rebecca@android.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.