All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Zhilkin <csharper2005@gmail.com>
To: David Lechner <dlechner@baylibre.com>, u-boot@lists.u-boot-project.org
Cc: jerome.forissier@arm.com, ryder.lee@mediatek.com,
	weijie.gao@mediatek.com, chunfeng.yun@mediatek.com,
	igor.belwon@mentallysanemainliners.org, jstephan@baylibre.com,
	GSS_MTK_Uboot_upstream@mediatek.com, trini@konsulko.com
Subject: Re: [PATCH v1 1/3] net: mtk_eth: an8855: fix bitwise collision in RX_CTRL_8 register
Date: Sat, 14 Nov 2026 11:57:13 +0300	[thread overview]
Message-ID: <90639ee7-eabf-406f-ae36-fa33289d9682@gmail.com> (raw)
In-Reply-To: <7a142599-6c0c-4656-b23a-bf339f40c4b1@baylibre.com>

Hi David,

On 11/10/26 00:23, David Lechner wrote:
>> +++ b/drivers/net/mtk_eth/an8855.c
>> @@ -627,8 +627,8 @@ static int an8855_port_sgmii_init(struct an8855_switch_priv *priv, u32 port)
>>  	an8855_reg_read(priv, AN8855_RX_CTRL_8, &val);
>>  	val &= ~(0xfff << 16);
>>  	val |= (0x200 << 16);
>> -	val &= ~(0x7fff << 14);
>> -	val |= (0xfff << 14);
>> +	val &= ~(0x7fff << 0);
>> +	val |= (0xfff << 0);
> 
> nit: we could drop the << 0 and ().

Good catch, that definitely looks cleaner. I will drop the `<< 0` and
the parentheses in v2.

Thanks!
Mikhail


  reply	other threads:[~2026-11-14  8:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 14:24 [PATCH v1 0/3] net: mtk_eth: an8855: fix packet loss and sync with Linux Mikhail Zhilkin
2026-11-07 14:24 ` [PATCH v1 1/3] net: mtk_eth: an8855: fix bitwise collision in RX_CTRL_8 register Mikhail Zhilkin
2026-11-09 21:23   ` David Lechner
2026-11-14  8:57     ` Mikhail Zhilkin [this message]
2026-11-07 14:24 ` [PATCH v1 2/3] net: mtk_eth: an8855: enable link error recovery Mikhail Zhilkin
2026-11-09 21:23   ` David Lechner
2026-11-14  8:58     ` Mikhail Zhilkin
2026-11-07 14:24 ` [PATCH v1 3/3] net: mtk_eth: an8855: sync SerDes analog tuning with Linux driver Mikhail Zhilkin
2026-11-09 21:25   ` David Lechner
2026-11-14  9:03     ` Mikhail Zhilkin
2026-11-09 21:23 ` [PATCH v1 0/3] net: mtk_eth: an8855: fix packet loss and sync with Linux David Lechner
2026-11-14  8:54   ` Mikhail Zhilkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90639ee7-eabf-406f-ae36-fa33289d9682@gmail.com \
    --to=csharper2005@gmail.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=dlechner@baylibre.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=jerome.forissier@arm.com \
    --cc=jstephan@baylibre.com \
    --cc=ryder.lee@mediatek.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.