All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
	Marek Vasut <marex@denx.de>, Fabio Estevam <festevam@denx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel <kernel@dh-electronics.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box
Date: Thu, 6 Apr 2023 21:52:41 +0000	[thread overview]
Message-ID: <9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com> (raw)
In-Reply-To: <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org>

From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
Sent: Thursday, April 6, 2023 10:38 PM
> On 06/04/2023 21:57, Christoph Niedermaier wrote:
>>>>>> +     aliases {
>>>>>> +             /delete-property/ mmc0; /* Avoid double definitions */
>>>>>
>>>>> I don't understand it. What is "double definition" of aliases?
>>>>
>>>> Otherwise I end up like this:
>>>> mmc0 = &usdhc1;
>>>> mmc1 = &usdhc2;
>>>> mmc2 = &usdhc2;
>>>>
>>>> Is "Ensure unique allocation" a better comment here?
>>>>
>>>>>
>>>>>> +             /delete-property/ mmc1;
>>>>>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
>>>>>
>>>>> Why? How is this labeled on the board (physically or on schematics)? If
>>>>> you answer here "for booting", then the answer is NAK. Don't add
>>>>> software policies to Devicetree.
>>>>
>>>> The name in the schematics is "SD2".
>>>
>>> Answering also to above - then likely the aliases should be dropped from
>>> SoM. I doubt that Som calls it SD1 and your board SD2...
>>
>> Maybe I don't quite get it, but the hardware starts counting at 1. The first
>> interface is SD1 and it is used as WiFi. The second one is SD2 which is the
>> eMMC. So with this aliases it should match SD2 to mmc2.
>> Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi"
> 
> Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right?

Yes. I will do this in version 3.


Thanks and best regards
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
	Marek Vasut <marex@denx.de>, Fabio Estevam <festevam@denx.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel <kernel@dh-electronics.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box
Date: Thu, 6 Apr 2023 21:52:41 +0000	[thread overview]
Message-ID: <9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com> (raw)
In-Reply-To: <8353399f-c6de-8da7-78f1-d6a558c462d0@kernel.org>

From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
Sent: Thursday, April 6, 2023 10:38 PM
> On 06/04/2023 21:57, Christoph Niedermaier wrote:
>>>>>> +     aliases {
>>>>>> +             /delete-property/ mmc0; /* Avoid double definitions */
>>>>>
>>>>> I don't understand it. What is "double definition" of aliases?
>>>>
>>>> Otherwise I end up like this:
>>>> mmc0 = &usdhc1;
>>>> mmc1 = &usdhc2;
>>>> mmc2 = &usdhc2;
>>>>
>>>> Is "Ensure unique allocation" a better comment here?
>>>>
>>>>>
>>>>>> +             /delete-property/ mmc1;
>>>>>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
>>>>>
>>>>> Why? How is this labeled on the board (physically or on schematics)? If
>>>>> you answer here "for booting", then the answer is NAK. Don't add
>>>>> software policies to Devicetree.
>>>>
>>>> The name in the schematics is "SD2".
>>>
>>> Answering also to above - then likely the aliases should be dropped from
>>> SoM. I doubt that Som calls it SD1 and your board SD2...
>>
>> Maybe I don't quite get it, but the hardware starts counting at 1. The first
>> interface is SD1 and it is used as WiFi. The second one is SD2 which is the
>> eMMC. So with this aliases it should match SD2 to mmc2.
>> Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi"
> 
> Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right?

Yes. I will do this in version 3.


Thanks and best regards
Christoph

  reply	other threads:[~2023-04-06 21:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 15:48 [PATCH V2 1/3] dt-bindings: Add Marantec vendor prefix Christoph Niedermaier
2023-04-06 15:48 ` Christoph Niedermaier
2023-04-06 15:48 ` [PATCH V2 2/3] dt-bindings: arm: fsl: Add Marantec maveo box as a DHCOR i.MX6ULL SoM based board Christoph Niedermaier
2023-04-06 15:48   ` Christoph Niedermaier
2023-04-06 16:38   ` Krzysztof Kozlowski
2023-04-06 16:38     ` Krzysztof Kozlowski
2023-04-06 15:49 ` [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Christoph Niedermaier
2023-04-06 15:49   ` Christoph Niedermaier
2023-04-06 16:39   ` Krzysztof Kozlowski
2023-04-06 16:39     ` Krzysztof Kozlowski
2023-04-06 17:54     ` Christoph Niedermaier
2023-04-06 17:54       ` Christoph Niedermaier
2023-04-06 18:00       ` Krzysztof Kozlowski
2023-04-06 18:00         ` Krzysztof Kozlowski
2023-04-06 19:57         ` Christoph Niedermaier
2023-04-06 19:57           ` Christoph Niedermaier
2023-04-06 20:38           ` Krzysztof Kozlowski
2023-04-06 20:38             ` Krzysztof Kozlowski
2023-04-06 21:52             ` Christoph Niedermaier [this message]
2023-04-06 21:52               ` Christoph Niedermaier
2023-04-06 16:38 ` [PATCH V2 1/3] dt-bindings: Add Marantec vendor prefix Krzysztof Kozlowski
2023-04-06 16:38   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=kernel@dh-electronics.com \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.