From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Raj, Ashok" <ashok.raj@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>
Subject: Re: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately
Date: Fri, 1 Jul 2022 17:12:25 +0800 [thread overview]
Message-ID: <94c67e49-4604-e296-fa1a-e1105d67c5fd@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52763F336B2535BC89E2C7498CBD9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/7/1 16:15, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Wednesday, June 29, 2022 3:47 PM
>>
>> + spin_lock_irqsave(&device_domain_lock, flags);
>> list_for_each_entry(info, &domain->devices, link) {
>> - if (!info->dev)
>> - continue;
>> -
>
> suppose you can replace all spin_lock_irqsave() with spin_lock()
> in patch5 instead of leaving some replacement to next patch.
>
Make sense. I will update the series.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Cc: baolu.lu@linux.intel.com, "Raj, Ashok" <ashok.raj@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately
Date: Fri, 1 Jul 2022 17:12:25 +0800 [thread overview]
Message-ID: <94c67e49-4604-e296-fa1a-e1105d67c5fd@linux.intel.com> (raw)
Message-ID: <20220701091225.IpMbkfYb5dUmrfHwMOGkr5UeCb5fEpSYPzw7VqRPAEM@z> (raw)
In-Reply-To: <BN9PR11MB52763F336B2535BC89E2C7498CBD9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/7/1 16:15, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Wednesday, June 29, 2022 3:47 PM
>>
>> + spin_lock_irqsave(&device_domain_lock, flags);
>> list_for_each_entry(info, &domain->devices, link) {
>> - if (!info->dev)
>> - continue;
>> -
>
> suppose you can replace all spin_lock_irqsave() with spin_lock()
> in patch5 instead of leaving some replacement to next patch.
>
Make sense. I will update the series.
Best regards,
baolu
next prev parent reply other threads:[~2022-07-01 9:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 7:47 [PATCH v3 00/11] iommu/vt-d: Optimize the use of locks Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 01/11] iommu/vt-d: debugfs: Remove device_domain_lock usage Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 7:55 ` Tian, Kevin
2022-07-01 7:55 ` Tian, Kevin
2022-06-29 7:47 ` [PATCH v3 02/11] iommu/vt-d: Remove clearing translation data in disable_dmar_iommu() Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 7:58 ` Tian, Kevin
2022-07-01 7:58 ` Tian, Kevin
2022-07-03 4:34 ` Baolu Lu
2022-07-03 4:34 ` Baolu Lu
2022-07-07 1:02 ` Tian, Kevin
2022-06-29 7:47 ` [PATCH v3 03/11] iommu/vt-d: Use pci_get_domain_bus_and_slot() in pgtable_walk() Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 04/11] iommu/vt-d: Unnecessary spinlock for root table alloc and free Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 05/11] iommu/vt-d: Replace spin_lock_irqsave() with spin_lock() Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 06/11] iommu/vt-d: Acquiring lock in domain ID allocation helpers Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 8:06 ` Tian, Kevin
2022-07-01 8:06 ` Tian, Kevin
2022-06-29 7:47 ` [PATCH v3 07/11] iommu/vt-d: Acquiring lock in pasid manipulation helpers Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 08/11] iommu/vt-d: Check device list of domain in domain free path Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-06-29 7:47 ` [PATCH v3 09/11] iommu/vt-d: Fold __dmar_remove_one_dev_info() into its caller Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 8:08 ` Tian, Kevin
2022-07-01 8:08 ` Tian, Kevin
2022-06-29 7:47 ` [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 8:15 ` Tian, Kevin
2022-07-01 8:15 ` Tian, Kevin
2022-07-01 9:12 ` Baolu Lu [this message]
2022-07-01 9:12 ` Baolu Lu
2022-07-03 4:35 ` Baolu Lu
2022-07-03 4:35 ` Baolu Lu
2022-06-29 7:47 ` [PATCH v3 11/11] iommu/vt-d: Convert global spinlock into per domain lock Lu Baolu
2022-06-29 7:47 ` Lu Baolu
2022-07-01 8:18 ` Tian, Kevin
2022-07-01 8:18 ` Tian, Kevin
2022-07-01 7:53 ` [PATCH v3 00/11] iommu/vt-d: Optimize the use of locks Tian, Kevin
2022-07-01 7:53 ` Tian, Kevin
2022-07-01 8:12 ` Baolu Lu
2022-07-01 8:12 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c67e49-4604-e296-fa1a-e1105d67c5fd@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.