* [PATCH v2 0/2] add clock-names property to nand node
@ 2025-02-12 9:54 ` niravkumar.l.rabara
0 siblings, 0 replies; 10+ messages in thread
From: niravkumar.l.rabara @ 2025-02-12 9:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Niravkumar L Rabara, nirav.rabara, devicetree, linux-mtd,
linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
1) Document the required clock-names property because the driver
requests the clock by name and not the index.
2) Add required clock-names property to the nand node in device tree.
Changes in v2:
* Document clock-names property for Cadence NAND controller.
link to v1:
- https://lore.kernel.org/all/20250107084955.2750154-1-niravkumar.l.rabara@intel.com/
Niravkumar L Rabara (2):
dt-bindings: mtd: cadence: document required clock-names
arm64: dts: socfpga: agilex5: add clock-names property to nand node
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 1 +
2 files changed, 8 insertions(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names
2025-02-12 9:54 ` niravkumar.l.rabara
@ 2025-02-12 9:54 ` niravkumar.l.rabara
-1 siblings, 0 replies; 10+ messages in thread
From: niravkumar.l.rabara @ 2025-02-12 9:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Niravkumar L Rabara, nirav.rabara, devicetree, linux-mtd,
linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
The clock-names property is required because the driver requests
the clock by name and not the index.
Update the example to use &clk instead of &nf_clk for the clocks
property to avoid confusion with the clock-names property "nf_clk".
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
index 0bed37a994c3..e1f4d7c35a88 100644
--- a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
+++ b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
@@ -33,6 +33,10 @@ properties:
clocks:
maxItems: 1
+ clock-names:
+ items:
+ - const: nf_clk
+
dmas:
maxItems: 1
@@ -51,6 +55,7 @@ required:
- reg-names
- interrupts
- clocks
+ - clock-names
unevaluatedProperties: false
@@ -66,7 +71,8 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&nf_clk>;
+ clocks = <&clk>;
+ clock-names = "nf_clk";
cdns,board-delay-ps = <4830>;
nand@0 {
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names
@ 2025-02-12 9:54 ` niravkumar.l.rabara
0 siblings, 0 replies; 10+ messages in thread
From: niravkumar.l.rabara @ 2025-02-12 9:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Niravkumar L Rabara, nirav.rabara, devicetree, linux-mtd,
linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
The clock-names property is required because the driver requests
the clock by name and not the index.
Update the example to use &clk instead of &nf_clk for the clocks
property to avoid confusion with the clock-names property "nf_clk".
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
index 0bed37a994c3..e1f4d7c35a88 100644
--- a/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
+++ b/Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml
@@ -33,6 +33,10 @@ properties:
clocks:
maxItems: 1
+ clock-names:
+ items:
+ - const: nf_clk
+
dmas:
maxItems: 1
@@ -51,6 +55,7 @@ required:
- reg-names
- interrupts
- clocks
+ - clock-names
unevaluatedProperties: false
@@ -66,7 +71,8 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&nf_clk>;
+ clocks = <&clk>;
+ clock-names = "nf_clk";
cdns,board-delay-ps = <4830>;
nand@0 {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names
2025-02-12 9:54 ` niravkumar.l.rabara
@ 2025-02-12 10:52 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-12 10:52 UTC (permalink / raw)
To: niravkumar.l.rabara, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: nirav.rabara, devicetree, linux-mtd, linux-kernel
On 12/02/2025 10:54, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> The clock-names property is required because the driver requests
> the clock by name and not the index.
> Update the example to use &clk instead of &nf_clk for the clocks
> property to avoid confusion with the clock-names property "nf_clk".
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
> Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Please add fixes tag - probably the conversion, because original TXT
binding mentioned "nf_clk" so it could be implied.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names
@ 2025-02-12 10:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-12 10:52 UTC (permalink / raw)
To: niravkumar.l.rabara, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: nirav.rabara, devicetree, linux-mtd, linux-kernel
On 12/02/2025 10:54, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> The clock-names property is required because the driver requests
> the clock by name and not the index.
> Update the example to use &clk instead of &nf_clk for the clocks
> property to avoid confusion with the clock-names property "nf_clk".
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
> Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Please add fixes tag - probably the conversion, because original TXT
binding mentioned "nf_clk" so it could be implied.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] arm64: dts: socfpga: agilex5: add clock-names property to nand node
2025-02-12 9:54 ` niravkumar.l.rabara
@ 2025-02-12 9:54 ` niravkumar.l.rabara
-1 siblings, 0 replies; 10+ messages in thread
From: niravkumar.l.rabara @ 2025-02-12 9:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Niravkumar L Rabara, nirav.rabara, devicetree, linux-mtd,
linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Add required clock-names property to the nand node.
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index 51c6e19e40b8..27f75e1bc8eb 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -271,6 +271,7 @@ nand: nand-controller@10b80000 {
#size-cells = <0>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clkmgr AGILEX5_NAND_NF_CLK>;
+ clock-names = "nf_clk";
cdns,board-delay-ps = <4830>;
status = "disabled";
};
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 2/2] arm64: dts: socfpga: agilex5: add clock-names property to nand node
@ 2025-02-12 9:54 ` niravkumar.l.rabara
0 siblings, 0 replies; 10+ messages in thread
From: niravkumar.l.rabara @ 2025-02-12 9:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Niravkumar L Rabara, nirav.rabara, devicetree, linux-mtd,
linux-kernel
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Add required clock-names property to the nand node.
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index 51c6e19e40b8..27f75e1bc8eb 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -271,6 +271,7 @@ nand: nand-controller@10b80000 {
#size-cells = <0>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clkmgr AGILEX5_NAND_NF_CLK>;
+ clock-names = "nf_clk";
cdns,board-delay-ps = <4830>;
status = "disabled";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: socfpga: agilex5: add clock-names property to nand node
2025-02-12 9:54 ` niravkumar.l.rabara
@ 2025-02-12 10:52 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-12 10:52 UTC (permalink / raw)
To: niravkumar.l.rabara, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: nirav.rabara, devicetree, linux-mtd, linux-kernel
On 12/02/2025 10:54, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Add required clock-names property to the nand node.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Fixes tag please.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: socfpga: agilex5: add clock-names property to nand node
@ 2025-02-12 10:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-12 10:52 UTC (permalink / raw)
To: niravkumar.l.rabara, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: nirav.rabara, devicetree, linux-mtd, linux-kernel
On 12/02/2025 10:54, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Add required clock-names property to the nand node.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Fixes tag please.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread