From: Like Xu <like.xu.linux@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Like Xu <likexu@tencent.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 6/7] perf: x86/core: Add interface to query perfmon_event_map[] directly
Date: Thu, 18 Nov 2021 16:06:26 +0800 [thread overview]
Message-ID: <97ea49ce-2ec2-3b35-6aac-d30998b837fe@gmail.com> (raw)
In-Reply-To: <202111180758.nFyJUMVf-lkp@intel.com>
On 18/11/2021 7:21 am, kernel test robot wrote:
> Hi Like,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on kvm/queue]
> [also build test ERROR on tip/perf/core mst-vhost/linux-next linus/master v5.16-rc1 next-20211117]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
...
> vim +500 arch/x86/include/asm/perf_event.h
>
> 492
> 493 #if defined(CONFIG_PERF_EVENTS) && defined(CONFIG_CPU_SUP_INTEL)
> 494 extern struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
> 495 extern u64 perf_get_hw_event_config(int perf_hw_id);
> 496 extern int x86_perf_get_lbr(struct x86_pmu_lbr *lbr);
> 497 #else
> 498 struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
> 499 u64 perf_get_hw_event_config(int perf_hw_id);
Thanks to the robot, I should have removed the ";" from this line.
Awaiting further review comments.
> > 500 {
> 501 return 0;
> 502 }
> 503 static inline int x86_perf_get_lbr(struct x86_pmu_lbr *lbr)
> 504 {
> 505 return -1;
> 506 }
> 507 #endif
> 508
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
WARNING: multiple messages have this Message-ID (diff)
From: Like Xu <like.xu.linux@gmail.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/7] perf: x86/core: Add interface to query perfmon_event_map[] directly
Date: Thu, 18 Nov 2021 16:06:26 +0800 [thread overview]
Message-ID: <97ea49ce-2ec2-3b35-6aac-d30998b837fe@gmail.com> (raw)
In-Reply-To: <202111180758.nFyJUMVf-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On 18/11/2021 7:21 am, kernel test robot wrote:
> Hi Like,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on kvm/queue]
> [also build test ERROR on tip/perf/core mst-vhost/linux-next linus/master v5.16-rc1 next-20211117]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
...
> vim +500 arch/x86/include/asm/perf_event.h
>
> 492
> 493 #if defined(CONFIG_PERF_EVENTS) && defined(CONFIG_CPU_SUP_INTEL)
> 494 extern struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
> 495 extern u64 perf_get_hw_event_config(int perf_hw_id);
> 496 extern int x86_perf_get_lbr(struct x86_pmu_lbr *lbr);
> 497 #else
> 498 struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr);
> 499 u64 perf_get_hw_event_config(int perf_hw_id);
Thanks to the robot, I should have removed the ";" from this line.
Awaiting further review comments.
> > 500 {
> 501 return 0;
> 502 }
> 503 static inline int x86_perf_get_lbr(struct x86_pmu_lbr *lbr)
> 504 {
> 505 return -1;
> 506 }
> 507 #endif
> 508
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>
next prev parent reply other threads:[~2021-11-18 8:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 9:51 [PATCH 0/7] KVM: x86/pmu: Four functional fixes Like Xu
2021-11-12 9:51 ` [PATCH 1/7] KVM: x86/pmu: Make top-down.slots event unavailable in supported leaf Like Xu
2021-11-12 9:51 ` [PATCH 2/7] KVM: x86/pmu: Fix available_event_types check for REF_CPU_CYCLES event Like Xu
2021-11-12 9:51 ` [PATCH 3/7] KVM: x86/pmu: Pass "struct kvm_pmu *" to the find_fixed_event() Like Xu
2021-11-12 9:51 ` [PATCH 4/7] KVM: x86/pmu: Avoid perf_event creation for invalid counter config Like Xu
2021-11-12 9:51 ` [PATCH 5/7] KVM: x86/pmu: Refactor pmu->available_event_types field using BITMAP Like Xu
2021-11-12 9:51 ` [PATCH 6/7] perf: x86/core: Add interface to query perfmon_event_map[] directly Like Xu
2021-11-17 23:21 ` kernel test robot
2021-11-17 23:21 ` kernel test robot
2021-11-18 8:06 ` Like Xu [this message]
2021-11-18 8:06 ` Like Xu
2021-11-18 13:36 ` Like Xu
2021-11-18 13:36 ` Like Xu
2021-11-12 9:51 ` [PATCH 7/7] KVM: x86/pmu: Setup the {inte|amd}_event_mapping[] when hardware_setup Like Xu
2021-11-25 13:18 ` [KVM] 54244a5dd7: BUG:KASAN:stack-out-of-bounds_in_find_first_bit kernel test robot
2021-11-25 13:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ea49ce-2ec2-3b35-6aac-d30998b837fe@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.