From: Dragan Simic <dsimic@manjaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook
Date: Sun, 28 Jul 2024 11:22:48 +0200 [thread overview]
Message-ID: <99e5b9275d6c7750e916e83b9191e965@manjaro.org> (raw)
In-Reply-To: <20240728082004.36575-2-andyshrk@163.com>
Hello Andy,
On 2024-07-28 10:20, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect
> with CM5.
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
>
> ---
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..a9bfb87e69f5 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,genbook
This should also follow the "dependency graph" naming approach, so it
should be named "coolpi,pi-cm5-genbook" instead. It would also make
the naming scheme future-proof for some other SoM that could possibly
be made available for the GenBook in the future, for which the new
identifier would be "coolpi,pi-XYZ-genbook".
Though, the "pi-" part in "coolpi,pi-cm5-genbook" seems redundant to
me, but it's already present in all related Cool Pi identifiers, e.g.
"coolpi,pi-cm5-evb", so including the leading "pi-" here as well is
obviously required for consistency.
Oh, and I somehow managed to miss this in my earlier repose, which
would have saved you from sending another version of this series.
I'm sorry for that.
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> +
> - description: Cool Pi 4 Model B
> items:
> - const: coolpi,pi-4b
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Dragan Simic <dsimic@manjaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook
Date: Sun, 28 Jul 2024 11:22:48 +0200 [thread overview]
Message-ID: <99e5b9275d6c7750e916e83b9191e965@manjaro.org> (raw)
In-Reply-To: <20240728082004.36575-2-andyshrk@163.com>
Hello Andy,
On 2024-07-28 10:20, Andy Yan wrote:
> Add Cool Pi CM5 GenBook, a laptop powered by RK3588.
>
> Cool Pi GenBook works with a carrier board connect
> with CM5.
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
>
> ---
>
> Changes in v2:
> - Descripte it as Cool Pi CM5 GenBook
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..a9bfb87e69f5 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi CM5 GenBook
> + items:
> + - enum:
> + - coolpi,genbook
This should also follow the "dependency graph" naming approach, so it
should be named "coolpi,pi-cm5-genbook" instead. It would also make
the naming scheme future-proof for some other SoM that could possibly
be made available for the GenBook in the future, for which the new
identifier would be "coolpi,pi-XYZ-genbook".
Though, the "pi-" part in "coolpi,pi-cm5-genbook" seems redundant to
me, but it's already present in all related Cool Pi identifiers, e.g.
"coolpi,pi-cm5-evb", so including the leading "pi-" here as well is
obviously required for consistency.
Oh, and I somehow managed to miss this in my earlier repose, which
would have saved you from sending another version of this series.
I'm sorry for that.
> + - const: coolpi,pi-cm5
> + - const: rockchip,rk3588
> +
> +
> - description: Cool Pi 4 Model B
> items:
> - const: coolpi,pi-4b
next prev parent reply other threads:[~2024-07-28 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 8:20 [PATCH v2 0/2] Add support for Cool Pi GenBook Andy Yan
2024-07-28 8:20 ` Andy Yan
2024-07-28 8:20 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Cool Pi CM5 GenBook Andy Yan
2024-07-28 8:20 ` Andy Yan
2024-07-28 9:15 ` Krzysztof Kozlowski
2024-07-28 9:15 ` Krzysztof Kozlowski
2024-07-28 9:22 ` Dragan Simic [this message]
2024-07-28 9:22 ` Dragan Simic
2024-07-28 8:20 ` [PATCH v2 2/2] arm64: dts: rockchip: Add support for rk3588 based " Andy Yan
2024-07-28 8:20 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e5b9275d6c7750e916e83b9191e965@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.