All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
@ 2025-09-12  9:55 Jai Luthra
  2025-09-12 10:17 ` Hans Verkuil
  0 siblings, 1 reply; 9+ messages in thread
From: Jai Luthra @ 2025-09-12  9:55 UTC (permalink / raw)
  To: linux-media, Hans Verkuil, Mauro Carvalho Chehab
  Cc: Maxime Ripard, Laurent Pinchart, Tomi Valkeinen, Devarsh Thakkar

Hi Hans, Mauro,

The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:

  media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)

are available in the Git repository at:

  https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed

for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:

  media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)

----------------------------------------------------------------
TI and Cadence CSI2RX driver changes:

- Multistream support for Cadence and TI CSI2RX
- Runtime PM support for Cadence and TI CSI2RX
- System suspend and resume support for TI CSI2RX
- Misc cleanups

----------------------------------------------------------------
Changhuang Liang (1):
      media: cadence: csi2rx: Support runtime PM

Jai Luthra (9):
      dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
      media: ti: j721e-csi2rx: separate out device and context
      media: ti: j721e-csi2rx: add a subdev for the core device
      media: ti: j721e-csi2rx: add support for processing virtual channels
      media: cadence: csi2rx: add multistream support
      media: ti: j721e-csi2rx: add multistream support
      media: ti: j721e-csi2rx: Submit all available buffers
      media: ti: j721e-csi2rx: Support runtime suspend
      media: ti: j721e-csi2rx: Support system suspend using pm_notifier

Pratyush Yadav (4):
      media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
      media: ti: j721e-csi2rx: allocate DMA channel based on context index
      media: ti: j721e-csi2rx: get number of contexts from device tree
      media: cadence: csi2rx: add get_frame_desc wrapper

Rishikesh Donadkar (2):
      media: ti: j721e-csi2rx: Remove word size alignment on frame width
      media: ti: j721e-csi2rx: Change the drain architecture for multistream

 Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
 drivers/media/platform/cadence/Kconfig                            |    1 +
 drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
 drivers/media/platform/ti/Kconfig                                 |    1 +
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
 5 files changed, 1300 insertions(+), 399 deletions(-)

--
Thanks,

Jai

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-12  9:55 [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes Jai Luthra
@ 2025-09-12 10:17 ` Hans Verkuil
  2025-09-12 11:21   ` Jai Luthra
  2025-09-15  7:17   ` Laurent Pinchart
  0 siblings, 2 replies; 9+ messages in thread
From: Hans Verkuil @ 2025-09-12 10:17 UTC (permalink / raw)
  To: Jai Luthra, linux-media, Mauro Carvalho Chehab
  Cc: Maxime Ripard, Laurent Pinchart, Tomi Valkeinen, Devarsh Thakkar

Hi Jai,

On 12/09/2025 11:55, Jai Luthra wrote:
> Hi Hans, Mauro,
> 
> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
> 
>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
> 
> are available in the Git repository at:
> 
>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
> 
> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
> 
>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
> 
> ----------------------------------------------------------------
> TI and Cadence CSI2RX driver changes:
> 
> - Multistream support for Cadence and TI CSI2RX
> - Runtime PM support for Cadence and TI CSI2RX
> - System suspend and resume support for TI CSI2RX
> - Misc cleanups

This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
related. Several patches do not even have a Reviewed-by from Sakari or Laurent.

I can't take this, I'm afraid.

I'm not sure why we get a PR from you, was there some misunderstanding?

Regards,

	Hans

> 
> ----------------------------------------------------------------
> Changhuang Liang (1):
>       media: cadence: csi2rx: Support runtime PM
> 
> Jai Luthra (9):
>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
>       media: ti: j721e-csi2rx: separate out device and context
>       media: ti: j721e-csi2rx: add a subdev for the core device
>       media: ti: j721e-csi2rx: add support for processing virtual channels
>       media: cadence: csi2rx: add multistream support
>       media: ti: j721e-csi2rx: add multistream support
>       media: ti: j721e-csi2rx: Submit all available buffers
>       media: ti: j721e-csi2rx: Support runtime suspend
>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
> 
> Pratyush Yadav (4):
>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
>       media: ti: j721e-csi2rx: get number of contexts from device tree
>       media: cadence: csi2rx: add get_frame_desc wrapper
> 
> Rishikesh Donadkar (2):
>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
> 
>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
>  drivers/media/platform/cadence/Kconfig                            |    1 +
>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>  drivers/media/platform/ti/Kconfig                                 |    1 +
>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
>  5 files changed, 1300 insertions(+), 399 deletions(-)
> 
> --
> Thanks,
> 
> Jai
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-12 10:17 ` Hans Verkuil
@ 2025-09-12 11:21   ` Jai Luthra
  2025-09-15  8:24     ` Hans Verkuil
  2025-09-15  7:17   ` Laurent Pinchart
  1 sibling, 1 reply; 9+ messages in thread
From: Jai Luthra @ 2025-09-12 11:21 UTC (permalink / raw)
  To: Hans Verkuil
  Cc: linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Laurent Pinchart, Tomi Valkeinen, Devarsh Thakkar

[-- Attachment #1: Type: text/plain, Size: 4136 bytes --]

Hi Hans,

On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
> Hi Jai,
> 
> On 12/09/2025 11:55, Jai Luthra wrote:
> > Hi Hans, Mauro,
> > 
> > The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
> > 
> >   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
> > 
> > are available in the Git repository at:
> > 
> >   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
> > 
> > for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
> > 
> >   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
> > 
> > ----------------------------------------------------------------
> > TI and Cadence CSI2RX driver changes:
> > 
> > - Multistream support for Cadence and TI CSI2RX
> > - Runtime PM support for Cadence and TI CSI2RX
> > - System suspend and resume support for TI CSI2RX
> > - Misc cleanups
> 
> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
> 
> I can't take this, I'm afraid.
> 
> I'm not sure why we get a PR from you, was there some misunderstanding?
> 

Apologies. I had a look at other "GIT PULL" messages on linux-media and 
inferred that any driver maintainer can send a pull request for media tree.

I looked at 
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
that was not very informative.

But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
this is about streams support).

Could the process and who-owns-what sub-subsystem be better documented in 
docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
model, but until that is finalized even the current process is hard to 
understand for a newbie :-)

> Regards,
> 
> 	Hans
> 

Thanks,
Jai

> > 
> > ----------------------------------------------------------------
> > Changhuang Liang (1):
> >       media: cadence: csi2rx: Support runtime PM
> > 
> > Jai Luthra (9):
> >       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
> >       media: ti: j721e-csi2rx: separate out device and context
> >       media: ti: j721e-csi2rx: add a subdev for the core device
> >       media: ti: j721e-csi2rx: add support for processing virtual channels
> >       media: cadence: csi2rx: add multistream support
> >       media: ti: j721e-csi2rx: add multistream support
> >       media: ti: j721e-csi2rx: Submit all available buffers
> >       media: ti: j721e-csi2rx: Support runtime suspend
> >       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
> > 
> > Pratyush Yadav (4):
> >       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
> >       media: ti: j721e-csi2rx: allocate DMA channel based on context index
> >       media: ti: j721e-csi2rx: get number of contexts from device tree
> >       media: cadence: csi2rx: add get_frame_desc wrapper
> > 
> > Rishikesh Donadkar (2):
> >       media: ti: j721e-csi2rx: Remove word size alignment on frame width
> >       media: ti: j721e-csi2rx: Change the drain architecture for multistream
> > 
> >  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
> >  drivers/media/platform/cadence/Kconfig                            |    1 +
> >  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
> >  drivers/media/platform/ti/Kconfig                                 |    1 +
> >  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
> >  5 files changed, 1300 insertions(+), 399 deletions(-)
> > 
> > --
> > Thanks,
> > 
> > Jai
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-12 10:17 ` Hans Verkuil
  2025-09-12 11:21   ` Jai Luthra
@ 2025-09-15  7:17   ` Laurent Pinchart
  1 sibling, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2025-09-15  7:17 UTC (permalink / raw)
  To: Hans Verkuil
  Cc: Jai Luthra, linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Tomi Valkeinen, Devarsh Thakkar

On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
> On 12/09/2025 11:55, Jai Luthra wrote:
> > Hi Hans, Mauro,
> > 
> > The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
> > 
> >   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
> > 
> > are available in the Git repository at:
> > 
> >   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
> > 
> > for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
> > 
> >   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
> > 
> > ----------------------------------------------------------------
> > TI and Cadence CSI2RX driver changes:
> > 
> > - Multistream support for Cadence and TI CSI2RX
> > - Runtime PM support for Cadence and TI CSI2RX
> > - System suspend and resume support for TI CSI2RX
> > - Misc cleanups
> 
> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.

I've asked Tomi if he can review the patches as I won't have time in the
near future. If he's happy with the patches for this driver, that's good
enough for me :-)

> I can't take this, I'm afraid.
> 
> I'm not sure why we get a PR from you, was there some misunderstanding?
> 
> Regards,
> 
> 	Hans
> > ----------------------------------------------------------------
> > Changhuang Liang (1):
> >       media: cadence: csi2rx: Support runtime PM
> > 
> > Jai Luthra (9):
> >       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
> >       media: ti: j721e-csi2rx: separate out device and context
> >       media: ti: j721e-csi2rx: add a subdev for the core device
> >       media: ti: j721e-csi2rx: add support for processing virtual channels
> >       media: cadence: csi2rx: add multistream support
> >       media: ti: j721e-csi2rx: add multistream support
> >       media: ti: j721e-csi2rx: Submit all available buffers
> >       media: ti: j721e-csi2rx: Support runtime suspend
> >       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
> > 
> > Pratyush Yadav (4):
> >       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
> >       media: ti: j721e-csi2rx: allocate DMA channel based on context index
> >       media: ti: j721e-csi2rx: get number of contexts from device tree
> >       media: cadence: csi2rx: add get_frame_desc wrapper
> > 
> > Rishikesh Donadkar (2):
> >       media: ti: j721e-csi2rx: Remove word size alignment on frame width
> >       media: ti: j721e-csi2rx: Change the drain architecture for multistream
> > 
> >  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
> >  drivers/media/platform/cadence/Kconfig                            |    1 +
> >  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
> >  drivers/media/platform/ti/Kconfig                                 |    1 +
> >  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
> >  5 files changed, 1300 insertions(+), 399 deletions(-)

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-12 11:21   ` Jai Luthra
@ 2025-09-15  8:24     ` Hans Verkuil
  2025-09-15  8:44       ` Laurent Pinchart
  0 siblings, 1 reply; 9+ messages in thread
From: Hans Verkuil @ 2025-09-15  8:24 UTC (permalink / raw)
  To: Jai Luthra
  Cc: linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Laurent Pinchart, Tomi Valkeinen, Devarsh Thakkar

On 12/09/2025 13:21, Jai Luthra wrote:
> Hi Hans,
> 
> On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
>> Hi Jai,
>>
>> On 12/09/2025 11:55, Jai Luthra wrote:
>>> Hi Hans, Mauro,
>>>
>>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
>>>
>>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
>>>
>>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
>>>
>>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
>>>
>>> ----------------------------------------------------------------
>>> TI and Cadence CSI2RX driver changes:
>>>
>>> - Multistream support for Cadence and TI CSI2RX
>>> - Runtime PM support for Cadence and TI CSI2RX
>>> - System suspend and resume support for TI CSI2RX
>>> - Misc cleanups
>>
>> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
>> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
>>
>> I can't take this, I'm afraid.
>>
>> I'm not sure why we get a PR from you, was there some misunderstanding?
>>
> 
> Apologies. I had a look at other "GIT PULL" messages on linux-media and 
> inferred that any driver maintainer can send a pull request for media tree.

Ah, no. It's media maintainers that do that. For small subsystems you would post
patches and the subsystem maintainer will (when ready) merge them and send a PR
to Linus.

For large subsystems like media you have multiple media maintainers, each responsible
for a part of the subsystem. They will review and prep a PR for the media maintainers
(me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.

Hopefully once we get the multi-committer up and running (pending doc changes) we can
do away with most of the PRs.

> 
> I looked at 
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
> that was not very informative.
> 
> But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
> this is about streams support).
> 
> Could the process and who-owns-what sub-subsystem be better documented in 
> docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
> model, but until that is finalized even the current process is hard to 
> understand for a newbie :-)

It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
codecs and Bryan O'Donoghue for Qualcomm drivers.

https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers

In any case, your PR came in too late. After rc6 is released we only merge fixes as a
general rule. It's good to keep that in mind for the next kernel cycle.

If your PR contains fixes that you believe are important for v6.18, then discuss that
with Sakari and he can post a PR with those fixes.

Regards,

	Hans

> 
>> Regards,
>>
>> 	Hans
>>
> 
> Thanks,
> Jai
> 
>>>
>>> ----------------------------------------------------------------
>>> Changhuang Liang (1):
>>>       media: cadence: csi2rx: Support runtime PM
>>>
>>> Jai Luthra (9):
>>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
>>>       media: ti: j721e-csi2rx: separate out device and context
>>>       media: ti: j721e-csi2rx: add a subdev for the core device
>>>       media: ti: j721e-csi2rx: add support for processing virtual channels
>>>       media: cadence: csi2rx: add multistream support
>>>       media: ti: j721e-csi2rx: add multistream support
>>>       media: ti: j721e-csi2rx: Submit all available buffers
>>>       media: ti: j721e-csi2rx: Support runtime suspend
>>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
>>>
>>> Pratyush Yadav (4):
>>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
>>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
>>>       media: ti: j721e-csi2rx: get number of contexts from device tree
>>>       media: cadence: csi2rx: add get_frame_desc wrapper
>>>
>>> Rishikesh Donadkar (2):
>>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
>>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
>>>
>>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
>>>  drivers/media/platform/cadence/Kconfig                            |    1 +
>>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>>>  drivers/media/platform/ti/Kconfig                                 |    1 +
>>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
>>>  5 files changed, 1300 insertions(+), 399 deletions(-)
>>>
>>> --
>>> Thanks,
>>>
>>> Jai
>>>
>>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-15  8:24     ` Hans Verkuil
@ 2025-09-15  8:44       ` Laurent Pinchart
  2025-09-15  9:20         ` Hans Verkuil
  0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2025-09-15  8:44 UTC (permalink / raw)
  To: Hans Verkuil
  Cc: Jai Luthra, linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Tomi Valkeinen, Devarsh Thakkar

On Mon, Sep 15, 2025 at 10:24:34AM +0200, Hans Verkuil wrote:
> On 12/09/2025 13:21, Jai Luthra wrote:
> > On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
> >> On 12/09/2025 11:55, Jai Luthra wrote:
> >>> Hi Hans, Mauro,
> >>>
> >>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
> >>>
> >>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
> >>>
> >>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
> >>>
> >>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
> >>>
> >>> ----------------------------------------------------------------
> >>> TI and Cadence CSI2RX driver changes:
> >>>
> >>> - Multistream support for Cadence and TI CSI2RX
> >>> - Runtime PM support for Cadence and TI CSI2RX
> >>> - System suspend and resume support for TI CSI2RX
> >>> - Misc cleanups
> >>
> >> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
> >> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
> >>
> >> I can't take this, I'm afraid.
> >>
> >> I'm not sure why we get a PR from you, was there some misunderstanding?
> > 
> > Apologies. I had a look at other "GIT PULL" messages on linux-media and 
> > inferred that any driver maintainer can send a pull request for media tree.
> 
> Ah, no. It's media maintainers that do that. For small subsystems you would post
> patches and the subsystem maintainer will (when ready) merge them and send a PR
> to Linus.
> 
> For large subsystems like media you have multiple media maintainers, each responsible
> for a part of the subsystem. They will review and prep a PR for the media maintainers
> (me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.
> 
> Hopefully once we get the multi-committer up and running (pending doc changes) we can
> do away with most of the PRs.

Is there an objection against pull requests from driver maintainers ?
Assuming all the other rules and requirements are met (passing CI,
having the expected R-b tags, ...), is there a reason why I would need
to collect a series posted by Jai and then send a pull request, instead
of having Jai send the pull request directly ?

> > I looked at 
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
> > that was not very informative.
> > 
> > But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
> > this is about streams support).
> > 
> > Could the process and who-owns-what sub-subsystem be better documented in 
> > docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
> > model, but until that is finalized even the current process is hard to 
> > understand for a newbie :-)
> 
> It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
> codecs and Bryan O'Donoghue for Qualcomm drivers.
> 
> https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers
> 
> In any case, your PR came in too late. After rc6 is released we only merge fixes as a
> general rule. It's good to keep that in mind for the next kernel cycle.
> 
> If your PR contains fixes that you believe are important for v6.18, then discuss that
> with Sakari and he can post a PR with those fixes.
> 
> >>> ----------------------------------------------------------------
> >>> Changhuang Liang (1):
> >>>       media: cadence: csi2rx: Support runtime PM
> >>>
> >>> Jai Luthra (9):
> >>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
> >>>       media: ti: j721e-csi2rx: separate out device and context
> >>>       media: ti: j721e-csi2rx: add a subdev for the core device
> >>>       media: ti: j721e-csi2rx: add support for processing virtual channels
> >>>       media: cadence: csi2rx: add multistream support
> >>>       media: ti: j721e-csi2rx: add multistream support
> >>>       media: ti: j721e-csi2rx: Submit all available buffers
> >>>       media: ti: j721e-csi2rx: Support runtime suspend
> >>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
> >>>
> >>> Pratyush Yadav (4):
> >>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
> >>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
> >>>       media: ti: j721e-csi2rx: get number of contexts from device tree
> >>>       media: cadence: csi2rx: add get_frame_desc wrapper
> >>>
> >>> Rishikesh Donadkar (2):
> >>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
> >>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
> >>>
> >>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
> >>>  drivers/media/platform/cadence/Kconfig                            |    1 +
> >>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
> >>>  drivers/media/platform/ti/Kconfig                                 |    1 +
> >>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
> >>>  5 files changed, 1300 insertions(+), 399 deletions(-)

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-15  8:44       ` Laurent Pinchart
@ 2025-09-15  9:20         ` Hans Verkuil
  2025-09-15  9:52           ` Laurent Pinchart
  0 siblings, 1 reply; 9+ messages in thread
From: Hans Verkuil @ 2025-09-15  9:20 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Jai Luthra, linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Tomi Valkeinen, Devarsh Thakkar

On 15/09/2025 10:44, Laurent Pinchart wrote:
> On Mon, Sep 15, 2025 at 10:24:34AM +0200, Hans Verkuil wrote:
>> On 12/09/2025 13:21, Jai Luthra wrote:
>>> On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
>>>> On 12/09/2025 11:55, Jai Luthra wrote:
>>>>> Hi Hans, Mauro,
>>>>>
>>>>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
>>>>>
>>>>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
>>>>>
>>>>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
>>>>>
>>>>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> TI and Cadence CSI2RX driver changes:
>>>>>
>>>>> - Multistream support for Cadence and TI CSI2RX
>>>>> - Runtime PM support for Cadence and TI CSI2RX
>>>>> - System suspend and resume support for TI CSI2RX
>>>>> - Misc cleanups
>>>>
>>>> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
>>>> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
>>>>
>>>> I can't take this, I'm afraid.
>>>>
>>>> I'm not sure why we get a PR from you, was there some misunderstanding?
>>>
>>> Apologies. I had a look at other "GIT PULL" messages on linux-media and 
>>> inferred that any driver maintainer can send a pull request for media tree.
>>
>> Ah, no. It's media maintainers that do that. For small subsystems you would post
>> patches and the subsystem maintainer will (when ready) merge them and send a PR
>> to Linus.
>>
>> For large subsystems like media you have multiple media maintainers, each responsible
>> for a part of the subsystem. They will review and prep a PR for the media maintainers
>> (me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.
>>
>> Hopefully once we get the multi-committer up and running (pending doc changes) we can
>> do away with most of the PRs.
> 
> Is there an objection against pull requests from driver maintainers ?
> Assuming all the other rules and requirements are met (passing CI,
> having the expected R-b tags, ...), is there a reason why I would need
> to collect a series posted by Jai and then send a pull request, instead
> of having Jai send the pull request directly ?

If I get a PR from you, then I know that you, with your expertise, judged the
patches in the PR to be ready to be merged. Since it's from you I also can
trust that all the right tags are in place, that all the right people have
been pulled in if that was needed, etc.

If the PR would be from a driver maintainer, then I don't have that additional
level of trust and I will have to pay closer attention to the patches in the PR,
checking tags, checking that nothing was forgotten, etc. Precisely what happened
in this case where tags were missing.

As a general rule we don't accept PRs from non-media maintainers. It's something
we can discuss, though.

BTW, when I talk about 'trust', it's about trusting the PR author to know all the
procedures, and having the expertise to know when something is ready to be merged.
It's not about malicious code or anything like that.

So a driver maintainer will certainly know the driver code, and is expected to review
patches for that driver. But it takes time to gain the expertise to become a
media maintainer.

I hope this helps.

Regards,

	Hans

> 
>>> I looked at 
>>> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
>>> that was not very informative.
>>>
>>> But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
>>> this is about streams support).
>>>
>>> Could the process and who-owns-what sub-subsystem be better documented in 
>>> docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
>>> model, but until that is finalized even the current process is hard to 
>>> understand for a newbie :-)
>>
>> It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
>> codecs and Bryan O'Donoghue for Qualcomm drivers.
>>
>> https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers
>>
>> In any case, your PR came in too late. After rc6 is released we only merge fixes as a
>> general rule. It's good to keep that in mind for the next kernel cycle.
>>
>> If your PR contains fixes that you believe are important for v6.18, then discuss that
>> with Sakari and he can post a PR with those fixes.
>>
>>>>> ----------------------------------------------------------------
>>>>> Changhuang Liang (1):
>>>>>       media: cadence: csi2rx: Support runtime PM
>>>>>
>>>>> Jai Luthra (9):
>>>>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
>>>>>       media: ti: j721e-csi2rx: separate out device and context
>>>>>       media: ti: j721e-csi2rx: add a subdev for the core device
>>>>>       media: ti: j721e-csi2rx: add support for processing virtual channels
>>>>>       media: cadence: csi2rx: add multistream support
>>>>>       media: ti: j721e-csi2rx: add multistream support
>>>>>       media: ti: j721e-csi2rx: Submit all available buffers
>>>>>       media: ti: j721e-csi2rx: Support runtime suspend
>>>>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
>>>>>
>>>>> Pratyush Yadav (4):
>>>>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
>>>>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
>>>>>       media: ti: j721e-csi2rx: get number of contexts from device tree
>>>>>       media: cadence: csi2rx: add get_frame_desc wrapper
>>>>>
>>>>> Rishikesh Donadkar (2):
>>>>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
>>>>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
>>>>>
>>>>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
>>>>>  drivers/media/platform/cadence/Kconfig                            |    1 +
>>>>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>>>>>  drivers/media/platform/ti/Kconfig                                 |    1 +
>>>>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
>>>>>  5 files changed, 1300 insertions(+), 399 deletions(-)
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-15  9:20         ` Hans Verkuil
@ 2025-09-15  9:52           ` Laurent Pinchart
  2025-09-15 10:09             ` Hans Verkuil
  0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2025-09-15  9:52 UTC (permalink / raw)
  To: Hans Verkuil
  Cc: Jai Luthra, linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Tomi Valkeinen, Devarsh Thakkar

On Mon, Sep 15, 2025 at 11:20:12AM +0200, Hans Verkuil wrote:
> On 15/09/2025 10:44, Laurent Pinchart wrote:
> > On Mon, Sep 15, 2025 at 10:24:34AM +0200, Hans Verkuil wrote:
> >> On 12/09/2025 13:21, Jai Luthra wrote:
> >>> On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
> >>>> On 12/09/2025 11:55, Jai Luthra wrote:
> >>>>> Hi Hans, Mauro,
> >>>>>
> >>>>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
> >>>>>
> >>>>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
> >>>>>
> >>>>> are available in the Git repository at:
> >>>>>
> >>>>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
> >>>>>
> >>>>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
> >>>>>
> >>>>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
> >>>>>
> >>>>> ----------------------------------------------------------------
> >>>>> TI and Cadence CSI2RX driver changes:
> >>>>>
> >>>>> - Multistream support for Cadence and TI CSI2RX
> >>>>> - Runtime PM support for Cadence and TI CSI2RX
> >>>>> - System suspend and resume support for TI CSI2RX
> >>>>> - Misc cleanups
> >>>>
> >>>> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
> >>>> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
> >>>>
> >>>> I can't take this, I'm afraid.
> >>>>
> >>>> I'm not sure why we get a PR from you, was there some misunderstanding?
> >>>
> >>> Apologies. I had a look at other "GIT PULL" messages on linux-media and 
> >>> inferred that any driver maintainer can send a pull request for media tree.
> >>
> >> Ah, no. It's media maintainers that do that. For small subsystems you would post
> >> patches and the subsystem maintainer will (when ready) merge them and send a PR
> >> to Linus.
> >>
> >> For large subsystems like media you have multiple media maintainers, each responsible
> >> for a part of the subsystem. They will review and prep a PR for the media maintainers
> >> (me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.
> >>
> >> Hopefully once we get the multi-committer up and running (pending doc changes) we can
> >> do away with most of the PRs.
> > 
> > Is there an objection against pull requests from driver maintainers ?
> > Assuming all the other rules and requirements are met (passing CI,
> > having the expected R-b tags, ...), is there a reason why I would need
> > to collect a series posted by Jai and then send a pull request, instead
> > of having Jai send the pull request directly ?
> 
> If I get a PR from you, then I know that you, with your expertise, judged the
> patches in the PR to be ready to be merged. Since it's from you I also can
> trust that all the right tags are in place, that all the right people have
> been pulled in if that was needed, etc.
> 
> If the PR would be from a driver maintainer, then I don't have that additional
> level of trust and I will have to pay closer attention to the patches in the PR,
> checking tags, checking that nothing was forgotten, etc. Precisely what happened
> in this case where tags were missing.
> 
> As a general rule we don't accept PRs from non-media maintainers. It's something
> we can discuss, though.
> 
> BTW, when I talk about 'trust', it's about trusting the PR author to know all the
> procedures, and having the expertise to know when something is ready to be merged.
> It's not about malicious code or anything like that.

Understood. The risk of honest mistakes is at the moment much higher
than the risk of malicious activity, given the complexity of the
process. Whether that's good or bad news is debatable :-)

> So a driver maintainer will certainly know the driver code, and is expected to review
> patches for that driver. But it takes time to gain the expertise to become a
> media maintainer.
> 
> I hope this helps.

Thank you for sharing you reasoning, it helps.

I would like to experiment with allowing pull requests from more
contributors, but I don't want to increase your workload by forcing you
to review those way more carefully. If that's OK with everybody, I
propose, for the next version of the patches (once they get reviewed by
the appropriate person) that Jai would send me pull request, following
all our rules. I will check that everything is fine, and will then
"forward" the pull request by sending you a pull request for the same
commit ID, but from my tree and with a tag that carries my GPG
signature. This will have no impact on your workflow, will allow me to
delegate work to Jai, and will allow him to learn the subsystem rules.

> >>> I looked at 
> >>> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
> >>> that was not very informative.
> >>>
> >>> But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
> >>> this is about streams support).
> >>>
> >>> Could the process and who-owns-what sub-subsystem be better documented in 
> >>> docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
> >>> model, but until that is finalized even the current process is hard to 
> >>> understand for a newbie :-)
> >>
> >> It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
> >> codecs and Bryan O'Donoghue for Qualcomm drivers.
> >>
> >> https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers
> >>
> >> In any case, your PR came in too late. After rc6 is released we only merge fixes as a
> >> general rule. It's good to keep that in mind for the next kernel cycle.
> >>
> >> If your PR contains fixes that you believe are important for v6.18, then discuss that
> >> with Sakari and he can post a PR with those fixes.
> >>
> >>>>> ----------------------------------------------------------------
> >>>>> Changhuang Liang (1):
> >>>>>       media: cadence: csi2rx: Support runtime PM
> >>>>>
> >>>>> Jai Luthra (9):
> >>>>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
> >>>>>       media: ti: j721e-csi2rx: separate out device and context
> >>>>>       media: ti: j721e-csi2rx: add a subdev for the core device
> >>>>>       media: ti: j721e-csi2rx: add support for processing virtual channels
> >>>>>       media: cadence: csi2rx: add multistream support
> >>>>>       media: ti: j721e-csi2rx: add multistream support
> >>>>>       media: ti: j721e-csi2rx: Submit all available buffers
> >>>>>       media: ti: j721e-csi2rx: Support runtime suspend
> >>>>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
> >>>>>
> >>>>> Pratyush Yadav (4):
> >>>>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
> >>>>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
> >>>>>       media: ti: j721e-csi2rx: get number of contexts from device tree
> >>>>>       media: cadence: csi2rx: add get_frame_desc wrapper
> >>>>>
> >>>>> Rishikesh Donadkar (2):
> >>>>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
> >>>>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
> >>>>>
> >>>>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
> >>>>>  drivers/media/platform/cadence/Kconfig                            |    1 +
> >>>>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
> >>>>>  drivers/media/platform/ti/Kconfig                                 |    1 +
> >>>>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
> >>>>>  5 files changed, 1300 insertions(+), 399 deletions(-)

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes
  2025-09-15  9:52           ` Laurent Pinchart
@ 2025-09-15 10:09             ` Hans Verkuil
  0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2025-09-15 10:09 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Jai Luthra, linux-media, Mauro Carvalho Chehab, Maxime Ripard,
	Tomi Valkeinen, Devarsh Thakkar

On 15/09/2025 11:52, Laurent Pinchart wrote:
> On Mon, Sep 15, 2025 at 11:20:12AM +0200, Hans Verkuil wrote:
>> On 15/09/2025 10:44, Laurent Pinchart wrote:
>>> On Mon, Sep 15, 2025 at 10:24:34AM +0200, Hans Verkuil wrote:
>>>> On 12/09/2025 13:21, Jai Luthra wrote:
>>>>> On Fri, Sep 12, 2025 at 12:17:17PM +0200, Hans Verkuil wrote:
>>>>>> On 12/09/2025 11:55, Jai Luthra wrote:
>>>>>>> Hi Hans, Mauro,
>>>>>>>
>>>>>>> The following changes since commit ecba852dc9f4993f4f894ea1f352564560e19a3e:
>>>>>>>
>>>>>>>   media: redrat3: use int type to store negative error codes (2025-09-11 08:46:10 +0200)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>>   https://gitlab.freedesktop.org/linux-media/users/jluthra.git tags/for-6.18-ti-j721e-csi2rx-signed
>>>>>>>
>>>>>>> for you to fetch changes up to c694e74c651e79838e817a8c6644dc72cf80540d:
>>>>>>>
>>>>>>>   media: ti: j721e-csi2rx: Support system suspend using pm_notifier (2025-09-12 14:37:56 +0530)
>>>>>>>
>>>>>>> ----------------------------------------------------------------
>>>>>>> TI and Cadence CSI2RX driver changes:
>>>>>>>
>>>>>>> - Multistream support for Cadence and TI CSI2RX
>>>>>>> - Runtime PM support for Cadence and TI CSI2RX
>>>>>>> - System suspend and resume support for TI CSI2RX
>>>>>>> - Misc cleanups
>>>>>>
>>>>>> This should go through Sakari most likely, possibly Laurent, seeing that this is CSI
>>>>>> related. Several patches do not even have a Reviewed-by from Sakari or Laurent.
>>>>>>
>>>>>> I can't take this, I'm afraid.
>>>>>>
>>>>>> I'm not sure why we get a PR from you, was there some misunderstanding?
>>>>>
>>>>> Apologies. I had a look at other "GIT PULL" messages on linux-media and 
>>>>> inferred that any driver maintainer can send a pull request for media tree.
>>>>
>>>> Ah, no. It's media maintainers that do that. For small subsystems you would post
>>>> patches and the subsystem maintainer will (when ready) merge them and send a PR
>>>> to Linus.
>>>>
>>>> For large subsystems like media you have multiple media maintainers, each responsible
>>>> for a part of the subsystem. They will review and prep a PR for the media maintainers
>>>> (me and Mauro) to pick up. The media subsystem is far too big for a single maintainer.
>>>>
>>>> Hopefully once we get the multi-committer up and running (pending doc changes) we can
>>>> do away with most of the PRs.
>>>
>>> Is there an objection against pull requests from driver maintainers ?
>>> Assuming all the other rules and requirements are met (passing CI,
>>> having the expected R-b tags, ...), is there a reason why I would need
>>> to collect a series posted by Jai and then send a pull request, instead
>>> of having Jai send the pull request directly ?
>>
>> If I get a PR from you, then I know that you, with your expertise, judged the
>> patches in the PR to be ready to be merged. Since it's from you I also can
>> trust that all the right tags are in place, that all the right people have
>> been pulled in if that was needed, etc.
>>
>> If the PR would be from a driver maintainer, then I don't have that additional
>> level of trust and I will have to pay closer attention to the patches in the PR,
>> checking tags, checking that nothing was forgotten, etc. Precisely what happened
>> in this case where tags were missing.
>>
>> As a general rule we don't accept PRs from non-media maintainers. It's something
>> we can discuss, though.
>>
>> BTW, when I talk about 'trust', it's about trusting the PR author to know all the
>> procedures, and having the expertise to know when something is ready to be merged.
>> It's not about malicious code or anything like that.
> 
> Understood. The risk of honest mistakes is at the moment much higher
> than the risk of malicious activity, given the complexity of the
> process. Whether that's good or bad news is debatable :-)

Indeed. It has become more and more complex over time. It's not media specific,
I think, it is a general trend. Not helped by confusion around things like when
to add a CC to stable, and now the Link tag discussion.

> 
>> So a driver maintainer will certainly know the driver code, and is expected to review
>> patches for that driver. But it takes time to gain the expertise to become a
>> media maintainer.
>>
>> I hope this helps.
> 
> Thank you for sharing you reasoning, it helps.
> 
> I would like to experiment with allowing pull requests from more
> contributors, but I don't want to increase your workload by forcing you
> to review those way more carefully. If that's OK with everybody, I
> propose, for the next version of the patches (once they get reviewed by
> the appropriate person) that Jai would send me pull request, following
> all our rules. I will check that everything is fine, and will then
> "forward" the pull request by sending you a pull request for the same
> commit ID, but from my tree and with a tag that carries my GPG
> signature. This will have no impact on your workflow, will allow me to
> delegate work to Jai, and will allow him to learn the subsystem rules.

That would be fine by me!

Regards,

	Hans

> 
>>>>> I looked at 
>>>>> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html but 
>>>>> that was not very informative.
>>>>>
>>>>> But yes, happy to wait for more reviews from Sakari and Laurent (or Tomi given 
>>>>> this is about streams support).
>>>>>
>>>>> Could the process and who-owns-what sub-subsystem be better documented in 
>>>>> docs.kernel.org or linuxtv.org? I am aware of the proposed multi-committer 
>>>>> model, but until that is finalized even the current process is hard to 
>>>>> understand for a newbie :-)
>>>>
>>>> It's here (link below), but I see that it is out-of-date: it's missing Nicolas Dufresne for
>>>> codecs and Bryan O'Donoghue for Qualcomm drivers.
>>>>
>>>> https://linuxtv.org/downloads/v4l-dvb-apis-new/driver-api/maintainer-entry-profile.html#media-maintainers
>>>>
>>>> In any case, your PR came in too late. After rc6 is released we only merge fixes as a
>>>> general rule. It's good to keep that in mind for the next kernel cycle.
>>>>
>>>> If your PR contains fixes that you believe are important for v6.18, then discuss that
>>>> with Sakari and he can post a PR with those fixes.
>>>>
>>>>>>> ----------------------------------------------------------------
>>>>>>> Changhuang Liang (1):
>>>>>>>       media: cadence: csi2rx: Support runtime PM
>>>>>>>
>>>>>>> Jai Luthra (9):
>>>>>>>       dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
>>>>>>>       media: ti: j721e-csi2rx: separate out device and context
>>>>>>>       media: ti: j721e-csi2rx: add a subdev for the core device
>>>>>>>       media: ti: j721e-csi2rx: add support for processing virtual channels
>>>>>>>       media: cadence: csi2rx: add multistream support
>>>>>>>       media: ti: j721e-csi2rx: add multistream support
>>>>>>>       media: ti: j721e-csi2rx: Submit all available buffers
>>>>>>>       media: ti: j721e-csi2rx: Support runtime suspend
>>>>>>>       media: ti: j721e-csi2rx: Support system suspend using pm_notifier
>>>>>>>
>>>>>>> Pratyush Yadav (4):
>>>>>>>       media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
>>>>>>>       media: ti: j721e-csi2rx: allocate DMA channel based on context index
>>>>>>>       media: ti: j721e-csi2rx: get number of contexts from device tree
>>>>>>>       media: cadence: csi2rx: add get_frame_desc wrapper
>>>>>>>
>>>>>>> Rishikesh Donadkar (2):
>>>>>>>       media: ti: j721e-csi2rx: Remove word size alignment on frame width
>>>>>>>       media: ti: j721e-csi2rx: Change the drain architecture for multistream
>>>>>>>
>>>>>>>  Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml |   39 ++++++-
>>>>>>>  drivers/media/platform/cadence/Kconfig                            |    1 +
>>>>>>>  drivers/media/platform/cadence/cdns-csi2rx.c                      |  491 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------
>>>>>>>  drivers/media/platform/ti/Kconfig                                 |    1 +
>>>>>>>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c             | 1167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
>>>>>>>  5 files changed, 1300 insertions(+), 399 deletions(-)
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-09-15 10:09 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-12  9:55 [GIT PULL FOR v6.18] TI and Cadence CSI2RX drivers changes Jai Luthra
2025-09-12 10:17 ` Hans Verkuil
2025-09-12 11:21   ` Jai Luthra
2025-09-15  8:24     ` Hans Verkuil
2025-09-15  8:44       ` Laurent Pinchart
2025-09-15  9:20         ` Hans Verkuil
2025-09-15  9:52           ` Laurent Pinchart
2025-09-15 10:09             ` Hans Verkuil
2025-09-15  7:17   ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.