From: Jon Smirl <jonsmirl@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] add NULL short circuit to fb_dealloc_cmap()
Date: Sun, 17 Jul 2005 18:32:07 -0400 [thread overview]
Message-ID: <9e47339105071715322c558403@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0507172314000.4553@numbat.sonytel.be>
On 7/17/05, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > struct fb_super_cmap {
> > struct fb_cmap cmap;
> > __u16 red[255];
> > __u16 blue[255];
> > __u16 green[255];
> > __u16 transp[255];
> ^^^
> I assume you meant 256?
>
> > }
> >
> > Then adjust the code as need. Have the embedded cmap struct point to
> > the fields in the super_cmap and the drivers don't have to be changed.
>
> What if your colormap has more than 256 entries?
I meant 256. Does any hardware exist that takes more that 256 entries?
They are __u16 values but I have never seen hardware that take more
that __u8 either.
--
Jon Smirl
jonsmirl@gmail.com
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id\x16492&op=click
WARNING: multiple messages have this Message-ID (diff)
From: Jon Smirl <jonsmirl@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] add NULL short circuit to fb_dealloc_cmap()
Date: Sun, 17 Jul 2005 18:32:07 -0400 [thread overview]
Message-ID: <9e47339105071715322c558403@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0507172314000.4553@numbat.sonytel.be>
On 7/17/05, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > struct fb_super_cmap {
> > struct fb_cmap cmap;
> > __u16 red[255];
> > __u16 blue[255];
> > __u16 green[255];
> > __u16 transp[255];
> ^^^
> I assume you meant 256?
>
> > }
> >
> > Then adjust the code as need. Have the embedded cmap struct point to
> > the fields in the super_cmap and the drivers don't have to be changed.
>
> What if your colormap has more than 256 entries?
I meant 256. Does any hardware exist that takes more that 256 entries?
They are __u16 values but I have never seen hardware that take more
that __u8 either.
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2005-07-17 22:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-17 18:43 [PATCH] add NULL short circuit to fb_dealloc_cmap() Jesper Juhl
2005-07-17 20:22 ` Jon Smirl
2005-07-17 21:14 ` Geert Uytterhoeven
2005-07-17 21:14 ` Geert Uytterhoeven
2005-07-17 21:35 ` Jan Engelhardt
2005-07-17 22:32 ` Jon Smirl [this message]
2005-07-17 22:32 ` Jon Smirl
2005-07-26 7:13 ` Geert Uytterhoeven
2005-07-26 7:13 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e47339105071715322c558403@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.