From: Macpaul Lin <macpaul@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9 05/10] nds32/ag101: lowlevel_init.S of ag101
Date: Mon, 2 May 2011 23:37:49 +0800 [thread overview]
Message-ID: <BANLkTimuJunzvthhx6+s7FRL-9PW8WM1rA@mail.gmail.com> (raw)
In-Reply-To: <20110502152700.53274BB0D9@gemini.denx.de>
Hi Wolfgang,
> Patch changelog belongs _below_ the "---" line, not above.
Sorry for this mistaken, will fix in Patch v10
>> ?arch/nds32/cpu/n1213/ag101/lowlevel_init.S | ?160 ++++++++++++++++++++++++++++
>> ?1 files changed, 160 insertions(+), 0 deletions(-)
>> ?create mode 100644 arch/nds32/cpu/n1213/ag101/lowlevel_init.S
>
> This file alone makes no sense. ?Pluease submit as a single commit
> together with the other board code.
The single file is intend to be reviewed and fix up easyly because I
know there must be some problem of this lowlevel_init.S.
I think this should go with the SoC. So I will merge it into ag101 SoC
level related code.
> ...
>> + ? ? /*
>> + ? ? ?* relocation, copy ROM code to SDRAM (current at 0x10000000)
>> + ? ? ?*/
>> + ? ? li ? ? ?$r4, CONFIG_SYS_RELO_ADDR ? ? ? ? ? ? ? ! 0x10000000
>> + ? ? li ? ? ?$r5, 0x0
>> + ? ? la ? ? ?$r1, relo_base
>> + ? ? sub ? ? $r2, $r0, $r1
>> + ? ? sethi ? $r6, hi20(andesboot_end)
>> + ? ? ori ? ? $r6, $r6, lo12(andesboot_end)
>> + ? ? add ? ? $r6, $r6, $r2
>> +1:
>> + ? ? lwi ? ? $r7, [$r5]
>> + ? ? swi ? ? $r7, [$r4]
>> + ? ? addi ? ?$r5, $r5, #4
>> + ? ? addi ? ?$r4, $r4, #4
>> + ? ? blt ? ? $r5, $r6, 1b
>
> You are using ?non-standard and completely undocumented CONFIG option
> here, CONFIG_SYS_RELO_ADDR. ?Please don't. ?I think when adding new
> architecture support we should avaid errors done with other
> architectures in the past (see ARM, MIPS, ...).
Sure.
> Please implement proper relocation to a dynamically determined
> address at the upper end of RAM. Keep in mind that the intention is
> to have only a single lib/board.c isnatead of a collection of
> slightly different arch-specific arch/*/board.c versions.
>
> Best regards,
>
> Wolfgang Denk
Will try to fix it soon.
Thanks.
--
Best regards,
Macpaul Lin
next prev parent reply other threads:[~2011-05-02 15:37 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 12:45 [U-Boot] [PATCH v7 01/10] nds32: add header files support for nds32 Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 02/10] nds32: add NDS32 support into common header file Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 03/10] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 04/10] nds32/ag101: dev offset header of SoC ag101 Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 05/10] nds32/ag101: lowlevel_init.S of ag101 Macpaul Lin
2011-04-07 13:01 ` Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 06/10] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 07/10] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 08/10] nds32: standalone support Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 09/10] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-04-07 12:45 ` [U-Boot] [PATCH v7 10/10] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-04-07 14:55 ` [U-Boot] [PATCH v7 01/10] nds32: add header files support for nds32 Wolfgang Denk
[not found] ` <BANLkTimhCuOcvMmFrSJGHxYRHyKFXJTc9g@mail.gmail.com>
2011-04-07 15:32 ` Macpaul Lin
2011-04-07 17:00 ` Wolfgang Denk
2011-04-08 7:58 ` Macpaul Lin
2011-04-11 2:05 ` Macpaul Lin
2011-04-29 23:09 ` Wolfgang Denk
2011-04-30 4:09 ` Chih-Min Chao
2011-05-02 9:27 ` Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 " Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 02/10] nds32: add NDS32 support into common header file Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 03/10] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 04/10] nds32/ag101: dev offset header of SoC ag101 Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 05/10] nds32/ag101: lowlevel_init.S of ag101 Macpaul Lin
2011-05-02 15:27 ` Wolfgang Denk
2011-05-02 15:37 ` Macpaul Lin [this message]
2011-05-02 13:25 ` [U-Boot] [PATCH v9 06/10] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 07/10] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 08/10] nds32: standalone support Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 09/10] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-05-02 13:25 ` [U-Boot] [PATCH v9 10/10] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-05-02 15:32 ` Wolfgang Denk
2011-08-31 10:25 ` [U-Boot] [PATCH v10 1/8] nds32: add header files support for nds32 Macpaul Lin
2011-08-31 14:52 ` Mike Frysinger
2011-08-31 14:53 ` Mike Frysinger
2011-08-31 10:25 ` [U-Boot] [PATCH v10 2/8] nds32: add NDS32 support into common header file Macpaul Lin
2011-08-31 10:25 ` [U-Boot] [PATCH v10 3/8] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-08-31 14:47 ` Mike Frysinger
2011-08-31 10:25 ` [U-Boot] [PATCH v10 4/8] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-08-31 10:25 ` [U-Boot] [PATCH v10 5/8] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-08-31 10:25 ` [U-Boot] [PATCH v10 6/8] nds32: standalone support Macpaul Lin
2011-08-31 10:25 ` [U-Boot] [PATCH v10 7/8] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-08-31 10:26 ` [U-Boot] [PATCH v10 8/8] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 1/9] nds32: add header files support for nds32 Macpaul Lin
2011-09-01 14:16 ` Mike Frysinger
2011-09-01 5:52 ` [U-Boot] [PATCH v11 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-09-01 14:18 ` Mike Frysinger
2011-09-06 3:50 ` 馬克泡
2011-09-01 14:21 ` Mike Frysinger
2011-09-01 5:52 ` [U-Boot] [PATCH v11 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-09-01 14:28 ` Mike Frysinger
2011-09-06 6:41 ` 馬克泡
2011-09-06 21:15 ` Mike Frysinger
2011-09-07 2:27 ` [U-Boot] [PATCH v12 1/9] nds32: add header files support for nds32 Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-09-09 1:10 ` Mike Frysinger
2011-09-09 2:22 ` 馬克泡
2011-09-20 8:48 ` 馬克泡
2011-09-21 2:20 ` [U-Boot] [PATCH v13 1/9] nds32: add header files support for nds32 Macpaul Lin
2011-09-21 3:03 ` 馬克泡
2011-09-21 3:10 ` [U-Boot] [PATCH v14 " Macpaul Lin
2011-10-06 21:27 ` Wolfgang Denk
2011-09-21 3:10 ` [U-Boot] [PATCH v14 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-09-21 3:10 ` [U-Boot] [PATCH v14 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-10-06 21:26 ` Wolfgang Denk
2011-09-21 3:10 ` [U-Boot] [PATCH v14 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-10-06 21:26 ` Wolfgang Denk
2011-09-21 3:10 ` [U-Boot] [PATCH v14 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-10-06 21:25 ` Wolfgang Denk
2011-09-21 3:10 ` [U-Boot] [PATCH v14 6/9] nds32: standalone support Macpaul Lin
2011-10-06 21:25 ` Wolfgang Denk
2011-09-21 3:10 ` [U-Boot] [PATCH v14 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-09-21 3:10 ` [U-Boot] [PATCH v14 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-09-21 3:10 ` [U-Boot] [PATCH v14 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 6/9] nds32: standalone support Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-09-21 2:20 ` [U-Boot] [PATCH v13 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-10-06 10:25 ` [U-Boot] [PATCH v15 1/9] nds32: add header files support for nds32 Macpaul Lin
2011-10-06 20:59 ` Wolfgang Denk
2011-10-07 1:29 ` 馬克泡
2011-10-07 6:24 ` Wolfgang Denk
2011-10-11 5:58 ` 馬克泡
2011-10-11 12:53 ` Wolfgang Denk
2011-10-11 14:06 ` 馬克泡
2011-10-12 8:33 ` [U-Boot] [PATCH v16 " Macpaul Lin
2011-10-18 8:36 ` 馬克泡
2011-10-18 18:38 ` Simon Glass
2011-10-12 8:33 ` [U-Boot] [PATCH v16 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 6/9] nds32: standalone support Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-10-12 8:33 ` [U-Boot] [PATCH v16 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-10-20 6:41 ` [U-Boot] [PATCH v17 1/9] nds32: add header files support for nds32 Macpaul Lin
2011-10-21 22:51 ` Wolfgang Denk
2011-10-22 1:47 ` 馬克泡
2011-10-20 6:41 ` [U-Boot] [PATCH v17 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-10-21 22:52 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-10-21 22:52 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-10-21 22:52 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-10-21 22:53 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 6/9] nds32: standalone support Macpaul Lin
2011-10-21 22:53 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-10-21 22:54 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-10-21 22:54 ` Wolfgang Denk
2011-10-20 6:41 ` [U-Boot] [PATCH v17 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-10-21 22:54 ` Wolfgang Denk
2011-10-06 10:25 ` [U-Boot] [PATCH v15 2/9] nds32: add NDS32 support into common header file Macpaul Lin
2011-10-06 10:25 ` [U-Boot] [PATCH v15 3/9] nds32/core N1213: NDS32 N12 core family N1213 Macpaul Lin
2011-10-06 20:58 ` Wolfgang Denk
2011-10-06 10:25 ` [U-Boot] [PATCH v15 4/9] nds32/ag101: cpu and init funcs of SoC ag101 Macpaul Lin
2011-10-06 20:58 ` Wolfgang Denk
2011-10-06 10:25 ` [U-Boot] [PATCH v15 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-10-06 20:57 ` Wolfgang Denk
2011-10-06 10:25 ` [U-Boot] [PATCH v15 6/9] nds32: standalone support Macpaul Lin
2011-10-06 20:55 ` Wolfgang Denk
2011-10-06 10:25 ` [U-Boot] [PATCH v15 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-10-06 10:25 ` [U-Boot] [PATCH v15 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-10-06 10:25 ` [U-Boot] [PATCH v15 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 5/9] nds32/lib: add generic funcs in NDS32 lib Macpaul Lin
2011-09-09 1:12 ` Mike Frysinger
2011-09-07 2:27 ` [U-Boot] [PATCH v12 6/9] nds32: standalone support Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-09-07 2:27 ` [U-Boot] [PATCH v12 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-09-09 1:14 ` Mike Frysinger
2011-09-07 2:27 ` [U-Boot] [PATCH v12 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 6/9] nds32: standalone support Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 7/9] nds32: common bdinfo, bootm, image support Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 8/9] adp-ag101: add board adp-ag101 support Macpaul Lin
2011-09-01 5:52 ` [U-Boot] [PATCH v11 9/9] doc/README: documents and readme for NDS32 arch Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimuJunzvthhx6+s7FRL-9PW8WM1rA@mail.gmail.com \
--to=macpaul@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.