All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, Haitao Shan <haitao.shan@intel.com>
Cc: Weidong Han <weidong.han@intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Yunhong Jiang <yunhong.jiang@intel.com>,
	Allen M Kay <allen.m.kay@intel.com>,
	xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen
Date: Fri, 11 Apr 2008 13:14:10 +0100	[thread overview]
Message-ID: <C42514A2.1F091%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <47FF70CA.76E4.0078.0@novell.com>

On 11/4/08 13:08, "Jan Beulich" <jbeulich@novell.com> wrote:

> I don't think this is going to do what you want when the kernel is using
> mmconfig, or AMD's extended register space access method (not to
> speak of the hopefully not in wide spread use type 2 access method).

The aim is to synchronise accesses to the PCI window registers cf8/cfc. It's
not to synchronise the PCI config space accesses themselves.

> Also I find it a little odd that you allow access to ports cf9...cfb rather
> than properly handling namely byte accesses to cf9. Likewise it
> doesn't consider the (albeit unlikely) case of multi-byte accesses to
> ports crossing the cf8/cfc boundary.

I've cleaned this up and basically rewritten the patch. I'll be checking it
in this afternoon.

 -- Keir

  reply	other threads:[~2008-04-11 12:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10  9:45 [PATCH][RFC]Move PCI Configuration Spaces from Dom0 to Xen Shan, Haitao
2008-04-10 10:24 ` Keir Fraser
2008-04-10 11:59   ` Haitao Shan
2008-04-10 16:54     ` Espen Skoglund
2008-04-11  0:42       ` [PATCH][RFC]Move PCI Configuration Spacesfrom " Shan, Haitao
2008-04-11  8:24         ` Keir Fraser
2008-04-11 12:08 ` [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen Jan Beulich
2008-04-11 12:14   ` Keir Fraser [this message]
2008-04-11 14:35   ` Espen Skoglund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C42514A2.1F091%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=allen.m.kay@intel.com \
    --cc=haitao.shan@intel.com \
    --cc=jbeulich@novell.com \
    --cc=kevin.tian@intel.com \
    --cc=weidong.han@intel.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.