* __vmptrst() broken...
@ 2011-11-22 2:47 Mukesh Rathor
2011-11-22 7:46 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Mukesh Rathor @ 2011-11-22 2:47 UTC (permalink / raw)
To: Xen-devel@lists.xensource.com, Keir Fraser
Hi Keir,
__vmptrst() seems broken. It is:
static inline void __vmptrst(u64 addr)
{
asm volatile ( VMPTRST_OPCODE
MODRM_EAX_07
:
: "a" (&addr)
: "memory");
}
should be:
static inline void __vmptrst(u64 *addr)
{
asm volatile ( VMPTRST_OPCODE
MODRM_EAX_07
:
: "a" (addr)
: "memory");
}
Do you think you can just fix it in one of your changes without
official patch?
thanks much,
Mukesh
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: __vmptrst() broken...
2011-11-22 2:47 __vmptrst() broken Mukesh Rathor
@ 2011-11-22 7:46 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2011-11-22 7:46 UTC (permalink / raw)
To: Mukesh Rathor, Xen-devel@lists.xensource.com
On 22/11/2011 02:47, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
> Hi Keir,
>
> __vmptrst() seems broken. It is:
>
> static inline void __vmptrst(u64 addr)
> {
> asm volatile ( VMPTRST_OPCODE
> MODRM_EAX_07
> :
> : "a" (&addr)
> : "memory");
> }
>
>
> should be:
>
> static inline void __vmptrst(u64 *addr)
> {
> asm volatile ( VMPTRST_OPCODE
> MODRM_EAX_07
> :
> : "a" (addr)
> : "memory");
> }
>
>
>
> Do you think you can just fix it in one of your changes without
> official patch?
It's obviously not used. It's probably not even useful (we know what VMCS we
last loaded). I'll just remove it.
-- Keir
> thanks much,
> Mukesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-22 7:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 2:47 __vmptrst() broken Mukesh Rathor
2011-11-22 7:46 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.