From: Keir Fraser <keir@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: KEXEC: fix kexec_get_range_compat to fail vocally
Date: Mon, 05 Dec 2011 19:46:33 +0000 [thread overview]
Message-ID: <CB02D019.34FCD%keir@xen.org> (raw)
In-Reply-To: <4EDCAC68.8060303@citrix.com>
On 05/12/2011 11:35, "Andrew Cooper" <andrew.cooper3@citrix.com> wrote:
> I am not sure that this is the only instance, but it is really not
> acceptable to hand truncated pointers or sizes for physical memory to dom0.
I applied as c/s 24358 but I changed the mask-checking arithmetic a bit. Not
only is it now shorter, I'm also more certain that it is correct: It looks
to me like ~((unsigned int)-1) performs the ~ before promotion to unsigned
long, hence this term ends up as 0 rather than 0xffffffff00000000.
-- Keir
prev parent reply other threads:[~2011-12-05 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 11:35 KEXEC: fix kexec_get_range_compat to fail vocally Andrew Cooper
2011-12-05 12:58 ` Jan Beulich
2011-12-05 13:01 ` Andrew Cooper
2011-12-05 13:18 ` Jan Beulich
2011-12-05 13:39 ` Andrew Cooper
2011-12-05 19:46 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB02D019.34FCD%keir@xen.org \
--to=keir@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.