All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: "Ricardo Ribalda" <ribalda@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
Date: Mon, 22 Apr 2024 11:53:35 +0200	[thread overview]
Message-ID: <D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org> (raw)
In-Reply-To: <ea3b32a8-7a1c-4a32-beb5-acc6f6435954@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]

Hi,

> 	if (name)
> 		info = spi_nor_match_name(nor, name);
>
> 	if (!info || info->id) {
> 		jinfo = spi_nor_detect(nor);
> 		if (IS_ERR(jinfo))
> 			return jinfo;
> 		
> 		if (jinfo != info)

info could be NULL here. So "info &&", apart from that looks good.

> 			dev_warn(();
> 		info = jinfo;
> 	}

Pratyush, should I'll drop your Rb tag then.

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: "Ricardo Ribalda" <ribalda@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
Date: Mon, 22 Apr 2024 11:53:35 +0200	[thread overview]
Message-ID: <D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org> (raw)
In-Reply-To: <ea3b32a8-7a1c-4a32-beb5-acc6f6435954@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi,

> 	if (name)
> 		info = spi_nor_match_name(nor, name);
>
> 	if (!info || info->id) {
> 		jinfo = spi_nor_detect(nor);
> 		if (IS_ERR(jinfo))
> 			return jinfo;
> 		
> 		if (jinfo != info)

info could be NULL here. So "info &&", apart from that looks good.

> 			dev_warn(();
> 		info = jinfo;
> 	}

Pratyush, should I'll drop your Rb tag then.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

  reply	other threads:[~2024-04-22  9:54 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 14:12 [PATCH v2 0/6] mtd: spi-nor: spring cleaning Michael Walle
2024-04-19 14:12 ` Michael Walle
2024-04-19 14:12 ` [PATCH v2 1/6] mtd: spi-nor: Remove support for Xilinx S3AN flashes Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 15:16   ` Ricardo Ribalda Delgado
2024-04-19 15:16     ` Ricardo Ribalda Delgado
2024-04-19 14:12 ` [PATCH v2 2/6] mtd: spi-nor: get rid of non-power-of-2 page size handling Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:15   ` Pratyush Yadav
2024-04-19 18:15     ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-22  5:55   ` Tudor Ambarus
2024-04-22  5:55     ` Tudor Ambarus
2024-05-27 13:27   ` Pratyush Yadav
2024-05-27 13:27     ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 4/6] mtd: spi-nor: get rid of SPI_NOR_NO_FR Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:29   ` Pratyush Yadav
2024-04-19 18:29     ` Pratyush Yadav
2024-04-22  5:59   ` Tudor Ambarus
2024-04-22  5:59     ` Tudor Ambarus
2024-05-27 14:33     ` Pratyush Yadav
2024-05-27 14:33       ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info() Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-22  6:41   ` Tudor Ambarus
2024-04-22  6:41     ` Tudor Ambarus
2024-04-22  9:53     ` Michael Walle [this message]
2024-04-22  9:53       ` Michael Walle
2024-04-22 10:12       ` Tudor Ambarus
2024-04-22 10:12         ` Tudor Ambarus
2024-04-22 10:14         ` Tudor Ambarus
2024-04-22 10:14           ` Tudor Ambarus
2024-04-19 14:12 ` [PATCH v2 6/6] mtd: spi-nor: introduce support for displaying deprecation message Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:38   ` Pratyush Yadav
2024-04-19 18:38     ` Pratyush Yadav
2024-04-22  6:06   ` Tudor Ambarus
2024-04-22  6:06     ` Tudor Ambarus
2024-04-22 10:00     ` Michael Walle
2024-04-22 10:00       ` Michael Walle
2024-04-22  6:42   ` Tudor Ambarus
2024-04-22  6:42     ` Tudor Ambarus
2024-05-27 15:10 ` [PATCH v2 0/6] mtd: spi-nor: spring cleaning Pratyush Yadav
2024-05-27 15:10   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org \
    --to=mwalle@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=ribalda@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.