All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Ricardo Ribalda <ribalda@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback
Date: Mon, 27 May 2024 15:27:10 +0200	[thread overview]
Message-ID: <mafs0jzjfe66p.fsf@kernel.org> (raw)
In-Reply-To: <20240419141249.609534-4-mwalle@kernel.org> (Michael Walle's message of "Fri, 19 Apr 2024 16:12:46 +0200")

Hi,

On Fri, Apr 19 2024, Michael Walle wrote:

> With the removal of the Xilinx flashes, there is no more flash driver
> using that hook. The original intention was to let the driver configure
> special requirements like page size an opcodes.  This is already
> possible by other means and it is unlikely a flash will overwrite the
> (more or less complex) setup function.

Just for comparison, I checked if U-Boot does anything with the setup
hook that we might also need. It looks like it mostly uses it for
handling non-uniform erases on Spansion flashes, since U-Boot doesn't
have proper support for them. This shouldn't be needed by Linux since it
can already do those erases.

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Ricardo Ribalda <ribalda@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback
Date: Mon, 27 May 2024 15:27:10 +0200	[thread overview]
Message-ID: <mafs0jzjfe66p.fsf@kernel.org> (raw)
In-Reply-To: <20240419141249.609534-4-mwalle@kernel.org> (Michael Walle's message of "Fri, 19 Apr 2024 16:12:46 +0200")

Hi,

On Fri, Apr 19 2024, Michael Walle wrote:

> With the removal of the Xilinx flashes, there is no more flash driver
> using that hook. The original intention was to let the driver configure
> special requirements like page size an opcodes.  This is already
> possible by other means and it is unlikely a flash will overwrite the
> (more or less complex) setup function.

Just for comparison, I checked if U-Boot does anything with the setup
hook that we might also need. It looks like it mostly uses it for
handling non-uniform erases on Spansion flashes, since U-Boot doesn't
have proper support for them. This shouldn't be needed by Linux since it
can already do those erases.

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

  parent reply	other threads:[~2024-05-27 13:27 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 14:12 [PATCH v2 0/6] mtd: spi-nor: spring cleaning Michael Walle
2024-04-19 14:12 ` Michael Walle
2024-04-19 14:12 ` [PATCH v2 1/6] mtd: spi-nor: Remove support for Xilinx S3AN flashes Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 15:16   ` Ricardo Ribalda Delgado
2024-04-19 15:16     ` Ricardo Ribalda Delgado
2024-04-19 14:12 ` [PATCH v2 2/6] mtd: spi-nor: get rid of non-power-of-2 page size handling Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:15   ` Pratyush Yadav
2024-04-19 18:15     ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-22  5:55   ` Tudor Ambarus
2024-04-22  5:55     ` Tudor Ambarus
2024-05-27 13:27   ` Pratyush Yadav [this message]
2024-05-27 13:27     ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 4/6] mtd: spi-nor: get rid of SPI_NOR_NO_FR Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:29   ` Pratyush Yadav
2024-04-19 18:29     ` Pratyush Yadav
2024-04-22  5:59   ` Tudor Ambarus
2024-04-22  5:59     ` Tudor Ambarus
2024-05-27 14:33     ` Pratyush Yadav
2024-05-27 14:33       ` Pratyush Yadav
2024-04-19 14:12 ` [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info() Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-22  6:41   ` Tudor Ambarus
2024-04-22  6:41     ` Tudor Ambarus
2024-04-22  9:53     ` Michael Walle
2024-04-22  9:53       ` Michael Walle
2024-04-22 10:12       ` Tudor Ambarus
2024-04-22 10:12         ` Tudor Ambarus
2024-04-22 10:14         ` Tudor Ambarus
2024-04-22 10:14           ` Tudor Ambarus
2024-04-19 14:12 ` [PATCH v2 6/6] mtd: spi-nor: introduce support for displaying deprecation message Michael Walle
2024-04-19 14:12   ` Michael Walle
2024-04-19 18:38   ` Pratyush Yadav
2024-04-19 18:38     ` Pratyush Yadav
2024-04-22  6:06   ` Tudor Ambarus
2024-04-22  6:06     ` Tudor Ambarus
2024-04-22 10:00     ` Michael Walle
2024-04-22 10:00       ` Michael Walle
2024-04-22  6:42   ` Tudor Ambarus
2024-04-22  6:42     ` Tudor Ambarus
2024-05-27 15:10 ` [PATCH v2 0/6] mtd: spi-nor: spring cleaning Pratyush Yadav
2024-05-27 15:10   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0jzjfe66p.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=ribalda@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.