[Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Bonnefille]

GCC14 removed the implicit int support.
This commit adds a patch to libsha1 to fix an implicit int declaration
as recommended.

Link: https://gcc.gnu.org/gcc-14/porting_to.html

Fixes:
    http://autobuild.buildroot.net/results/87dc9ba9690cbb6a82875734ce9cb8dbaf878e46/

Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
---
Changes in v2:
- Regenerate the patch.
- Link to v1: https://lore.kernel.org/r/20241211-fix_gcc14_libsha1-v1-1-c9647718ccc2@bootlin.com
---
 ...01-test-fix-gcc-14.x-compile-implicit-int.patch | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/package/libsha1/0001-test-fix-gcc-14.x-compile-implicit-int.patch b/package/libsha1/0001-test-fix-gcc-14.x-compile-implicit-int.patch
new file mode 100644
index 0000000000000000000000000000000000000000..4550945e00ee1bc909cf670202a99ea34bc41d90
--- /dev/null
+++ b/package/libsha1/0001-test-fix-gcc-14.x-compile-implicit-int.patch
@@ -0,0 +1,38 @@
+From d449f26f782be91b3847f88ed2bd937582a575b6 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sun, 25 Aug 2024 11:33:59 +0200
+Subject: [PATCH] test: fix gcc-14.x compile (implicit int)
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes:
+
+  test.c:14:8: error: type defaults to ‘int’ in declaration of ‘num_test’ [-Wimplicit-int]
+     14 | static num_test;
+        |        ^~~~~~~~
+
+Upstream: https://github.com/pseiderer/libsha1/commit/d449f26f782be91b3847f88ed2bd937582a575b6
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
+---
+ test.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test.c b/test.c
+index 21a6525..1ec89d3 100644
+--- a/test.c
++++ b/test.c
+@@ -11,7 +11,7 @@ static void print_hex(const char* data, size_t size)
+         printf("%x%x", ((unsigned char)data[i])/16, ((unsigned char)data[i])%16);
+ }
+ 
+-static num_test;
++static int num_test;
+ 
+ static int do_test(const char* data, size_t size, const char* expected_dgst)
+ {
+-- 
+2.47.1
+

---
base-commit: efc7a20d5ef109a32c4237eaf907f685968d3c44
change-id: 20241211-fix_gcc14_libsha1-473a5f540eab

Best regards,
-- 
Thomas Bonnefille <thomas.bonnefille@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Petazzoni via buildroot]

Hello Thomas,

On Mon, 16 Dec 2024 18:48:29 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> GCC14 removed the implicit int support.
> This commit adds a patch to libsha1 to fix an implicit int declaration
> as recommended.
> 
> Link: https://gcc.gnu.org/gcc-14/porting_to.html
> 
> Fixes:
>     http://autobuild.buildroot.net/results/87dc9ba9690cbb6a82875734ce9cb8dbaf878e46/
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

Thanks for the new iteration! It fixes the issues I pointed out, but I
have more questions/comments.

> +Fixes:
> +
> +  test.c:14:8: error: type defaults to ‘int’ in declaration of ‘num_test’ [-Wimplicit-int]
> +     14 | static num_test;
> +        |        ^~~~~~~~
> +
> +Upstream: https://github.com/pseiderer/libsha1/commit/d449f26f782be91b3847f88ed2bd937582a575b6

This should ideally...

> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>

... go here, i.e right after Peter's SoB, but before yours, as it's an
information added by you.

But more importantly: https://github.com/pseiderer/libsha1/ isn't
"upstream". Upstream for this package is
https://github.com/dottedmag/libsha1. So we're interested in seeing
the change having been submitted or accepted by the real upstream, not
just a commit in some "random" Github repository (even though Peter
Seiderer is a well known Buildroot contributor!)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Bonnefille via buildroot]

On Mon Dec 16, 2024 at 9:36 PM CET, Thomas Petazzoni wrote:
> Hello Thomas,
Hello Thomas,
Thank you for the review !

> On Mon, 16 Dec 2024 18:48:29 +0100
> ...
> > +
> > +Upstream: https://github.com/pseiderer/libsha1/commit/d449f26f782be91b3847f88ed2bd937582a575b6
>
> This should ideally...
>
> > +
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> ... go here, i.e right after Peter's SoB, but before yours, as it's an
> information added by you.

Ack

> But more importantly: https://github.com/pseiderer/libsha1/ isn't
> "upstream". Upstream for this package is
> https://github.com/dottedmag/libsha1. So we're interested in seeing
> the change having been submitted or accepted by the real upstream, not
> just a commit in some "random" Github repository (even though Peter
> Seiderer is a well known Buildroot contributor!)

Ok so a link to the pull-request is probably better here according to BR
documentation.
(https://github.com/dottedmag/libsha1/pull/1)
However, in this case the PR may not be merged soon given the date of
the last commit applied to the upstream package.

> Thanks!
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Petazzoni]

On Mon, 16 Dec 2024 21:56:04 +0100
"Thomas Bonnefille" <thomas.bonnefille@bootlin.com> wrote:

> > But more importantly: https://github.com/pseiderer/libsha1/ isn't
> > "upstream". Upstream for this package is
> > https://github.com/dottedmag/libsha1. So we're interested in seeing
> > the change having been submitted or accepted by the real upstream, not
> > just a commit in some "random" Github repository (even though Peter
> > Seiderer is a well known Buildroot contributor!)  
> 
> Ok so a link to the pull-request is probably better here according to BR
> documentation.
> (https://github.com/dottedmag/libsha1/pull/1)

Yes, that's the reference we want indeed.

> However, in this case the PR may not be merged soon given the date of
> the last commit applied to the upstream package.

Gah, indeed. I tried quickly to find another "upstream", but there
doesn't seem to be an obvious upstream alternative. This package is
used by xwayland and xserver_xorg-server as a minimal alternative to a
full-blown crypto library like OpenSSL or libgcrypt.

I think for now, your change with Upstream:
https://github.com/dottedmag/libsha1/pull/1 is going to be good enough.
We can always separately decide if we want to drop this package
entirely.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot