[PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU

[PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU

[Ahsan Atta]

The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
introduced an unnecessary change that prevented enabling SR-IOV when
IOMMU is disabled. In certain scenarios, it is desirable to enable
SR-IOV even in the absence of IOMMU. Thus, restoring the previous
functionality to allow VFs to be enumerated in the absence of IOMMU.

Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
---
 drivers/crypto/intel/qat/qat_common/adf_sriov.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_sriov.c b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
index c75d0b6cb0ad..31d1ef0cb1f5 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_sriov.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
@@ -155,7 +155,6 @@ static int adf_do_enable_sriov(struct adf_accel_dev *accel_dev)
 	if (!device_iommu_mapped(&GET_DEV(accel_dev))) {
 		dev_warn(&GET_DEV(accel_dev),
 			 "IOMMU should be enabled for SR-IOV to work correctly\n");
-		return -EINVAL;
 	}
 
 	if (adf_dev_started(accel_dev)) {
-- 
2.49.0

Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU

[Michal Witwicki]

On Wed Jun 4, 2025 at 10:23 AM CEST, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
>
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Michal Witwicki <michal.witwicki@intel.com>

Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU

[Michal Witwicki]

On Wed Jun 4, 2025 at 10:23 AM CEST, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
>
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Michal Witwicki <michal.witwicki@intel.com>

Sorry for resending, previous email was replying to the wrong thread.

Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU

[Herbert Xu]

On Wed, Jun 04, 2025 at 09:23:43AM +0100, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
> 
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_sriov.c | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt