* [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU
@ 2025-06-04 8:23 Ahsan Atta
2025-06-05 8:11 ` Michal Witwicki
2025-06-16 2:56 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Ahsan Atta @ 2025-06-04 8:23 UTC (permalink / raw)
To: herbert; +Cc: linux-crypto, qat-linux, Ahsan Atta, Giovanni Cabiddu
The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
introduced an unnecessary change that prevented enabling SR-IOV when
IOMMU is disabled. In certain scenarios, it is desirable to enable
SR-IOV even in the absence of IOMMU. Thus, restoring the previous
functionality to allow VFs to be enumerated in the absence of IOMMU.
Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
---
drivers/crypto/intel/qat/qat_common/adf_sriov.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_sriov.c b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
index c75d0b6cb0ad..31d1ef0cb1f5 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_sriov.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_sriov.c
@@ -155,7 +155,6 @@ static int adf_do_enable_sriov(struct adf_accel_dev *accel_dev)
if (!device_iommu_mapped(&GET_DEV(accel_dev))) {
dev_warn(&GET_DEV(accel_dev),
"IOMMU should be enabled for SR-IOV to work correctly\n");
- return -EINVAL;
}
if (adf_dev_started(accel_dev)) {
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU
2025-06-04 8:23 [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU Ahsan Atta
@ 2025-06-05 8:11 ` Michal Witwicki
2025-06-16 2:56 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Michal Witwicki @ 2025-06-05 8:11 UTC (permalink / raw)
To: Ahsan Atta, herbert; +Cc: linux-crypto, qat-linux, Giovanni Cabiddu
On Wed Jun 4, 2025 at 10:23 AM CEST, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
>
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Michal Witwicki <michal.witwicki@intel.com>
Sorry for resending, previous email was replying to the wrong thread.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU
2025-06-04 8:23 [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU Ahsan Atta
2025-06-05 8:11 ` Michal Witwicki
@ 2025-06-16 2:56 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2025-06-16 2:56 UTC (permalink / raw)
To: Ahsan Atta; +Cc: linux-crypto, qat-linux, Giovanni Cabiddu
On Wed, Jun 04, 2025 at 09:23:43AM +0100, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
>
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/intel/qat/qat_common/adf_sriov.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <00e74d37ff4d47bda7f425134b737a27@MW3PR11MB4569.namprd11.prod.outlook.com>]
* Re: [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU
[not found] <00e74d37ff4d47bda7f425134b737a27@MW3PR11MB4569.namprd11.prod.outlook.com>
@ 2025-06-04 9:35 ` Michal Witwicki
0 siblings, 0 replies; 4+ messages in thread
From: Michal Witwicki @ 2025-06-04 9:35 UTC (permalink / raw)
To: Atta, Ahsan, herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux, Cabiddu, Giovanni
On Wed Jun 4, 2025 at 10:23 AM CEST, Ahsan Atta wrote:
> The commit ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> introduced an unnecessary change that prevented enabling SR-IOV when
> IOMMU is disabled. In certain scenarios, it is desirable to enable
> SR-IOV even in the absence of IOMMU. Thus, restoring the previous
> functionality to allow VFs to be enumerated in the absence of IOMMU.
>
> Fixes: ca88a2bdd4dd ("crypto: qat - allow disabling SR-IOV VFs")
> Signed-off-by: Ahsan Atta <ahsan.atta@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Michal Witwicki <michal.witwicki@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-16 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-04 8:23 [PATCH] crypto: qat - allow enabling VFs in the absence of IOMMU Ahsan Atta
2025-06-05 8:11 ` Michal Witwicki
2025-06-16 2:56 ` Herbert Xu
[not found] <00e74d37ff4d47bda7f425134b737a27@MW3PR11MB4569.namprd11.prod.outlook.com>
2025-06-04 9:35 ` Michal Witwicki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.