Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields

From: "Michael Walle" <mwalle@kernel.org>
To: "Cheng Ming Lin" <linchengming884@gmail.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Cheng Ming Lin" <chengminglin@mxic.com.tw>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<alvinzhou@mxic.com.tw>, <leoyu@mxic.com.tw>,
	"Maarten Zanders" <maarten@zanders.be>
Subject: Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields
Date: Wed, 24 Sep 2025 14:10:56 +0200	[thread overview]
Message-ID: <DD10QMSJVZ2K.26U45JAXV5EY7@kernel.org> (raw)
In-Reply-To: <CAAyq3SYybDgBvkTKh2ZB4UdKq1XV_nnzx3Tj1P915W5x_7_nNA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

> The root cause of this problem lies in the failure of parsing the SFDP
> data for the flash, rather than an issue with the patch itself. I believe
> we should not revert this patch.

I disagree. There are Macronix flashes with that ID which doesn't
have SFDP.  And this patch is dropping support for them. See also
[1]. Now I'm not sure it is worth reverting this commit. Nobody,
except Guenter complained, but only *so far* (and that patch is in
since 6.16). Any opinions?

-michael

[1] https://lore.kernel.org/r/DD10GE4EOCD7.CPTN7198QFUV@kernel.org/ 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/