[PATCH] x86/kconfig: Reflow the SHADOW help message

[PATCH] x86/kconfig: Reflow the SHADOW help message

[Alejandro Vallejo]

Wasn't following the tab+2 spaces convention throughout the rest of the file.

Not a functional change.

Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
---
 xen/arch/x86/Kconfig | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 61f58aa829..2ce4747f6e 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -148,20 +148,17 @@ config SHADOW_PAGING
 	default !PV_SHIM_EXCLUSIVE
 	depends on PV || HVM
 	help
+	  Shadow paging is a software alternative to hardware paging support
+	  (Intel EPT, AMD NPT).
 
-          Shadow paging is a software alternative to hardware paging support
-          (Intel EPT, AMD NPT).
+	  It is required for:
+	  * Running HVM guests on hardware lacking hardware paging support
+	    (First-generation Intel VT-x or AMD SVM).
+	  * Live migration of PV guests.
+	  * L1TF sidechannel mitigation for PV guests.
 
-          It is required for:
-            * Running HVM guests on hardware lacking hardware paging support
-              (First-generation Intel VT-x or AMD SVM).
-            * Live migration of PV guests.
-            * L1TF sidechannel mitigation for PV guests.
-
-          Under a small number of specific workloads, shadow paging may be
-          deliberately used as a performance optimisation.
-
-          If unsure, say Y.
+	  Under a small number of specific workloads, shadow paging may be
+	  deliberately used as a performance optimisation.
 
 config PAGING
 	def_bool HVM || SHADOW_PAGING

base-commit: 1ee8b11c1106dca6b8fe0d54c0e79146bb6545f0
-- 
2.43.0

Re: [PATCH] x86/kconfig: Reflow the SHADOW help message

[Jan Beulich]

On 09.02.2026 11:33, Alejandro Vallejo wrote:
> Wasn't following the tab+2 spaces convention throughout the rest of the file.
> 
> Not a functional change.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>

Largely:
Acked-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -148,20 +148,17 @@ config SHADOW_PAGING
>  	default !PV_SHIM_EXCLUSIVE
>  	depends on PV || HVM
>  	help
> +	  Shadow paging is a software alternative to hardware paging support
> +	  (Intel EPT, AMD NPT).
>  
> -          Shadow paging is a software alternative to hardware paging support
> -          (Intel EPT, AMD NPT).
> +	  It is required for:
> +	  * Running HVM guests on hardware lacking hardware paging support
> +	    (First-generation Intel VT-x or AMD SVM).
> +	  * Live migration of PV guests.
> +	  * L1TF sidechannel mitigation for PV guests.
>  
> -          It is required for:
> -            * Running HVM guests on hardware lacking hardware paging support
> -              (First-generation Intel VT-x or AMD SVM).
> -            * Live migration of PV guests.
> -            * L1TF sidechannel mitigation for PV guests.
> -
> -          Under a small number of specific workloads, shadow paging may be
> -          deliberately used as a performance optimisation.
> -
> -          If unsure, say Y.

I'm trying to establish (among the committers) whether we're indeed meaning
to drop this sentence from Kconfig help texts that we touch. If I wouldn't
get conclusive feedback, I'd likely put it back in.

Jan

> +	  Under a small number of specific workloads, shadow paging may be
> +	  deliberately used as a performance optimisation.
>  
>  config PAGING
>  	def_bool HVM || SHADOW_PAGING
> 
> base-commit: 1ee8b11c1106dca6b8fe0d54c0e79146bb6545f0

Re: [PATCH] x86/kconfig: Reflow the SHADOW help message

[Alejandro Vallejo]

On Mon Feb 9, 2026 at 3:26 PM CET, Jan Beulich wrote:
> On 09.02.2026 11:33, Alejandro Vallejo wrote:
>> Wasn't following the tab+2 spaces convention throughout the rest of the file.
>> 
>> Not a functional change.
>> 
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
>
> Largely:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thanks.

>
>> --- a/xen/arch/x86/Kconfig
>> +++ b/xen/arch/x86/Kconfig
>> @@ -148,20 +148,17 @@ config SHADOW_PAGING
>>  	default !PV_SHIM_EXCLUSIVE
>>  	depends on PV || HVM
>>  	help
>> +	  Shadow paging is a software alternative to hardware paging support
>> +	  (Intel EPT, AMD NPT).
>>  
>> -          Shadow paging is a software alternative to hardware paging support
>> -          (Intel EPT, AMD NPT).
>> +	  It is required for:
>> +	  * Running HVM guests on hardware lacking hardware paging support
>> +	    (First-generation Intel VT-x or AMD SVM).
>> +	  * Live migration of PV guests.
>> +	  * L1TF sidechannel mitigation for PV guests.
>>  
>> -          It is required for:
>> -            * Running HVM guests on hardware lacking hardware paging support
>> -              (First-generation Intel VT-x or AMD SVM).
>> -            * Live migration of PV guests.
>> -            * L1TF sidechannel mitigation for PV guests.
>> -
>> -          Under a small number of specific workloads, shadow paging may be
>> -          deliberately used as a performance optimisation.
>> -
>> -          If unsure, say Y.
>
> I'm trying to establish (among the committers) whether we're indeed meaning
> to drop this sentence from Kconfig help texts that we touch. If I wouldn't
> get conclusive feedback, I'd likely put it back in.
>
> Jan

Sounds good to me either way.

Cheers,
Alejandro