Re: [PATCH v2 0/3] media: rockchip: rkvdec: add support for the VDPU346 variant

From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Nicolas Dufresne" <nicolas@ndufresne.ca>
Cc: "Christian Hewitt" <christianshewitt@gmail.com>,
	"Detlev Casanova" <detlev.casanova@collabora.com>,
	"Olivier Crête" <olivier.crete@collabora.com>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Diederik de Haas" <diederik@cknow-tech.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Dragan Simic" <dsimic@manjaro.org>,
	"Chukun Pan" <amadeus@jmu.edu.cn>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] media: rockchip: rkvdec: add support for the VDPU346 variant
Date: Sat, 14 Mar 2026 15:19:22 +0100	[thread overview]
Message-ID: <DH2KK4G8Y2K1.3VO7LIFPTGDV1@cknow-tech.com> (raw)
In-Reply-To: <ee0fd1ecc6c940811cae743f087e96d348909c9a.camel@ndufresne.ca>

Hi Nicolas,

On Sun Mar 8, 2026 at 10:40 PM CET, Nicolas Dufresne wrote:
> Le vendredi 26 décembre 2025 à 11:31 +0000, Christian Hewitt a écrit :
>> This series depends upon Detlev Casanova's current v7 series for VDPU381 and
>> VDPU383 support [0]. It adds support for the VDPU346 IP block used for H264,
>> HEVC and (in active work) VP9 on the RK356X boards. VDPU346 appears to be a
>> close relation to VDPU381 used with RK3588, except with a single core, output
>> limited to 4K, and minor feature differences, e.g. HEVC level 5.1 on VDPU346
>> vs 6.1 on VDPU381. To handle differences we declare a new compatible.
>> 
>> The device-tree changes are derived from prior-art in Detlev's patches for
>> RK3576 and RK3588, the vendor kernel [1], and some earlier patch attempts
>> from Piotr Oniszczuk and Diederik de Haas.
>> 
>> The register differences between VDPU346 and VDPU381 appear to be minimal so
>> we currently and intentionally reuse the VDPU381 h264, hevc, and regs files
>> to avoid duplicating code. There is some evidence of buffer size changes in
>> testing which still need to be explored. If further register analysis needs
>> separate files for VDPU346 the refactoring will be beyond my current n00b
>> coding skills and I will either need some coaching or would be happy to pass
>> the series over to a more experienced developer.
>
> A fluster score and explained error report is missing your this cover letter. 
> This will probably highlight some of the instability issues reported in this
> series. I'll mark the series are "Change Request", as you have few review
> comments and now this test.
>
> Overall, I'd like to see probably investigations of the problem before going
> ahead.

FTR: You replied to v2 while there is a v3 here:
https://patch.msgid.link/20260110053727.2295260-1-christianshewitt@gmail.com/

It (still) doesn't have a fluster score, but it is the currently most
recent version posted on the MLs.

Cheers,
  Diederik