From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Drew Fustini" <fustini@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Boqun Feng" <boqun@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org,
rust-for-linux@vger.kernel.org,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Onur Özkan" <work@onurozkan.dev>, Maurice <mhi@mailbox.org>
Subject: Re: [PATCH v5 4/4] rust: clk: use 'kernel vertical style' for imports
Date: Sun, 02 Aug 2026 14:36:45 +0900 [thread overview]
Message-ID: <DKE7QSH5J55L.2C0VNKQXS731Q@nvidia.com> (raw)
In-Reply-To: <20260706-clk-type-state-v5-4-67c5f326a16c@collabora.com>
On Mon Jul 6, 2026 at 11:37 PM JST, Daniel Almeida wrote:
> Convert all imports to use the new import style. This will make it easier
> to land new changes in the future.
>
> No change of functionality implied.
>
> Link: https://docs.kernel.org/rust/coding-guidelines.html#imports
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Would ideally be the first patch of the series to avoid churn. One small
comment below.
<...>
> @@ -193,9 +203,15 @@ impl<State: ClkState> From<Error<State>> for kernel::error::Error {
> /// original [`Clk`], e.g.:
> ///
> /// ```
> - /// use kernel::clk::{Clk, Enabled, Unprepared};
> - /// use kernel::device::{Bound, Device};
> - /// use kernel::error::Result;
> + /// use kernel::clk::{
> + /// Clk,
> + /// Enabled,
> + /// Unprepared, //
Doctests aren't reformatted by `rustfmt` and don't need the trailing `//`.
WARNING: multiple messages have this Message-ID (diff)
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Drew Fustini" <fustini@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Boqun Feng" <boqun@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org,
linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org,
rust-for-linux@vger.kernel.org,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Onur Özkan" <work@onurozkan.dev>, Maurice <mhi@mailbox.org>
Subject: Re: [PATCH v5 4/4] rust: clk: use 'kernel vertical style' for imports
Date: Sun, 02 Aug 2026 14:36:45 +0900 [thread overview]
Message-ID: <DKE7QSH5J55L.2C0VNKQXS731Q@nvidia.com> (raw)
In-Reply-To: <20260706-clk-type-state-v5-4-67c5f326a16c@collabora.com>
On Mon Jul 6, 2026 at 11:37 PM JST, Daniel Almeida wrote:
> Convert all imports to use the new import style. This will make it easier
> to land new changes in the future.
>
> No change of functionality implied.
>
> Link: https://docs.kernel.org/rust/coding-guidelines.html#imports
> Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Would ideally be the first patch of the series to avoid churn. One small
comment below.
<...>
> @@ -193,9 +203,15 @@ impl<State: ClkState> From<Error<State>> for kernel::error::Error {
> /// original [`Clk`], e.g.:
> ///
> /// ```
> - /// use kernel::clk::{Clk, Enabled, Unprepared};
> - /// use kernel::device::{Bound, Device};
> - /// use kernel::error::Result;
> + /// use kernel::clk::{
> + /// Clk,
> + /// Enabled,
> + /// Unprepared, //
Doctests aren't reformatted by `rustfmt` and don't need the trailing `//`.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-08-02 5:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 14:37 [PATCH v5 0/4] Clk improvements Daniel Almeida
2026-07-06 14:37 ` Daniel Almeida
2026-07-06 14:37 ` [PATCH v5 1/4] rust: clk: use the type-state pattern Daniel Almeida
2026-07-06 14:37 ` Daniel Almeida
2026-08-01 14:33 ` Alexandre Courbot
2026-08-01 14:33 ` Alexandre Courbot
2026-08-02 18:30 ` Gary Guo
2026-08-02 18:30 ` Gary Guo
2026-08-03 4:00 ` Alexandre Courbot
2026-08-03 4:00 ` Alexandre Courbot
2026-08-03 12:29 ` Gary Guo
2026-08-03 12:29 ` Gary Guo
2026-08-06 13:54 ` Alexandre Courbot
2026-08-06 13:54 ` Alexandre Courbot
2026-07-06 14:37 ` [PATCH v5 2/4] rust: clk: implement Clone for Clk<T> Daniel Almeida
2026-07-06 14:37 ` Daniel Almeida
2026-08-02 1:05 ` Alexandre Courbot
2026-08-02 1:05 ` Alexandre Courbot
2026-08-02 18:32 ` Gary Guo
2026-08-02 18:32 ` Gary Guo
2026-07-06 14:37 ` [PATCH v5 3/4] rust: clk: add devres-managed clks Daniel Almeida
2026-07-06 14:37 ` Daniel Almeida
2026-07-06 14:51 ` sashiko-bot
2026-08-01 11:22 ` Onur Özkan
2026-08-01 11:22 ` Onur Özkan
2026-08-02 5:24 ` Alexandre Courbot
2026-08-02 5:24 ` Alexandre Courbot
2026-08-02 18:34 ` Gary Guo
2026-08-02 18:34 ` Gary Guo
2026-08-03 3:57 ` Alexandre Courbot
2026-08-03 3:57 ` Alexandre Courbot
2026-08-03 12:32 ` Gary Guo
2026-08-03 12:32 ` Gary Guo
2026-07-06 14:37 ` [PATCH v5 4/4] rust: clk: use 'kernel vertical style' for imports Daniel Almeida
2026-07-06 14:37 ` Daniel Almeida
2026-08-01 17:44 ` Onur Özkan
2026-08-01 17:44 ` Onur Özkan
2026-08-02 5:36 ` Alexandre Courbot [this message]
2026-08-02 5:36 ` Alexandre Courbot
2026-07-31 18:37 ` [PATCH v5 0/4] Clk improvements Maurice Hieronymus
2026-07-31 18:37 ` Maurice Hieronymus
2026-07-31 21:32 ` Daniel Almeida
2026-07-31 21:32 ` Daniel Almeida
2026-08-03 13:06 ` Brian Masney
2026-08-03 13:06 ` Brian Masney
2026-08-03 13:24 ` Daniel Almeida
2026-08-03 13:24 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKE7QSH5J55L.2C0VNKQXS731Q@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fustini@kernel.org \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mhi@mailbox.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=ukleinek@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wefu@redhat.com \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.