All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Jimmy Hon" <honyuenkwun@gmail.com>, "Chukun Pan" <amadeus@jmu.edu.cn>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
	"Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.xyz>,
	"Joachim Eastwood" <joachim.eastwood@gmail.com>
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
Date: Tue, 11 Aug 2026 11:59:33 +0200	[thread overview]
Message-ID: <DKM0YWWP935E.3K38J0LJL6AEE@cknow-tech.com> (raw)
In-Reply-To: <CALWfF7K2t4nt05a4TugBjOQkaQK=M=+wDSeG26B33znyMMzhAQ@mail.gmail.com>

On Tue Aug 11, 2026 at 6:39 AM CEST, Jimmy Hon wrote:
> On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>>
>> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
>> MMUs, and connect the regulators.
>>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> ---
>>  .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 34 +++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> index 854c118418eb..dd29a3ea7031 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> @@ -300,6 +300,10 @@ &pcie2x1l2 {
>>         status = "okay";
>>  };
>>
>> +&pd_npu {
>> +       domain-supply = <&vdd_npu_s0>;
>> +};
> Now that the power domain has control of the regulator. The regulator
> should have regulator-always-on removed, so it can be powered down.

Next to that, quoting a question that was raised earlier here:
https://lore.kernel.org/all/b9a5beb6-b701-430c-b667-44780736dd89@kwiboo.xyz/

"Why is boot-on kept?, NPU is likely not needed until OS has started.

With PD domain-supply the regulator should be enabled automatically, or
is there some other issue that requires boot firmware to enable this
regulator before OS is started?"

I do realize quite a few other boards have it too, but maybe they
shouldn't have it/them either?

Cheers,
  Diederik

WARNING: multiple messages have this Message-ID (diff)
From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Jimmy Hon" <honyuenkwun@gmail.com>, "Chukun Pan" <amadeus@jmu.edu.cn>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
	"Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.xyz>,
	"Joachim Eastwood" <joachim.eastwood@gmail.com>
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
Date: Tue, 11 Aug 2026 11:59:33 +0200	[thread overview]
Message-ID: <DKM0YWWP935E.3K38J0LJL6AEE@cknow-tech.com> (raw)
In-Reply-To: <CALWfF7K2t4nt05a4TugBjOQkaQK=M=+wDSeG26B33znyMMzhAQ@mail.gmail.com>

On Tue Aug 11, 2026 at 6:39 AM CEST, Jimmy Hon wrote:
> On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>>
>> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
>> MMUs, and connect the regulators.
>>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> ---
>>  .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 34 +++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> index 854c118418eb..dd29a3ea7031 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> @@ -300,6 +300,10 @@ &pcie2x1l2 {
>>         status = "okay";
>>  };
>>
>> +&pd_npu {
>> +       domain-supply = <&vdd_npu_s0>;
>> +};
> Now that the power domain has control of the regulator. The regulator
> should have regulator-always-on removed, so it can be powered down.

Next to that, quoting a question that was raised earlier here:
https://lore.kernel.org/all/b9a5beb6-b701-430c-b667-44780736dd89@kwiboo.xyz/

"Why is boot-on kept?, NPU is likely not needed until OS has started.

With PD domain-supply the regulator should be enabled automatically, or
is there some other issue that requires boot firmware to enable this
regulator before OS is started?"

I do realize quite a few other boards have it too, but maybe they
shouldn't have it/them either?

Cheers,
  Diederik

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-08-11 10:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 10:00 [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C Chukun Pan
2026-08-10 10:00 ` Chukun Pan
2026-08-11  4:39 ` Jimmy Hon
2026-08-11  4:39   ` Jimmy Hon
2026-08-11  9:59   ` Diederik de Haas [this message]
2026-08-11  9:59     ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKM0YWWP935E.3K38J0LJL6AEE@cknow-tech.com \
    --to=diederik@cknow-tech.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=honyuenkwun@gmail.com \
    --cc=joachim.eastwood@gmail.com \
    --cc=jonas@kwiboo.xyz \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.