* [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
@ 2026-08-10 10:00 ` Chukun Pan
0 siblings, 0 replies; 6+ messages in thread
From: Chukun Pan @ 2026-08-10 10:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Chukun Pan, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
MMUs, and connect the regulators.
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
.../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 854c118418eb..dd29a3ea7031 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -300,6 +300,10 @@ &pcie2x1l2 {
status = "okay";
};
+&pd_npu {
+ domain-supply = <&vdd_npu_s0>;
+};
+
&pinctrl {
keys {
pwm15_ir_m1: pwm15-ir-m1 {
@@ -354,6 +358,36 @@ &pwm14 {
status = "okay";
};
+&rknn_core_0 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_core_1 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_core_2 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_mmu_0 {
+ status = "okay";
+};
+
+&rknn_mmu_1 {
+ status = "okay";
+};
+
+&rknn_mmu_2 {
+ status = "okay";
+};
+
&saradc {
vref-supply = <&vcca_1v8_s0>;
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
@ 2026-08-10 10:00 ` Chukun Pan
0 siblings, 0 replies; 6+ messages in thread
From: Chukun Pan @ 2026-08-10 10:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Chukun Pan, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
MMUs, and connect the regulators.
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
.../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 854c118418eb..dd29a3ea7031 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -300,6 +300,10 @@ &pcie2x1l2 {
status = "okay";
};
+&pd_npu {
+ domain-supply = <&vdd_npu_s0>;
+};
+
&pinctrl {
keys {
pwm15_ir_m1: pwm15-ir-m1 {
@@ -354,6 +358,36 @@ &pwm14 {
status = "okay";
};
+&rknn_core_0 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_core_1 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_core_2 {
+ npu-supply = <&vdd_npu_s0>;
+ sram-supply = <&vdd_npu_s0>;
+ status = "okay";
+};
+
+&rknn_mmu_0 {
+ status = "okay";
+};
+
+&rknn_mmu_1 {
+ status = "okay";
+};
+
+&rknn_mmu_2 {
+ status = "okay";
+};
+
&saradc {
vref-supply = <&vcca_1v8_s0>;
status = "okay";
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
2026-08-10 10:00 ` Chukun Pan
@ 2026-08-11 4:39 ` Jimmy Hon
-1 siblings, 0 replies; 6+ messages in thread
From: Jimmy Hon @ 2026-08-11 4:39 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>
> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
> MMUs, and connect the regulators.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> .../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 854c118418eb..dd29a3ea7031 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -300,6 +300,10 @@ &pcie2x1l2 {
> status = "okay";
> };
>
> +&pd_npu {
> + domain-supply = <&vdd_npu_s0>;
> +};
Now that the power domain has control of the regulator. The regulator
should have regulator-always-on removed, so it can be powered down.
Jimmy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
@ 2026-08-11 4:39 ` Jimmy Hon
0 siblings, 0 replies; 6+ messages in thread
From: Jimmy Hon @ 2026-08-11 4:39 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>
> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
> MMUs, and connect the regulators.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> .../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 854c118418eb..dd29a3ea7031 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -300,6 +300,10 @@ &pcie2x1l2 {
> status = "okay";
> };
>
> +&pd_npu {
> + domain-supply = <&vdd_npu_s0>;
> +};
Now that the power domain has control of the regulator. The regulator
should have regulator-always-on removed, so it can be powered down.
Jimmy
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
2026-08-11 4:39 ` Jimmy Hon
@ 2026-08-11 9:59 ` Diederik de Haas
-1 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2026-08-11 9:59 UTC (permalink / raw)
To: Jimmy Hon, Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
Jonas Karlman, Joachim Eastwood
On Tue Aug 11, 2026 at 6:39 AM CEST, Jimmy Hon wrote:
> On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>>
>> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
>> MMUs, and connect the regulators.
>>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> ---
>> .../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> index 854c118418eb..dd29a3ea7031 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> @@ -300,6 +300,10 @@ &pcie2x1l2 {
>> status = "okay";
>> };
>>
>> +&pd_npu {
>> + domain-supply = <&vdd_npu_s0>;
>> +};
> Now that the power domain has control of the regulator. The regulator
> should have regulator-always-on removed, so it can be powered down.
Next to that, quoting a question that was raised earlier here:
https://lore.kernel.org/all/b9a5beb6-b701-430c-b667-44780736dd89@kwiboo.xyz/
"Why is boot-on kept?, NPU is likely not needed until OS has started.
With PD domain-supply the regulator should be enabled automatically, or
is there some other issue that requires boot firmware to enable this
regulator before OS is started?"
I do realize quite a few other boards have it too, but maybe they
shouldn't have it/them either?
Cheers,
Diederik
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C
@ 2026-08-11 9:59 ` Diederik de Haas
0 siblings, 0 replies; 6+ messages in thread
From: Diederik de Haas @ 2026-08-11 9:59 UTC (permalink / raw)
To: Jimmy Hon, Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree,
Jonas Karlman, Joachim Eastwood
On Tue Aug 11, 2026 at 6:39 AM CEST, Jimmy Hon wrote:
> On Mon, Aug 10, 2026 at 6:20 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>>
>> Like the RK3588, the RK3582 has NPUs. Enable the NPU cores and their
>> MMUs, and connect the regulators.
>>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> ---
>> .../boot/dts/rockchip/rk3582-radxa-e52c.dts | 34 +++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> index 854c118418eb..dd29a3ea7031 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
>> @@ -300,6 +300,10 @@ &pcie2x1l2 {
>> status = "okay";
>> };
>>
>> +&pd_npu {
>> + domain-supply = <&vdd_npu_s0>;
>> +};
> Now that the power domain has control of the regulator. The regulator
> should have regulator-always-on removed, so it can be powered down.
Next to that, quoting a question that was raised earlier here:
https://lore.kernel.org/all/b9a5beb6-b701-430c-b667-44780736dd89@kwiboo.xyz/
"Why is boot-on kept?, NPU is likely not needed until OS has started.
With PD domain-supply the regulator should be enabled automatically, or
is there some other issue that requires boot firmware to enable this
regulator before OS is started?"
I do realize quite a few other boards have it too, but maybe they
shouldn't have it/them either?
Cheers,
Diederik
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-08-11 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-10 10:00 [PATCH 1/1] arm64: dts: rockchip: enable NPU on Radxa E52C Chukun Pan
2026-08-10 10:00 ` Chukun Pan
2026-08-11 4:39 ` Jimmy Hon
2026-08-11 4:39 ` Jimmy Hon
2026-08-11 9:59 ` Diederik de Haas
2026-08-11 9:59 ` Diederik de Haas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.