All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sandie Cao" <sandie.cao@deepcomputing.io>,
	"Yixun Lan" <dlan@kernel.org>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>
Cc: "Alexandre Ghiti" <alex@ghiti.fr>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>,
	"Sandie Cao" <sandie.cao@deepcomputing.io>
Subject: Re: [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Wed, 23 Sep 2026 10:23:26 +0800	[thread overview]
Message-ID: <DLMC741RLFU5.3FF1DL7YEIFK9@linux.spacemit.com> (raw)
In-Reply-To: <20260922110450.3426070-1-sandie.cao@deepcomputing.io>


[-- Attachment #1.1: Type: text/plain, Size: 1026 bytes --]

On Tue, Sep 22, 2026 at 07:04:50PM +0800, Sandie Cao wrote:
> @@ -184,6 +185,24 @@ &combophy {
> [...]
> +&sdhci0 {
> +	pinctrl-names = "default","uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;
> +	bus-width = <4>;
> +	cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;

Does GPIO88 have an external pull-up? The SDK DTS [1] also includes
mmc1_cd_cfg in both pinctrl states, with a pull-up and 3.3 V configuration.
Neither mmc1_cfg nor mmc1_uhs_cfg covers this pin. Is that configuration
unnecessary on this board?

> +	no-mmc;
> +	no-sdio;
> +	disable-wp;
> +	cap-sd-highspeed;
> +	vmmc-supply = <&aldo4>;
> +	vqmmc-supply = <&aldo1>;

Could you confirm which rail supplies the card's VDD? The SDK DTS [1]
uses p3v3 for vmmc rather than aldo4. Does that RPMI regulator map to
ALDO4, or is the card powered by a different rail?

Link: https://github.com/spacemit-com/linux-6.18/blob/k3-br-v1.0.y/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts [1]

-- 
Troy Mitchell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sandie Cao" <sandie.cao@deepcomputing.io>,
	"Yixun Lan" <dlan@kernel.org>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>
Cc: "Alexandre Ghiti" <alex@ghiti.fr>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>,
	"Sandie Cao" <sandie.cao@deepcomputing.io>
Subject: Re: [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Wed, 23 Sep 2026 10:23:26 +0800	[thread overview]
Message-ID: <DLMC741RLFU5.3FF1DL7YEIFK9@linux.spacemit.com> (raw)
In-Reply-To: <20260922110450.3426070-1-sandie.cao@deepcomputing.io>

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

On Tue, Sep 22, 2026 at 07:04:50PM +0800, Sandie Cao wrote:
> @@ -184,6 +185,24 @@ &combophy {
> [...]
> +&sdhci0 {
> +	pinctrl-names = "default","uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;
> +	bus-width = <4>;
> +	cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;

Does GPIO88 have an external pull-up? The SDK DTS [1] also includes
mmc1_cd_cfg in both pinctrl states, with a pull-up and 3.3 V configuration.
Neither mmc1_cfg nor mmc1_uhs_cfg covers this pin. Is that configuration
unnecessary on this board?

> +	no-mmc;
> +	no-sdio;
> +	disable-wp;
> +	cap-sd-highspeed;
> +	vmmc-supply = <&aldo4>;
> +	vqmmc-supply = <&aldo1>;

Could you confirm which rail supplies the card's VDD? The SDK DTS [1]
uses p3v3 for vmmc rather than aldo4. Does that RPMI regulator map to
ALDO4, or is the card powered by a different rail?

Link: https://github.com/spacemit-com/linux-6.18/blob/k3-br-v1.0.y/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts [1]

-- 
Troy Mitchell

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

  reply	other threads:[~2026-09-23  2:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 11:02 [PATCH 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
2026-09-22 11:02 ` Sandie Cao
2026-09-22 11:04 ` [PATCH 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
2026-09-22 11:04   ` Sandie Cao
2026-09-22 11:04 ` [PATCH 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
2026-09-22 11:04   ` Sandie Cao
2026-09-22 11:19   ` sashiko-bot
2026-09-23  2:18   ` Troy Mitchell
2026-09-23  2:18     ` Troy Mitchell
2026-09-23  4:07     ` Sandie Cao
2026-09-23  4:07       ` Sandie Cao
2026-09-23  6:36       ` Troy Mitchell
2026-09-23  6:36         ` Troy Mitchell
2026-09-23  6:44         ` Sandie Cao
2026-09-23  6:44           ` Sandie Cao
2026-09-23 17:33   ` Yao Zi
2026-09-23 17:33     ` Yao Zi
2026-09-22 11:04 ` [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
2026-09-22 11:04   ` Sandie Cao
2026-09-23  2:23   ` Troy Mitchell [this message]
2026-09-23  2:23     ` Troy Mitchell
2026-09-23  6:35     ` Sandie Cao
2026-09-23  6:35       ` Sandie Cao
2026-09-23  7:02       ` Troy Mitchell
2026-09-23  7:02         ` Troy Mitchell
2026-09-23  8:01         ` Sandie Cao
2026-09-23  8:01           ` Sandie Cao
2026-09-23  9:13           ` Troy Mitchell
2026-09-23  9:13             ` Troy Mitchell
2026-09-23  9:51             ` Sandie Cao
2026-09-23  9:51               ` Sandie Cao
2026-09-24  1:18               ` Troy Mitchell
2026-09-24  1:18                 ` Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLMC741RLFU5.3FF1DL7YEIFK9@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.