Re: [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support

From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sandie Cao" <sandie.cao@deepcomputing.io>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: "Yixun Lan" <dlan@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Thu, 24 Sep 2026 09:18:10 +0800	[thread overview]
Message-ID: <DLN5FOFSNKV7.3NL9LZ0FYRPHV@linux.spacemit.com> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.a37d568d.f88e.4fdb.8c5f.8da4b148415f@feishu.cn>

[-- Attachment #1.1: Type: text/plain, Size: 1476 bytes --]

On Wed Sep 23, 2026 at 5:51 PM +08, Sandie Cao wrote:
> Hi, Troy:
>
>> From: "Troy Mitchell"<troy.mitchell@linux.spacemit.com>
>> Date:  Wed, Sep 23, 2026, 17:14
>> On Wed Sep 23, 2026 at 4:01 PM +08, Sandie Cao wrote:
>> > Hi, Troy:
>> >
>> >> From: "Troy Mitchell"<troy.mitchell@linux.spacemit.com>
>> >> Date:  Wed, Sep 23, 2026, 15:02
>> >> On Wed, Sep 23, 2026 at 02:35:20PM +0800, Sandie Cao wrote:
>> >> > FML13V05 SD card slot is inside the board, it doesn't need cd-gpio,
>> >> > FML13V05 Keeps GPIO88 to low, Then SD card is always on for SD Card
>> >> > driver.
>> >> 
>> >> An internal slot does not necessarily mean the card is non-removable.
>> >> I don't think its location alone justifies keeping card detect asserted:
>> >> GPIO88 would report a card present even when the slot is empty.
>> >
>> > Yes. The FML13V05 hardware is designed for this. We can't change it. 
>> 
>> I may not have been clear: an internal card slot does not necessarily
>> mean the card is non-removable. If GPIO88 is connected to the
>> card-detect switch, it still needs a pull-up. Is GPIO88 tied low on
>> the board, or does it reflect the state of that switch?
>
> The FML13V05 SD card slot doesn't have cd-gpio. But the K3 SD card driver need it, so the GPIO88 is tied low on board. 

Sounds like you should use non-removable or broken-cd instead of
cd-gpios.

Note: Please limit line lengths to 80–100 characters.

-- 
Troy Mitchell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 248 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv