All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Typo in arch/mips/dec/wbflush.c
       [not found] <20020624215505.GA7864@galileo>
@ 2002-06-25 16:48 ` Rusty Russell
  2002-06-25 17:24   ` Maciej W. Rozycki
  0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2002-06-25 16:48 UTC (permalink / raw)
  To: James Mayer; +Cc: linux-kernel

In message <20020624215505.GA7864@galileo> you write:
> --- linux.orig-2.4.19-rc1/arch/mips/dec/wbflush.c	Fri Oct  5 13:06:51 200
1
> +++ linux/arch/mips/dec/wbflush.c	Mon Jun 24 15:49:53 2002
> @@ -97,7 +97,7 @@
>  }
>  
>  /*
> - * The DS500/2x0 doesnt need to write back the WB.
> + * The DS500/2x0 doesn't need to write back the WB.
>   */
>  static void wbflush_kn03(void)
>  {

Hmm...

	I've only applied the one that was an actually a definite
spellfix.  While I prefer to use apostrophes, it's a common
abbreviation to skip it: 1/10 according to google.  Compare with
another common misspelling (recieve) which is 1/50.

Given there is a non-zero cost (patch conflict with developers) even
with trivial patches, I've decided not to apply your 41
"doesnt"->"doesn't" patches, unless someone convinces me otherwise.

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Typo in arch/mips/dec/wbflush.c
  2002-06-25 16:48 ` Typo in arch/mips/dec/wbflush.c Rusty Russell
@ 2002-06-25 17:24   ` Maciej W. Rozycki
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2002-06-25 17:24 UTC (permalink / raw)
  To: Rusty Russell; +Cc: James Mayer, linux-kernel

On Wed, 26 Jun 2002, Rusty Russell wrote:

> In message <20020624215505.GA7864@galileo> you write:
> > --- linux.orig-2.4.19-rc1/arch/mips/dec/wbflush.c	Fri Oct  5 13:06:51 200
> 1
> > +++ linux/arch/mips/dec/wbflush.c	Mon Jun 24 15:49:53 2002
> > @@ -97,7 +97,7 @@
> >  }
> >  
> >  /*
> > - * The DS500/2x0 doesnt need to write back the WB.
> > + * The DS500/2x0 doesn't need to write back the WB.
> >   */
> >  static void wbflush_kn03(void)
> >  {
> 
> Hmm...
> 
> 	I've only applied the one that was an actually a definite
> spellfix.  While I prefer to use apostrophes, it's a common
> abbreviation to skip it: 1/10 according to google.  Compare with
> another common misspelling (recieve) which is 1/50.
> 
> Given there is a non-zero cost (patch conflict with developers) even
> with trivial patches, I've decided not to apply your 41
> "doesnt"->"doesn't" patches, unless someone convinces me otherwise.

 There is a formal error in the sentence as well, actually, but I wouldn't
care as the file is to be majorly rewritten (changes are ready and
awaiting an approval of related stuff) and the comment will be removed
anyway.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-06-25 17:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20020624215505.GA7864@galileo>
2002-06-25 16:48 ` Typo in arch/mips/dec/wbflush.c Rusty Russell
2002-06-25 17:24   ` Maciej W. Rozycki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.