All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Bronson <rick@efn.org>
To: linux-omap@vger.kernel.org
Subject: Re: ARM: OMAP3: Fix get_irqnr_and_base to clear spurious interrupt bits
Date: Thu, 23 Oct 2008 11:13:39 -0700	[thread overview]
Message-ID: <E1Kt4gl-0003Zw-EM@amazonia.comcast.net> (raw)

Tony,

> Well we should let the generic irq handler to do the logging.. But I
> guess nothing will happen if adm_do_IRQ() does not get called.
> 
> We could have a dummy handler for some invented higher number that would
> capture the spurious interrupts I guess.
> 
> BTW, ideally we would do the ldr conditionally rather than every time,
> I guess that's the idea with the old way of doing things.

  Well, actually the ldr (I assume you mean this one):

		ldrne	\irqnr, [\base, #INTCPS_SIR_IRQ_OFFSET]

  was being done everytime, since presumably, at least one of the
"pending" bits would be set otherwise how would we get to this
interrupt?  Which bring up a point - why bother even checking the
pending bits at all?   Just grab the irqnr, check for spurious and
exit.

  Rick

             reply	other threads:[~2008-10-23 18:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 18:13 Rick Bronson [this message]
2008-10-23 18:21 ` ARM: OMAP3: Fix get_irqnr_and_base to clear spurious interrupt bits Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2008-10-28 16:10 Rick Bronson
2008-10-28 16:31 ` Tony Lindgren
2008-10-31 19:27 ` Tony Lindgren
2008-10-24  4:14 Rick Bronson
2008-10-23 17:54 Rick Bronson
2008-10-23  3:29 Rick Bronson
2008-10-23 15:43 ` Tony Lindgren
2008-10-22 17:48 Rick Bronson
2008-10-22 18:30 ` Tony Lindgren
2008-10-21  4:58 Tony Lindgren
2008-10-21 20:09 ` Felipe Contreras
2008-10-21 20:37   ` Tony Lindgren
2008-10-21 21:34     ` Felipe Contreras
2008-10-21 22:02       ` Tony Lindgren
2008-10-21 23:25         ` Tony Lindgren
2008-10-22 14:46         ` Felipe Contreras
2008-10-22 21:30           ` Nathan Monson
2008-10-22 21:40             ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Kt4gl-0003Zw-EM@amazonia.comcast.net \
    --to=rick@efn.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.