From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org
Subject: [PATCH v2 05/16] arm64: text replication: add sanity checks
Date: Thu, 27 Jul 2023 16:30:20 +0100 [thread overview]
Message-ID: <E1qP2wW-001CXK-WB@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ZMKNYEkM7YnrDtOt@shell.armlinux.org.uk>
The kernel text and modules must be in separate L0 page table entries.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
arch/arm64/mm/ktext.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/mm/ktext.c b/arch/arm64/mm/ktext.c
index 3a8d37c9abc4..901f159c65e6 100644
--- a/arch/arm64/mm/ktext.c
+++ b/arch/arm64/mm/ktext.c
@@ -3,6 +3,27 @@
* Copyright (C) 2022, Oracle and/or its affiliates.
*/
+#include <linux/kernel.h>
+#include <linux/pgtable.h>
+
+#include <asm/ktext.h>
+#include <asm/memory.h>
+
void __init ktext_replication_init(void)
{
+ int kidx = pgd_index((phys_addr_t)KERNEL_START);
+
+ /*
+ * If we've messed up and the kernel shares a L0 entry with the
+ * module or vmalloc area, then don't even attempt to use text
+ * replication.
+ */
+ if (pgd_index(MODULES_VADDR) == kidx) {
+ pr_warn("Kernel is located in the same L0 index as modules - text replication disabled\n");
+ return;
+ }
+ if (pgd_index(VMALLOC_START) == kidx) {
+ pr_warn("Kernel is located in the same L0 index as vmalloc - text replication disabled\n");
+ return;
+ }
}
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org
Subject: [PATCH v2 05/16] arm64: text replication: add sanity checks
Date: Thu, 27 Jul 2023 16:30:20 +0100 [thread overview]
Message-ID: <E1qP2wW-001CXK-WB@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ZMKNYEkM7YnrDtOt@shell.armlinux.org.uk>
The kernel text and modules must be in separate L0 page table entries.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
arch/arm64/mm/ktext.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/mm/ktext.c b/arch/arm64/mm/ktext.c
index 3a8d37c9abc4..901f159c65e6 100644
--- a/arch/arm64/mm/ktext.c
+++ b/arch/arm64/mm/ktext.c
@@ -3,6 +3,27 @@
* Copyright (C) 2022, Oracle and/or its affiliates.
*/
+#include <linux/kernel.h>
+#include <linux/pgtable.h>
+
+#include <asm/ktext.h>
+#include <asm/memory.h>
+
void __init ktext_replication_init(void)
{
+ int kidx = pgd_index((phys_addr_t)KERNEL_START);
+
+ /*
+ * If we've messed up and the kernel shares a L0 entry with the
+ * module or vmalloc area, then don't even attempt to use text
+ * replication.
+ */
+ if (pgd_index(MODULES_VADDR) == kidx) {
+ pr_warn("Kernel is located in the same L0 index as modules - text replication disabled\n");
+ return;
+ }
+ if (pgd_index(VMALLOC_START) == kidx) {
+ pr_warn("Kernel is located in the same L0 index as vmalloc - text replication disabled\n");
+ return;
+ }
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-27 15:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:29 [PATCH v2 00/17] arm64 kernel text replication Russell King (Oracle)
2023-07-27 15:29 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 01/16] arm64: provide cpu_replace_ttbr1_phys() Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 02/16] arm64: make clean_dcache_range_nopatch() visible Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 03/16] arm64: place kernel in its own L0 page table entry Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 04/16] arm64: text replication: add init function Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle) [this message]
2023-07-27 15:30 ` [PATCH v2 05/16] arm64: text replication: add sanity checks Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 06/16] arm64: text replication: copy initial kernel text Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 07/16] arm64: text replication: add node text patching Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 08/16] arm64: text replication: add node 0 page table definitions Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 09/16] arm64: text replication: add swapper page directory helpers Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 10/16] arm64: text replication: create per-node kernel page tables Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 11/16] arm64: text replication: boot secondary CPUs with appropriate TTBR1 Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:30 ` [PATCH v2 12/16] arm64: text replication: update cnp support Russell King (Oracle)
2023-07-27 15:30 ` Russell King (Oracle)
2023-07-27 15:31 ` [PATCH v2 13/16] arm64: text replication: setup page tables for copied kernel Russell King (Oracle)
2023-07-27 15:31 ` Russell King (Oracle)
2023-07-27 15:31 ` [PATCH v2 14/16] arm64: text replication: include most of read-only data as well Russell King (Oracle)
2023-07-27 15:31 ` Russell King (Oracle)
2023-07-27 15:31 ` [PATCH v2 15/16] arm64: text replication: early kernel option to enable replication Russell King (Oracle)
2023-07-27 15:31 ` Russell King (Oracle)
2023-07-27 15:31 ` [PATCH v2 16/16] arm64: text replication: add Kconfig Russell King (Oracle)
2023-07-27 15:31 ` Russell King (Oracle)
2023-07-27 15:36 ` Randy Dunlap
2023-07-27 15:36 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1qP2wW-001CXK-WB@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.