All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/x86: asus-armoury: add support for G614PR
@ 2026-06-10 15:21 Marco Scardovi
  2026-06-10 17:54 ` Denis Benato
  2026-06-11 15:02 ` Ilpo Järvinen
  0 siblings, 2 replies; 4+ messages in thread
From: Marco Scardovi @ 2026-06-10 15:21 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel

Add TDP power limits and fan curve requirements for the ASUS ROG Strix
G16 G614PR laptop model.

The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
(PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
correctly under various power profiles. Without these limits, the Asus
Armoury driver cannot configure the correct power envelopes or enable custom
fan curves, leading to suboptimal performance or noise management.

This patch adds the corresponding DMI board name matching entry ("G614PR")
under the power_limits table in asus-armoury.h, populating the AC and DC
limits based on the platform's hardware specification.

Assisted-by: Antigravity:gemini-3.5-flash
Signed-off-by: Marco Scardovi <scardracs@disroot.org>
---
 drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
index 692978b61959..5be34b6a92db 100644
--- a/drivers/platform/x86/asus-armoury.h
+++ b/drivers/platform/x86/asus-armoury.h
@@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 30,
+				.ppt_pl1_spl_max = 90,
+				.ppt_pl2_sppt_min = 65,
+				.ppt_pl2_sppt_def = 110,
+				.ppt_pl2_sppt_max = 125,
+				.ppt_pl3_fppt_min = 65,
+				.ppt_pl3_fppt_def = 110,
+				.ppt_pl3_fppt_max = 125,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_tgp_min = 65,
+				.nv_tgp_max = 115,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl1_spl_max = 65,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 65,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 75,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
@ 2026-06-10 17:54 ` Denis Benato
  2026-06-11 15:02 ` Ilpo Järvinen
  1 sibling, 0 replies; 4+ messages in thread
From: Denis Benato @ 2026-06-10 17:54 UTC (permalink / raw)
  To: Marco Scardovi, Luke D . Jones, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel


On 6/10/26 17:21, Marco Scardovi wrote:
> Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> G16 G614PR laptop model.
>
> The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> correctly under various power profiles. Without these limits, the Asus
> Armoury driver cannot configure the correct power envelopes or enable custom
> fan curves, leading to suboptimal performance or noise management.
>
> This patch adds the corresponding DMI board name matching entry ("G614PR")
> under the power_limits table in asus-armoury.h, populating the AC and DC
> limits based on the platform's hardware specification.
Reviewed-by: Denis Benato <denis.benato@linux.dev>
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Marco Scardovi <scardracs@disroot.org>
> ---
>  drivers/platform/x86/asus-armoury.h | 34 +++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index 692978b61959..5be34b6a92db 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -1898,6 +1898,40 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "G614PR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 90,
> +				.ppt_pl2_sppt_min = 65,
> +				.ppt_pl2_sppt_def = 110,
> +				.ppt_pl2_sppt_max = 125,
> +				.ppt_pl3_fppt_min = 65,
> +				.ppt_pl3_fppt_def = 110,
> +				.ppt_pl3_fppt_max = 125,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_tgp_min = 65,
> +				.nv_tgp_max = 115,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 65,
> +				.ppt_pl2_sppt_min = 25,
> +				.ppt_pl2_sppt_max = 65,
> +				.ppt_pl3_fppt_min = 35,
> +				.ppt_pl3_fppt_max = 75,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "G615LR"),

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
  2026-06-10 17:54 ` Denis Benato
@ 2026-06-11 15:02 ` Ilpo Järvinen
  2026-06-11 15:53   ` Marco Scardovi
  1 sibling, 1 reply; 4+ messages in thread
From: Ilpo Järvinen @ 2026-06-11 15:02 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Marco Scardovi
  Cc: platform-driver-x86, linux-kernel

On Wed, 10 Jun 2026 17:21:30 +0200, Marco Scardovi wrote:

> Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> G16 G614PR laptop model.
> 
> The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> correctly under various power profiles. Without these limits, the Asus
> Armoury driver cannot configure the correct power envelopes or enable custom
> fan curves, leading to suboptimal performance or noise management.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: asus-armoury: add support for G614PR
      commit: 6b3bbe770f4ca0439710b7c42f88b9f6eeebabd0

--
 i.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for G614PR
  2026-06-11 15:02 ` Ilpo Järvinen
@ 2026-06-11 15:53   ` Marco Scardovi
  0 siblings, 0 replies; 4+ messages in thread
From: Marco Scardovi @ 2026-06-11 15:53 UTC (permalink / raw)
  To: Luke D . Jones, Denis Benato, Corentin Chary, Hans de Goede,
	Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel

In data giovedì 11 giugno 2026 17:02:39 Ora legale dell’Europa centrale, Ilpo 
Järvinen ha scritto:
> On Wed, 10 Jun 2026 17:21:30 +0200, Marco Scardovi wrote:
> > Add TDP power limits and fan curve requirements for the ASUS ROG Strix
> > G16 G614PR laptop model.
> > 
> > The ASUS ROG Strix G16 G614PR requires specific AC/DC power limits
> > (PPT PL1/PL2/PL3, dynamic boost, and NV TGP targets) to function
> > correctly under various power profiles. Without these limits, the Asus
> > Armoury driver cannot configure the correct power envelopes or enable
> > custom fan curves, leading to suboptimal performance or noise management.
> > 
> > [...]
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-next branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/1] platform/x86: asus-armoury: add support for G614PR
>       commit: 6b3bbe770f4ca0439710b7c42f88b9f6eeebabd0
> 
> --
>  i.

Hi! Thank you for picking it up :) I'm not in a rush and tbf I was expecting 
it would take some time.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-11 15:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 15:21 [PATCH] platform/x86: asus-armoury: add support for G614PR Marco Scardovi
2026-06-10 17:54 ` Denis Benato
2026-06-11 15:02 ` Ilpo Järvinen
2026-06-11 15:53   ` Marco Scardovi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.