All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, agk@redhat.com
Subject: Re: stack overflow on Sparc64
Date: Fri, 20 Jun 2008 21:14:41 +0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0806201707270.8990@engineering.redhat.com> (raw)
In-Reply-To: <20080620.102601.06998427.davem@davemloft.net>



On Fri, 20 Jun 2008, David Miller wrote:

> From: Mikulas Patocka <mpatocka@redhat.com>
> Date: Fri, 20 Jun 2008 11:47:12 -0400 (EDT)
>
>> I took another few traces (to track the whole stack content) and there is
>> another problem: nested interrupts. Does Sparc64 limit them somehow?
>
> Two levels should be the deepest you will ever see, and this is
> equivalent to what you get on other platforms.

Are you sure? What about this:
ide-io.c:ide_intr
         if (drive->unmask)
                 local_irq_enable_in_hardirq();

or this:
kernel/irq/handle.c:handle_IRQ_event
         if (!(action->flags & IRQF_DISABLED))
                 local_irq_enable_in_hardirq();


--- how is number of nested interrupts here supposed to be limited?

If these things are not limited, you get at most as many nested handlers 
as there are hardware interrupts, which means crash.

Mikulas

> That path occurs when softirq processing re-enabled HW interrupts when
> returning from the top-level interrupt.

WARNING: multiple messages have this Message-ID (diff)
From: Mikulas Patocka <mpatocka@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, agk@redhat.com
Subject: Re: stack overflow on Sparc64
Date: Fri, 20 Jun 2008 17:14:41 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0806201707270.8990@engineering.redhat.com> (raw)
In-Reply-To: <20080620.102601.06998427.davem@davemloft.net>



On Fri, 20 Jun 2008, David Miller wrote:

> From: Mikulas Patocka <mpatocka@redhat.com>
> Date: Fri, 20 Jun 2008 11:47:12 -0400 (EDT)
>
>> I took another few traces (to track the whole stack content) and there is
>> another problem: nested interrupts. Does Sparc64 limit them somehow?
>
> Two levels should be the deepest you will ever see, and this is
> equivalent to what you get on other platforms.

Are you sure? What about this:
ide-io.c:ide_intr
         if (drive->unmask)
                 local_irq_enable_in_hardirq();

or this:
kernel/irq/handle.c:handle_IRQ_event
         if (!(action->flags & IRQF_DISABLED))
                 local_irq_enable_in_hardirq();


--- how is number of nested interrupts here supposed to be limited?

If these things are not limited, you get at most as many nested handlers 
as there are hardware interrupts, which means crash.

Mikulas

> That path occurs when softirq processing re-enabled HW interrupts when
> returning from the top-level interrupt.

  parent reply	other threads:[~2008-06-20 21:14 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  0:47 stack overflow on Sparc64 Mikulas Patocka
2008-06-18  0:47 ` Mikulas Patocka
2008-06-18  4:01 ` David Miller
2008-06-18  4:01   ` David Miller
2008-06-19  3:24   ` Mikulas Patocka
2008-06-19  3:24     ` Mikulas Patocka
2008-06-19  3:59     ` David Miller
2008-06-19  3:59       ` David Miller
2008-06-19  5:17       ` Mikulas Patocka
2008-06-19  5:17         ` Mikulas Patocka
2008-06-19  6:37         ` David Miller
2008-06-19  6:37           ` David Miller
2008-06-19 13:01           ` Mikulas Patocka
2008-06-19 13:01             ` Mikulas Patocka
2008-06-20 15:47   ` Mikulas Patocka
2008-06-20 15:47     ` Mikulas Patocka
2008-06-20 17:26     ` David Miller
2008-06-20 17:26       ` David Miller
2008-06-20 20:34       ` Mikulas Patocka
2008-06-20 20:34         ` Mikulas Patocka
2008-06-20 20:37         ` David Miller
2008-06-20 20:37           ` David Miller
2008-06-20 21:26           ` Mikulas Patocka
2008-06-20 21:26             ` Mikulas Patocka
2008-06-20 21:41             ` David Miller
2008-06-20 21:41               ` David Miller
2008-06-21  4:51               ` David Miller
2008-06-21  4:51                 ` David Miller
2008-06-21 19:42                 ` Mikulas Patocka
2008-06-21 19:42                   ` Mikulas Patocka
2008-06-22  7:03                   ` David Miller
2008-06-22  7:03                     ` David Miller
2008-06-22 13:48                     ` Mikulas Patocka
2008-06-22 13:48                       ` Mikulas Patocka
2008-08-12  6:30                   ` David Miller
2008-08-12  6:30                     ` David Miller
2008-08-12  8:22                     ` David Miller
2008-08-12  8:22                       ` David Miller
2008-08-13  0:53                       ` Mikulas Patocka
2008-08-13  0:53                         ` Mikulas Patocka
2008-08-13  0:59                         ` David Miller
2008-08-13  0:59                           ` David Miller
2008-08-13  1:11                     ` console handover badness [was: stack overflow on Sparc64] Mikulas Patocka
2008-08-13  1:11                       ` Mikulas Patocka
2008-08-13  1:22                       ` console handover badness David Miller
2008-08-13  1:22                         ` David Miller
2008-08-13  1:40                       ` David Miller
2008-08-13  1:40                         ` David Miller
2008-08-13  8:50                         ` David Miller
2008-08-13  8:50                           ` David Miller
2008-08-13 12:46                         ` Mikulas Patocka
2008-08-13 12:46                           ` Mikulas Patocka
2008-08-14  3:25                           ` David Miller
2008-08-14  3:25                             ` David Miller
2008-08-14 23:11                             ` Bootmem allocator broken [was: console handover badness] Mikulas Patocka
2008-08-14 23:11                               ` Mikulas Patocka
2008-08-14 23:25                               ` Bootmem allocator broken David Miller
2008-08-14 23:25                                 ` David Miller
2008-08-15 11:09                                 ` Alexander Beregalov
2008-08-15 11:09                                   ` Alexander Beregalov
2008-08-15 21:13                                   ` David Miller
2008-08-15 21:13                                     ` David Miller
2008-08-14 23:40                               ` Johannes Weiner
2008-08-14 23:40                                 ` Johannes Weiner
2008-06-20 21:14       ` Mikulas Patocka [this message]
2008-06-20 21:14         ` stack overflow on Sparc64 Mikulas Patocka
2008-06-20 21:20         ` David Miller
2008-06-20 21:20           ` David Miller
2008-06-20 21:25           ` Mikulas Patocka
2008-06-20 21:25             ` Mikulas Patocka
2008-06-20 21:44             ` David Miller
2008-06-20 21:44               ` David Miller
2008-06-20 21:47               ` David Miller
2008-06-20 21:47                 ` David Miller
2008-06-20 22:22                 ` Mikulas Patocka
2008-06-20 22:22                   ` Mikulas Patocka
2008-06-20 22:28                   ` David Miller
2008-06-20 22:28                     ` David Miller
2008-06-20 22:36                     ` Mikulas Patocka
2008-06-20 22:36                       ` Mikulas Patocka
2008-06-20 22:47                       ` David Miller
2008-06-20 22:47                         ` David Miller
2008-06-21  0:37                         ` Mikulas Patocka
2008-06-21  0:37                           ` Mikulas Patocka
2008-06-20 22:33               ` Mikulas Patocka
2008-06-20 22:33                 ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0806201707270.8990@engineering.redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.