All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/5] i2c: hpe: Add GXP SoC I2C Controller
Date: Fri, 17 Feb 2023 23:08:32 +0100	[thread overview]
Message-ID: <Y+/64OlWnV8f0GOL@shikoro> (raw)
In-Reply-To: <20230217155054.99757-2-nick.hawkins@hpe.com>

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Fri, Feb 17, 2023 at 09:50:50AM -0600, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> The GXP SoC supports 10 I2C engines. Each I2C engine is completely
> independent and can function both as an I2C master and I2C slave. The
> I2C master can operate in a multi master environment. The engines support
> a scalable speed from 8kHZ to 1.5 Mhz.
> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 

Thank you for adding the #defines, it makes the code much easier to
understand. I noticed one thing to fix, but I will send an incremental
patch for it.

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/5] i2c: hpe: Add GXP SoC I2C Controller
Date: Fri, 17 Feb 2023 23:08:32 +0100	[thread overview]
Message-ID: <Y+/64OlWnV8f0GOL@shikoro> (raw)
In-Reply-To: <20230217155054.99757-2-nick.hawkins@hpe.com>


[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]

On Fri, Feb 17, 2023 at 09:50:50AM -0600, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> The GXP SoC supports 10 I2C engines. Each I2C engine is completely
> independent and can function both as an I2C master and I2C slave. The
> I2C master can operate in a multi master environment. The engines support
> a scalable speed from 8kHZ to 1.5 Mhz.
> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 

Thank you for adding the #defines, it makes the code much easier to
understand. I noticed one thing to fix, but I will send an incremental
patch for it.

Applied to for-next, thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-17 22:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 15:50 [PATCH v5 0/5] ARM: Add GXP I2C Support nick.hawkins
2023-02-17 15:50 ` nick.hawkins
2023-02-17 15:50 ` [PATCH v5 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:08   ` Wolfram Sang [this message]
2023-02-17 22:08     ` Wolfram Sang
2023-02-17 15:50 ` [PATCH v5 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:08   ` Wolfram Sang
2023-02-17 22:08     ` Wolfram Sang
2023-02-17 15:50 ` [PATCH v5 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-18 10:10   ` Krzysztof Kozlowski
2023-02-18 10:10     ` Krzysztof Kozlowski
2023-02-23 21:02     ` Hawkins, Nick
2023-02-23 21:02       ` Hawkins, Nick
2023-02-24  8:25       ` Krzysztof Kozlowski
2023-02-24  8:25         ` Krzysztof Kozlowski
2023-02-17 15:50 ` [PATCH v5 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 15:50 ` [PATCH v5 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:09   ` Wolfram Sang
2023-02-17 22:09     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+/64OlWnV8f0GOL@shikoro \
    --to=wsa@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nick.hawkins@hpe.com \
    --cc=robh+dt@kernel.org \
    --cc=verdun@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.