All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, wsa@kernel.org
Subject: Re: [PATCH v5 3/5] ARM: dts: hpe: Add I2C Topology
Date: Sat, 18 Feb 2023 11:10:25 +0100	[thread overview]
Message-ID: <dc708865-6005-760f-cbb0-cb2d1d989b9d@linaro.org> (raw)
In-Reply-To: <20230217155054.99757-4-nick.hawkins@hpe.com>

On 17/02/2023 16:50, nick.hawkins@hpe.com wrote:
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..3bc071149bae 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -122,6 +122,131 @@
>  				interrupts = <6>;
>  				interrupt-parent = <&vic0>;
>  			};
> +
> +			sysreg_system_controller: syscon@f8 {
> +				compatible = "hpe,gxp-sysreg", "syscon";
> +				reg = <0xf8 0x8>;
> +			};
> +
> +			i2c0: i2c@2000 {
> +				compatible = "hpe,gxp-i2c";
> +				reg = <0x2000 0x70>;
> +				interrupts = <9>;
> +				interrupt-parent = <&vic0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				status = "disabled";
> +				hpe,sysreg = <&sysreg_system_controller>;
> +				clock-frequency = <100000>;

clock-frequency is a property of the board. If it is fixed in the SoC,
then make it fixed in the driver and there is no point for this property
in DT.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, wsa@kernel.org
Subject: Re: [PATCH v5 3/5] ARM: dts: hpe: Add I2C Topology
Date: Sat, 18 Feb 2023 11:10:25 +0100	[thread overview]
Message-ID: <dc708865-6005-760f-cbb0-cb2d1d989b9d@linaro.org> (raw)
In-Reply-To: <20230217155054.99757-4-nick.hawkins@hpe.com>

On 17/02/2023 16:50, nick.hawkins@hpe.com wrote:
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..3bc071149bae 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -122,6 +122,131 @@
>  				interrupts = <6>;
>  				interrupt-parent = <&vic0>;
>  			};
> +
> +			sysreg_system_controller: syscon@f8 {
> +				compatible = "hpe,gxp-sysreg", "syscon";
> +				reg = <0xf8 0x8>;
> +			};
> +
> +			i2c0: i2c@2000 {
> +				compatible = "hpe,gxp-i2c";
> +				reg = <0x2000 0x70>;
> +				interrupts = <9>;
> +				interrupt-parent = <&vic0>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				status = "disabled";
> +				hpe,sysreg = <&sysreg_system_controller>;
> +				clock-frequency = <100000>;

clock-frequency is a property of the board. If it is fixed in the SoC,
then make it fixed in the driver and there is no point for this property
in DT.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-18 10:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 15:50 [PATCH v5 0/5] ARM: Add GXP I2C Support nick.hawkins
2023-02-17 15:50 ` nick.hawkins
2023-02-17 15:50 ` [PATCH v5 1/5] i2c: hpe: Add GXP SoC I2C Controller nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:08   ` Wolfram Sang
2023-02-17 22:08     ` Wolfram Sang
2023-02-17 15:50 ` [PATCH v5 2/5] dt-bindings: i2c: Add hpe,gxp-i2c nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:08   ` Wolfram Sang
2023-02-17 22:08     ` Wolfram Sang
2023-02-17 15:50 ` [PATCH v5 3/5] ARM: dts: hpe: Add I2C Topology nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-18 10:10   ` Krzysztof Kozlowski [this message]
2023-02-18 10:10     ` Krzysztof Kozlowski
2023-02-23 21:02     ` Hawkins, Nick
2023-02-23 21:02       ` Hawkins, Nick
2023-02-24  8:25       ` Krzysztof Kozlowski
2023-02-24  8:25         ` Krzysztof Kozlowski
2023-02-17 15:50 ` [PATCH v5 4/5] ARM: multi_v7_defconfig: add gxp i2c module nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 15:50 ` [PATCH v5 5/5] MAINTAINERS: Add HPE GXP I2C Support nick.hawkins
2023-02-17 15:50   ` nick.hawkins
2023-02-17 22:09   ` Wolfram Sang
2023-02-17 22:09     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc708865-6005-760f-cbb0-cb2d1d989b9d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nick.hawkins@hpe.com \
    --cc=robh+dt@kernel.org \
    --cc=verdun@hpe.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.