[PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base
@ 2023-02-16 14:34 Matthias Schiffer
  2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Matthias Schiffer @ 2023-02-16 14:34 UTC (permalink / raw)
  To: Lee Jones; +Cc: Andrew Lunn, linux-kernel, linux, Matthias Schiffer

The I2C_DETECT register is at IO port 0x1a7, which is outside the range
passed to devm_ioport_map() for io_base, and was only working because
there aren't actually any bounds checks for IO port accesses.

Extending the range does not seem like a good solution here, as it would
then conflict with the IO resource assigned to the I2C controller. As
this is just a one-off access during probe, use a simple inb() instead.

While we're at it, drop the unused define TQMX86_REG_I2C_INT_EN.

Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 drivers/mfd/tqmx86.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index 7ae906ff8e353..8dcbdafa88f4f 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -49,9 +49,8 @@
 #define TQMX86_REG_IO_EXT_INT_MASK		0x3
 #define TQMX86_REG_IO_EXT_INT_GPIO_SHIFT	4
 
-#define TQMX86_REG_I2C_DETECT	0x47
+#define TQMX86_REG_I2C_DETECT	0x1a7
 #define TQMX86_REG_I2C_DETECT_SOFT		0xa5
-#define TQMX86_REG_I2C_INT_EN	0x49
 
 static uint gpio_irq;
 module_param(gpio_irq, uint, 0);
@@ -213,7 +212,7 @@ static int tqmx86_probe(struct platform_device *pdev)
 		 "Found %s - Board ID %d, PCB Revision %d, PLD Revision %d\n",
 		 board_name, board_id, rev >> 4, rev & 0xf);
 
-	i2c_det = ioread8(io_base + TQMX86_REG_I2C_DETECT);
+	i2c_det = inb(TQMX86_REG_I2C_DETECT);
 
 	if (gpio_irq_cfg) {
 		io_ext_int_val =
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely
  2023-02-16 14:34 [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
@ 2023-02-16 14:34 ` Matthias Schiffer
  2023-02-16 17:20   ` Andrew Lunn
  2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
  2023-02-16 17:19 ` [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Andrew Lunn
  2 siblings, 1 reply; 6+ messages in thread
From: Matthias Schiffer @ 2023-02-16 14:34 UTC (permalink / raw)
  To: Lee Jones; +Cc: Andrew Lunn, linux-kernel, linux, Matthias Schiffer

Registers 0x160..0x17f are unassigned. Use 0x180 as base register and
update offets accordingly.

Also change the size of the range to include 0x19f. While 0x19f is
currently reserved for future extensions, so are several of the previous
registers up to 0x19e, and it is weird to leave out just the last one.

Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 drivers/mfd/tqmx86.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index 8dcbdafa88f4f..1957db881c3a1 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -16,8 +16,8 @@
 #include <linux/platform_data/i2c-ocores.h>
 #include <linux/platform_device.h>
 
-#define TQMX86_IOBASE	0x160
-#define TQMX86_IOSIZE	0x3f
+#define TQMX86_IOBASE	0x180
+#define TQMX86_IOSIZE	0x20
 #define TQMX86_IOBASE_I2C	0x1a0
 #define TQMX86_IOSIZE_I2C	0xa
 #define TQMX86_IOBASE_WATCHDOG	0x18b
@@ -25,7 +25,7 @@
 #define TQMX86_IOBASE_GPIO	0x18d
 #define TQMX86_IOSIZE_GPIO	0x4
 
-#define TQMX86_REG_BOARD_ID	0x20
+#define TQMX86_REG_BOARD_ID	0x00
 #define TQMX86_REG_BOARD_ID_E38M	1
 #define TQMX86_REG_BOARD_ID_50UC	2
 #define TQMX86_REG_BOARD_ID_E38C	3
@@ -40,8 +40,8 @@
 #define TQMX86_REG_BOARD_ID_E40S	13
 #define TQMX86_REG_BOARD_ID_E40C1	14
 #define TQMX86_REG_BOARD_ID_E40C2	15
-#define TQMX86_REG_BOARD_REV	0x21
-#define TQMX86_REG_IO_EXT_INT	0x26
+#define TQMX86_REG_BOARD_REV	0x01
+#define TQMX86_REG_IO_EXT_INT	0x06
 #define TQMX86_REG_IO_EXT_INT_NONE		0
 #define TQMX86_REG_IO_EXT_INT_7			1
 #define TQMX86_REG_IO_EXT_INT_9			2
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely
  2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
@ 2023-02-16 17:20   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-02-16 17:20 UTC (permalink / raw)
  To: Matthias Schiffer; +Cc: Lee Jones, linux-kernel, linux

On Thu, Feb 16, 2023 at 03:34:23PM +0100, Matthias Schiffer wrote:
> Registers 0x160..0x17f are unassigned. Use 0x180 as base register and
> update offets accordingly.
> 
> Also change the size of the range to include 0x19f. While 0x19f is
> currently reserved for future extensions, so are several of the previous
> registers up to 0x19e, and it is weird to leave out just the last one.
> 
> Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x
  2023-02-16 14:34 [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
  2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
@ 2023-02-16 14:34 ` Matthias Schiffer
  2023-02-16 17:11   ` Andrew Lunn
  2023-02-16 17:19 ` [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Andrew Lunn
  2 siblings, 1 reply; 6+ messages in thread
From: Matthias Schiffer @ 2023-02-16 14:34 UTC (permalink / raw)
  To: Lee Jones; +Cc: Andrew Lunn, linux-kernel, linux, Matthias Schiffer

It seems that this driver was developed based on preliminary documentation.
Report the correct names for all TQMxE39x variants, as they are used by
the released hardware revisions:

- Fix names for TQMxE39C1/C2 board IDs
- Distinguish TQMxE39M and TQMxE39S, which use the same board ID

The TQMxE39M/S are distinguished using the SAUC (Sanctioned Alternate
Uses Configuration) register of the GPIO controller. This also prepares
for the correct handling of the differences between the GPIO controllers
of our COMe and SMARC modules.

Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 drivers/mfd/tqmx86.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index 1957db881c3a1..e80100dee7019 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -30,9 +30,9 @@
 #define TQMX86_REG_BOARD_ID_50UC	2
 #define TQMX86_REG_BOARD_ID_E38C	3
 #define TQMX86_REG_BOARD_ID_60EB	4
-#define TQMX86_REG_BOARD_ID_E39M	5
-#define TQMX86_REG_BOARD_ID_E39C	6
-#define TQMX86_REG_BOARD_ID_E39x	7
+#define TQMX86_REG_BOARD_ID_E39MS	5
+#define TQMX86_REG_BOARD_ID_E39C1	6
+#define TQMX86_REG_BOARD_ID_E39C2	7
 #define TQMX86_REG_BOARD_ID_70EB	8
 #define TQMX86_REG_BOARD_ID_80UC	9
 #define TQMX86_REG_BOARD_ID_110EB	11
@@ -48,6 +48,7 @@
 #define TQMX86_REG_IO_EXT_INT_12		3
 #define TQMX86_REG_IO_EXT_INT_MASK		0x3
 #define TQMX86_REG_IO_EXT_INT_GPIO_SHIFT	4
+#define TQMX86_REG_SAUC		0x17
 
 #define TQMX86_REG_I2C_DETECT	0x1a7
 #define TQMX86_REG_I2C_DETECT_SOFT		0xa5
@@ -110,7 +111,7 @@ static const struct mfd_cell tqmx86_devs[] = {
 	},
 };
 
-static const char *tqmx86_board_id_to_name(u8 board_id)
+static const char *tqmx86_board_id_to_name(u8 board_id, u8 sauc)
 {
 	switch (board_id) {
 	case TQMX86_REG_BOARD_ID_E38M:
@@ -121,12 +122,12 @@ static const char *tqmx86_board_id_to_name(u8 board_id)
 		return "TQMxE38C";
 	case TQMX86_REG_BOARD_ID_60EB:
 		return "TQMx60EB";
-	case TQMX86_REG_BOARD_ID_E39M:
-		return "TQMxE39M";
-	case TQMX86_REG_BOARD_ID_E39C:
-		return "TQMxE39C";
-	case TQMX86_REG_BOARD_ID_E39x:
-		return "TQMxE39x";
+	case TQMX86_REG_BOARD_ID_E39MS:
+		return (sauc == 0xff) ? "TQMxE39M" : "TQMxE39S";
+	case TQMX86_REG_BOARD_ID_E39C1:
+		return "TQMxE39C1";
+	case TQMX86_REG_BOARD_ID_E39C2:
+		return "TQMxE39C2";
 	case TQMX86_REG_BOARD_ID_70EB:
 		return "TQMx70EB";
 	case TQMX86_REG_BOARD_ID_80UC:
@@ -159,9 +160,9 @@ static int tqmx86_board_id_to_clk_rate(struct device *dev, u8 board_id)
 	case TQMX86_REG_BOARD_ID_E40C1:
 	case TQMX86_REG_BOARD_ID_E40C2:
 		return 24000;
-	case TQMX86_REG_BOARD_ID_E39M:
-	case TQMX86_REG_BOARD_ID_E39C:
-	case TQMX86_REG_BOARD_ID_E39x:
+	case TQMX86_REG_BOARD_ID_E39MS:
+	case TQMX86_REG_BOARD_ID_E39C1:
+	case TQMX86_REG_BOARD_ID_E39C2:
 		return 25000;
 	case TQMX86_REG_BOARD_ID_E38M:
 	case TQMX86_REG_BOARD_ID_E38C:
@@ -175,7 +176,7 @@ static int tqmx86_board_id_to_clk_rate(struct device *dev, u8 board_id)
 
 static int tqmx86_probe(struct platform_device *pdev)
 {
-	u8 board_id, rev, i2c_det, io_ext_int_val;
+	u8 board_id, sauc, rev, i2c_det, io_ext_int_val;
 	struct device *dev = &pdev->dev;
 	u8 gpio_irq_cfg, readback;
 	const char *board_name;
@@ -205,7 +206,8 @@ static int tqmx86_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	board_id = ioread8(io_base + TQMX86_REG_BOARD_ID);
-	board_name = tqmx86_board_id_to_name(board_id);
+	sauc = ioread8(io_base + TQMX86_REG_SAUC);
+	board_name = tqmx86_board_id_to_name(board_id, sauc);
 	rev = ioread8(io_base + TQMX86_REG_BOARD_REV);
 
 	dev_info(dev,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x
  2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
@ 2023-02-16 17:11   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-02-16 17:11 UTC (permalink / raw)
  To: Matthias Schiffer; +Cc: Lee Jones, linux-kernel, linux

On Thu, Feb 16, 2023 at 03:34:24PM +0100, Matthias Schiffer wrote:
> It seems that this driver was developed based on preliminary documentation.

I cannot say anything about that. I just took the driver that Vadim
V.Vlasov <vvlasov@dev.rtsoft.ru> wrote and cleaned it up to kernel
standards and submitted it. I never found any documentation and i only
ever had access to one board to test on.

Thanks for fixing this.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base
  2023-02-16 14:34 [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
  2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
  2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
@ 2023-02-16 17:19 ` Andrew Lunn
  2 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2023-02-16 17:19 UTC (permalink / raw)
  To: Matthias Schiffer; +Cc: Lee Jones, linux-kernel, linux

> -	i2c_det = ioread8(io_base + TQMX86_REG_I2C_DETECT);
> +	i2c_det = inb(TQMX86_REG_I2C_DETECT);

I think it would be good to add a comment, since it now looks out of
place compared to all the other ioread8().

      Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-02-16 17:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 14:34 [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
2023-02-16 17:20   ` Andrew Lunn
2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
2023-02-16 17:11   ` Andrew Lunn
2023-02-16 17:19 ` [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.