All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Vadim Fedorenko <vfedorenko@novek.ru>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, Vadim Fedorenko <vadfed@fb.com>
Subject: Re: [RFC PATCH v3 1/6] dpll: Add DPLL framework base functions
Date: Wed, 12 Oct 2022 18:51:55 +0200	[thread overview]
Message-ID: <Y0bwq4YyeWsODPjv@nanopsycho> (raw)
In-Reply-To: <20221010011804.23716-2-vfedorenko@novek.ru>

Mon, Oct 10, 2022 at 03:17:59AM CEST, vfedorenko@novek.ru wrote:
>From: Vadim Fedorenko <vadfed@fb.com>
>
>DPLL framework is used to represent and configure DPLL devices
>in systems. Each device that has DPLL and can configure sources
>and outputs can use this framework.
>
>Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
>Co-developed-by: Jakub Kicinski <kuba@kernel.org>
>Co-developed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>---

[..]

>+enum dpll_genl_status {
>+	DPLL_STATUS_NONE,
>+	DPLL_STATUS_CALIBRATING,
>+	DPLL_STATUS_LOCKED,
>+
>+	__DPLL_STATUS_MAX,
>+};
>+#define DPLL_STATUS_MAX (__DPLL_STATUS_MAX - 1)
>+

[..]

>+
>+/* DPLL lock status provides information of source used to lock the device */
>+enum dpll_genl_lock_status {
>+	DPLL_LOCK_STATUS_UNLOCKED,
>+	DPLL_LOCK_STATUS_EXT_1PPS,
>+	DPLL_LOCK_STATUS_EXT_10MHZ,
>+	DPLL_LOCK_STATUS_SYNCE,
>+	DPLL_LOCK_STATUS_INT_OSCILLATOR,
>+	DPLL_LOCK_STATUS_GNSS,
>+
>+	__DPLL_LOCK_STATUS_MAX,
>+};
>+#define DPLL_LOCK_STATUS_MAX (__DPLL_LOCK_STATUS_MAX - 1)

In addition to what I wrote in the previous reply where I suggested to
have lock status independent on type or source, I think we should merge
"status" and "lock status" to one attr/enum. Or any reason to have these
separate?


WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us>
To: Vadim Fedorenko <vfedorenko@novek.ru>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, Vadim Fedorenko <vadfed@fb.com>
Subject: Re: [RFC PATCH v3 1/6] dpll: Add DPLL framework base functions
Date: Wed, 12 Oct 2022 18:51:55 +0200	[thread overview]
Message-ID: <Y0bwq4YyeWsODPjv@nanopsycho> (raw)
In-Reply-To: <20221010011804.23716-2-vfedorenko@novek.ru>

Mon, Oct 10, 2022 at 03:17:59AM CEST, vfedorenko@novek.ru wrote:
>From: Vadim Fedorenko <vadfed@fb.com>
>
>DPLL framework is used to represent and configure DPLL devices
>in systems. Each device that has DPLL and can configure sources
>and outputs can use this framework.
>
>Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
>Co-developed-by: Jakub Kicinski <kuba@kernel.org>
>Co-developed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>---

[..]

>+enum dpll_genl_status {
>+	DPLL_STATUS_NONE,
>+	DPLL_STATUS_CALIBRATING,
>+	DPLL_STATUS_LOCKED,
>+
>+	__DPLL_STATUS_MAX,
>+};
>+#define DPLL_STATUS_MAX (__DPLL_STATUS_MAX - 1)
>+

[..]

>+
>+/* DPLL lock status provides information of source used to lock the device */
>+enum dpll_genl_lock_status {
>+	DPLL_LOCK_STATUS_UNLOCKED,
>+	DPLL_LOCK_STATUS_EXT_1PPS,
>+	DPLL_LOCK_STATUS_EXT_10MHZ,
>+	DPLL_LOCK_STATUS_SYNCE,
>+	DPLL_LOCK_STATUS_INT_OSCILLATOR,
>+	DPLL_LOCK_STATUS_GNSS,
>+
>+	__DPLL_LOCK_STATUS_MAX,
>+};
>+#define DPLL_LOCK_STATUS_MAX (__DPLL_LOCK_STATUS_MAX - 1)

In addition to what I wrote in the previous reply where I suggested to
have lock status independent on type or source, I think we should merge
"status" and "lock status" to one attr/enum. Or any reason to have these
separate?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-10-12 16:52 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  1:17 [RFC PATCH v3 0/5] Create common DPLL/clock configuration API Vadim Fedorenko
2022-10-10  1:17 ` Vadim Fedorenko
2022-10-10  1:17 ` [RFC PATCH v3 1/6] dpll: Add DPLL framework base functions Vadim Fedorenko
2022-10-10  1:17   ` Vadim Fedorenko
2022-10-10  9:18   ` Jiri Pirko
2022-10-10  9:18     ` Jiri Pirko
2022-10-10 19:54     ` Vadim Fedorenko
2022-10-10 19:54       ` Vadim Fedorenko
2022-10-11  8:32       ` Jiri Pirko
2022-10-11  8:32         ` Jiri Pirko
2022-10-11  8:47         ` Jiri Pirko
2022-10-11  8:47           ` Jiri Pirko
2022-10-11 21:31           ` Vadim Fedorenko
2022-10-11 21:31             ` Vadim Fedorenko
2022-10-12  6:44             ` Jiri Pirko
2022-10-12  6:44               ` Jiri Pirko
2022-10-12 20:12               ` Vadim Fedorenko
2022-10-12 20:12                 ` Vadim Fedorenko
2022-10-13  6:55                 ` Jiri Pirko
2022-10-13  6:55                   ` Jiri Pirko
2022-10-13 15:17                   ` Jakub Kicinski
2022-10-13 15:17                     ` Jakub Kicinski
2022-10-14  9:52                     ` Jiri Pirko
2022-10-14  9:52                       ` Jiri Pirko
2022-10-11 21:23         ` Vadim Fedorenko
2022-10-11 21:23           ` Vadim Fedorenko
2022-10-12 10:44           ` Jiri Pirko
2022-10-12 10:44             ` Jiri Pirko
2022-10-12 10:47   ` Jiri Pirko
2022-10-12 10:47     ` Jiri Pirko
2022-10-12 20:15     ` Vadim Fedorenko
2022-10-12 20:15       ` Vadim Fedorenko
2022-10-13  6:56       ` Jiri Pirko
2022-10-13  6:56         ` Jiri Pirko
2022-10-12 16:51   ` Jiri Pirko [this message]
2022-10-12 16:51     ` Jiri Pirko
2022-10-12 20:17     ` Vadim Fedorenko
2022-10-12 20:17       ` Vadim Fedorenko
2022-10-10  1:18 ` [RFC PATCH v3 2/6] dpll: add netlink events Vadim Fedorenko
2022-10-10  1:18   ` Vadim Fedorenko
2022-10-10  1:18 ` [RFC PATCH v3 3/6] dpll: add support for source selection modes Vadim Fedorenko
2022-10-10  1:18   ` Vadim Fedorenko
2022-10-10 14:13   ` Jiri Pirko
2022-10-10 14:13     ` Jiri Pirko
2022-10-10 20:03     ` Vadim Fedorenko
2022-10-10 20:03       ` Vadim Fedorenko
2022-10-10  1:18 ` [RFC PATCH v3 4/6] dpll: get source/output name Vadim Fedorenko
2022-10-10  1:18   ` Vadim Fedorenko
2022-10-10  9:45   ` Jiri Pirko
2022-10-10  9:45     ` Jiri Pirko
2022-10-10 19:55     ` Vadim Fedorenko
2022-10-10 19:55       ` Vadim Fedorenko
2022-10-11  7:28       ` Jiri Pirko
2022-10-11  7:28         ` Jiri Pirko
2022-10-10  1:18 ` [RFC PATCH v3 5/6] dpll: documentation on DPLL subsystem interface Vadim Fedorenko
2022-10-10  1:18   ` Vadim Fedorenko
2022-10-10  1:18 ` [RFC PATCH v3 6/6] ptp_ocp: implement DPLL ops Vadim Fedorenko
2022-10-10  1:18   ` Vadim Fedorenko
2022-10-10 15:42   ` Jiri Pirko
2022-10-10 15:42     ` Jiri Pirko
2022-10-10 20:14     ` Vadim Fedorenko
2022-10-10 20:14       ` Vadim Fedorenko
2022-10-11  7:30       ` Jiri Pirko
2022-10-11  7:30         ` Jiri Pirko
2022-10-11  0:30   ` kernel test robot
2022-10-12 15:14   ` Jiri Pirko
2022-10-12 15:14     ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0bwq4YyeWsODPjv@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vadfed@fb.com \
    --cc=vfedorenko@novek.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.